All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ext4: Don't warn about mnt_count after the first mount of a new mkfsed volume.
@ 2011-05-16 14:53 Tao Ma
  2011-05-18 17:33 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Tao Ma @ 2011-05-16 14:53 UTC (permalink / raw)
  To: linux-ext4

From: Tao Ma <boyu.mt@taobao.com>

Currently, if we mkfs a new ext4 volume and mount it for the first time,
we will get the warning in the message like
warning: maximal mount count reached, running e2fsck is recommended

It is really misleading. So change the check so that it wouldn't warn in that case.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 fs/ext4/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e29535c..92166b7 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1900,7 +1900,7 @@ static int ext4_setup_super(struct super_block *sb, struct ext4_super_block *es,
 		ext4_msg(sb, KERN_WARNING,
 			 "warning: mounting fs with errors, "
 			 "running e2fsck is recommended");
-	else if ((__s16) le16_to_cpu(es->s_max_mnt_count) >= 0 &&
+	else if ((__s16) le16_to_cpu(es->s_max_mnt_count) > 0 &&
 		 le16_to_cpu(es->s_mnt_count) >=
 		 (unsigned short) (__s16) le16_to_cpu(es->s_max_mnt_count))
 		ext4_msg(sb, KERN_WARNING,
-- 
1.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: Don't warn about mnt_count after the first mount of a new mkfsed volume.
  2011-05-16 14:53 [PATCH] ext4: Don't warn about mnt_count after the first mount of a new mkfsed volume Tao Ma
@ 2011-05-18 17:33 ` Ted Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-05-18 17:33 UTC (permalink / raw)
  To: Tao Ma; +Cc: linux-ext4

On Mon, May 16, 2011 at 10:53:23PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> Currently, if we mkfs a new ext4 volume and mount it for the first time,
> we will get the warning in the message like
> warning: maximal mount count reached, running e2fsck is recommended
> 
> It is really misleading. So change the check so that it wouldn't warn in that case.
> 
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>

Added to the ext4 tree, thanks!

						- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-18 17:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-16 14:53 [PATCH] ext4: Don't warn about mnt_count after the first mount of a new mkfsed volume Tao Ma
2011-05-18 17:33 ` Ted Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.