From: Greg KH <gregkh@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
sparclinux@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Josip Rodin <joy@entuzijast.net>
Subject: Re: [PATCH 1/2] of: fix race when matching drivers
Date: Wed, 18 May 2011 19:54:49 +0000 [thread overview]
Message-ID: <20110518195449.GA28653@suse.de> (raw)
In-Reply-To: <20110518192100.28986.94335.stgit@ponder>
On Wed, May 18, 2011 at 01:21:00PM -0600, Grant Likely wrote:
> From: Milton Miller <miltonm@bga.com>
>
> If two drivers are probing devices at the same time, both will write
> their match table result to the dev->of_match cache at the same time.
>
> Only write the result if the device matches.
>
> In a thread titled "SBus devices sometimes detected, sometimes not",
> Meelis reported his SBus hme was not detected about 50% of the time.
> >From the debug suggested by Grant it was obvious another driver matched
> some devices between the call to match the hme and the hme discovery
> failling.
>
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> [grant.likely: modified to only call of_match_device() once]
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
sparclinux@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Josip Rodin <joy@entuzijast.net>
Subject: Re: [PATCH 1/2] of: fix race when matching drivers
Date: Wed, 18 May 2011 12:54:49 -0700 [thread overview]
Message-ID: <20110518195449.GA28653@suse.de> (raw)
In-Reply-To: <20110518192100.28986.94335.stgit@ponder>
On Wed, May 18, 2011 at 01:21:00PM -0600, Grant Likely wrote:
> From: Milton Miller <miltonm@bga.com>
>
> If two drivers are probing devices at the same time, both will write
> their match table result to the dev->of_match cache at the same time.
>
> Only write the result if the device matches.
>
> In a thread titled "SBus devices sometimes detected, sometimes not",
> Meelis reported his SBus hme was not detected about 50% of the time.
> >From the debug suggested by Grant it was obvious another driver matched
> some devices between the call to match the hme and the hme discovery
> failling.
>
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> [grant.likely: modified to only call of_match_device() once]
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2011-05-18 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 19:20 [git pull][PATCH 0/2] Fix regression caused by addition of 'of_match' Grant Likely
2011-05-18 19:20 ` Grant Likely
2011-05-18 19:20 ` Grant Likely
2011-05-18 19:21 ` [PATCH 1/2] of: fix race when matching drivers Grant Likely
2011-05-18 19:21 ` Grant Likely
2011-05-18 19:21 ` Grant Likely
2011-05-18 19:54 ` Greg KH [this message]
2011-05-18 19:54 ` Greg KH
2011-05-18 21:03 ` David Miller
2011-05-18 21:03 ` David Miller
2011-05-18 19:21 ` [PATCH 2/2] drivercore: revert addition of of_match to struct device Grant Likely
2011-05-18 19:21 ` Grant Likely
2011-05-18 19:21 ` Grant Likely
2011-05-18 19:55 ` [PATCH 2/2] drivercore: revert addition of of_match to struct Greg KH
2011-05-18 19:55 ` [PATCH 2/2] drivercore: revert addition of of_match to struct device Greg KH
2011-05-18 19:55 ` Greg KH
2011-05-18 21:03 ` [PATCH 2/2] drivercore: revert addition of of_match to struct David Miller
2011-05-18 21:03 ` [PATCH 2/2] drivercore: revert addition of of_match to struct device David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518195449.GA28653@suse.de \
--to=gregkh@suse.de \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=joy@entuzijast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.