* [PATCH RFC] vhost: fix enable notify: write out last avail value we saw
@ 2011-05-18 21:13 Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-05-18 21:13 UTC (permalink / raw)
To: virtualization
Cc: netdev, linux-kernel, rusty, habanero, Shirley Ma, Krishna Kumar2,
kvm, steved, Tom Lendacky, borntraeger, avi
With RX ring and mergeable buffers, vhost-net sometimes
enables notifications when ring is not empty - just
doesn't have enough entries for the incoming packet.
To get event when entries are added in this case,
we should always write out the last index value
we saw into event index field, which is ahead
of the index we have consumed.
Otherwise we get a kick, see that there are not enough
entries in the ring, reenable notifications
but since last used index was not updated
we don't get any more events.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
This bugfix is on top of my patchset, I'm working on addressing
Rusty's comments for that now.
Will push to my git tree event idx branch for everyone's testing pleasure
shortly.
drivers/vhost/vhost.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 2aea4cb..1267a3d 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1438,7 +1438,7 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
return false;
}
} else {
- r = put_user(vq->last_avail_idx, vhost_avail_event(vq));
+ r = put_user(vq->avail_idx, vhost_avail_event(vq));
if (r) {
vq_err(vq, "Failed to update avail event index at %p: %d\n",
vhost_avail_event(vq), r);
--
1.7.5.53.gc233e
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RFC] vhost: fix enable notify: write out last avail value we saw
@ 2011-05-18 21:13 Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-05-18 21:13 UTC (permalink / raw)
To: virtualization
Cc: Krishna Kumar2, habanero, kvm, steved, netdev, Shirley Ma,
linux-kernel, borntraeger, Tom Lendacky, avi
With RX ring and mergeable buffers, vhost-net sometimes
enables notifications when ring is not empty - just
doesn't have enough entries for the incoming packet.
To get event when entries are added in this case,
we should always write out the last index value
we saw into event index field, which is ahead
of the index we have consumed.
Otherwise we get a kick, see that there are not enough
entries in the ring, reenable notifications
but since last used index was not updated
we don't get any more events.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
This bugfix is on top of my patchset, I'm working on addressing
Rusty's comments for that now.
Will push to my git tree event idx branch for everyone's testing pleasure
shortly.
drivers/vhost/vhost.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 2aea4cb..1267a3d 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -1438,7 +1438,7 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq)
return false;
}
} else {
- r = put_user(vq->last_avail_idx, vhost_avail_event(vq));
+ r = put_user(vq->avail_idx, vhost_avail_event(vq));
if (r) {
vq_err(vq, "Failed to update avail event index at %p: %d\n",
vhost_avail_event(vq), r);
--
1.7.5.53.gc233e
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-18 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-18 21:13 [PATCH RFC] vhost: fix enable notify: write out last avail value we saw Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2011-05-18 21:13 Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.