* [PATCH] bluetooth: Do not ignore errors returned from strict_strtol()
@ 2011-05-19 21:37 David Miller
2011-05-20 2:33 ` Gustavo F. Padovan
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2011-05-19 21:37 UTC (permalink / raw)
To: linux-bluetooth
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/bluetooth/btmrvl_debugfs.c b/drivers/bluetooth/btmrvl_debugfs.c
index fd6305b..8ecf4c6 100644
--- a/drivers/bluetooth/btmrvl_debugfs.c
+++ b/drivers/bluetooth/btmrvl_debugfs.c
@@ -64,6 +64,8 @@ static ssize_t btmrvl_hscfgcmd_write(struct file *file,
return -EFAULT;
ret = strict_strtol(buf, 10, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.hscfgcmd = result;
@@ -108,6 +110,8 @@ static ssize_t btmrvl_psmode_write(struct file *file, const char __user *ubuf,
return -EFAULT;
ret = strict_strtol(buf, 10, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.psmode = result;
@@ -147,6 +151,8 @@ static ssize_t btmrvl_pscmd_write(struct file *file, const char __user *ubuf,
return -EFAULT;
ret = strict_strtol(buf, 10, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.pscmd = result;
@@ -191,6 +197,8 @@ static ssize_t btmrvl_gpiogap_write(struct file *file, const char __user *ubuf,
return -EFAULT;
ret = strict_strtol(buf, 16, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.gpio_gap = result;
@@ -230,6 +238,8 @@ static ssize_t btmrvl_hscmd_write(struct file *file, const char __user *ubuf,
return -EFAULT;
ret = strict_strtol(buf, 10, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.hscmd = result;
if (priv->btmrvl_dev.hscmd) {
@@ -272,6 +282,8 @@ static ssize_t btmrvl_hsmode_write(struct file *file, const char __user *ubuf,
return -EFAULT;
ret = strict_strtol(buf, 10, &result);
+ if (ret)
+ return ret;
priv->btmrvl_dev.hsmode = result;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bluetooth: Do not ignore errors returned from strict_strtol()
2011-05-19 21:37 [PATCH] bluetooth: Do not ignore errors returned from strict_strtol() David Miller
@ 2011-05-20 2:33 ` Gustavo F. Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-05-20 2:33 UTC (permalink / raw)
To: David Miller; +Cc: linux-bluetooth
* David Miller <davem@davemloft.net> [2011-05-19 17:37:45 -0400]:
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/bluetooth/btmrvl_debugfs.c b/drivers/bluetooth/btmrvl_debugfs.c
> index fd6305b..8ecf4c6 100644
> --- a/drivers/bluetooth/btmrvl_debugfs.c
> +++ b/drivers/bluetooth/btmrvl_debugfs.c
> @@ -64,6 +64,8 @@ static ssize_t btmrvl_hscfgcmd_write(struct file *file,
> return -EFAULT;
>
> ret = strict_strtol(buf, 10, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.hscfgcmd = result;
>
> @@ -108,6 +110,8 @@ static ssize_t btmrvl_psmode_write(struct file *file, const char __user *ubuf,
> return -EFAULT;
>
> ret = strict_strtol(buf, 10, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.psmode = result;
>
> @@ -147,6 +151,8 @@ static ssize_t btmrvl_pscmd_write(struct file *file, const char __user *ubuf,
> return -EFAULT;
>
> ret = strict_strtol(buf, 10, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.pscmd = result;
>
> @@ -191,6 +197,8 @@ static ssize_t btmrvl_gpiogap_write(struct file *file, const char __user *ubuf,
> return -EFAULT;
>
> ret = strict_strtol(buf, 16, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.gpio_gap = result;
>
> @@ -230,6 +238,8 @@ static ssize_t btmrvl_hscmd_write(struct file *file, const char __user *ubuf,
> return -EFAULT;
>
> ret = strict_strtol(buf, 10, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.hscmd = result;
> if (priv->btmrvl_dev.hscmd) {
> @@ -272,6 +282,8 @@ static ssize_t btmrvl_hsmode_write(struct file *file, const char __user *ubuf,
> return -EFAULT;
>
> ret = strict_strtol(buf, 10, &result);
> + if (ret)
> + return ret;
>
> priv->btmrvl_dev.hsmode = result;
Applied, thanks Dave!
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-20 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 21:37 [PATCH] bluetooth: Do not ignore errors returned from strict_strtol() David Miller
2011-05-20 2:33 ` Gustavo F. Padovan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.