From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: mark CONFIG_CIFS_NFSD_EXPORT as BROKEN
Date: Sun, 22 May 2011 07:59:38 -0400 [thread overview]
Message-ID: <20110522115938.GA27941@infradead.org> (raw)
In-Reply-To: <1306065324-24604-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Sun, May 22, 2011 at 07:55:24AM -0400, Jeff Layton wrote:
> This will never work properly with CIFS, as the protocol has no ability
> whatsoever for looking up files by filehandle. It *might* be possible to
> eventually do this with SMB2, but that remains to be seen.
>
> For now, it just plain doesn't work. Mark it BROKEN to discourage
> distros from enabling it.
It's actually dead code at this point - fs/nfsd/vfs.c:check_export()
refuses to export a filesystem that does not have a fh_to_dentry
operation, which cifs doesn't provide.
IMHO it's best to just remove the option and all surrounding code.
next prev parent reply other threads:[~2011-05-22 11:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 11:55 [PATCH] cifs: mark CONFIG_CIFS_NFSD_EXPORT as BROKEN Jeff Layton
[not found] ` <1306065324-24604-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-05-22 11:59 ` Christoph Hellwig [this message]
[not found] ` <20110522115938.GA27941-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-05-22 12:17 ` Jeff Layton
[not found] ` <20110522081707.72cce108-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-05-23 1:12 ` Steve French
[not found] ` <BANLkTim_K__5bqJG5snk+Bb+CW5dB70aQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 11:12 ` Jeff Layton
[not found] ` <20110523071208.5dc935f8-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-05-23 13:42 ` Steve French
[not found] ` <BANLkTikRqxGo3mm7h3w3-JL+Si6ZJYGPZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 13:50 ` Jeff Layton
[not found] ` <20110523095027.2746e7c0-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-05-23 14:02 ` Steve French
[not found] ` <BANLkTikBOdYnb5nqf=fM3Lh1EptBmkqwbQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 14:15 ` Jeff Layton
2011-05-23 13:54 ` Shirish Pargaonkar
2011-05-23 16:31 ` Gerald Carter
[not found] ` <4DDA8BE6.8000001-I3iY/6WR96Zg9hUCZPvPmw@public.gmane.org>
2011-05-23 16:58 ` Steve French
[not found] ` <BANLkTikpWQaYRbaTGs5WtZ8zWrL8jeeQZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 17:45 ` Jeff Layton
[not found] ` <20110523134542.7d16be6d-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-05-23 17:52 ` Steve French
[not found] ` <BANLkTinX=CA_zeqNPhZpZD9JY3BNk08K_w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 18:07 ` Jeff Layton
[not found] ` <20110523140722.45c4ffc6-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-05-23 18:21 ` Steve French
[not found] ` <BANLkTi=NXhZ1PJKRKA1wYgbcBnw05_X8dQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 18:23 ` Christoph Hellwig
[not found] ` <20110523182332.GA13791-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-05-23 18:24 ` Steve French
[not found] ` <BANLkTi=wCtL=eHksuLuBPX8swEJjrtiV5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-23 18:29 ` Steve French
2011-05-23 18:47 ` Jeff Layton
[not found] ` <20110523144705.56f17271-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-05-23 19:03 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110522115938.GA27941@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.