All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] cleanup regulator supply definitions in mach-omap2 to use REGULATOR_SUPPLY
Date: Mon, 23 May 2011 06:56:38 +0800	[thread overview]
Message-ID: <20110522225636.GC15882@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <13FCB0DC-28DB-4AC5-A08A-D8A71AA8D031@linuxhacker.ru>

On Sun, May 22, 2011 at 06:49:26PM -0400, Oleg Drokin wrote:

> If I end-up with a new version of the patch, what do you think would be best as a divisor
> between the patches? Just have ~half of changes split into another patch or do you have any other ideas?

Split the changes to not set .dev out from the changes to use
REGULATOR_SUPPLY().  It's much easier to read big block changes like
this when you get a big set of exactly the same change rather than a mix
of different changes.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cleanup regulator supply definitions in mach-omap2 to use REGULATOR_SUPPLY
Date: Mon, 23 May 2011 06:56:38 +0800	[thread overview]
Message-ID: <20110522225636.GC15882@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <13FCB0DC-28DB-4AC5-A08A-D8A71AA8D031@linuxhacker.ru>

On Sun, May 22, 2011 at 06:49:26PM -0400, Oleg Drokin wrote:

> If I end-up with a new version of the patch, what do you think would be best as a divisor
> between the patches? Just have ~half of changes split into another patch or do you have any other ideas?

Split the changes to not set .dev out from the changes to use
REGULATOR_SUPPLY().  It's much easier to read big block changes like
this when you get a big set of exactly the same change rather than a mix
of different changes.

  reply	other threads:[~2011-05-22 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 21:58 [PATCH] cleanup regulator supply definitions in mach-omap2 to use REGULATOR_SUPPLY green
2011-05-22 21:58 ` green at linuxhacker.ru
2011-05-22 22:45 ` Mark Brown
2011-05-22 22:45   ` Mark Brown
2011-05-22 22:49   ` Oleg Drokin
2011-05-22 22:49     ` Oleg Drokin
2011-05-22 22:56     ` Mark Brown [this message]
2011-05-22 22:56       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110522225636.GC15882@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.