* [PATCH] PM: OPP: introduce function to free cpufreq table
@ 2011-05-23 23:12 Nishanth Menon
2011-05-24 0:05 ` Todd Poynor
2011-05-24 0:05 ` Todd Poynor
0 siblings, 2 replies; 8+ messages in thread
From: Nishanth Menon @ 2011-05-23 23:12 UTC (permalink / raw)
To: linux-pm; +Cc: linux-omap, Rafael J. Wysocki, Nishanth Menon
cpufreq table allocated by opp_init_cpufreq_table is better
freed by OPP layer itself. This allows future modifications to
the table handling to be transparent to the users.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Example discussion: http://marc.info/?t=130570440600005&r=1&w=2
Documentation/power/opp.txt | 2 ++
drivers/base/power/opp.c | 20 ++++++++++++++++++++
include/linux/opp.h | 8 ++++++++
3 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt
index 5ae70a1..3035d00 100644
--- a/Documentation/power/opp.txt
+++ b/Documentation/power/opp.txt
@@ -321,6 +321,8 @@ opp_init_cpufreq_table - cpufreq framework typically is initialized with
addition to CONFIG_PM as power management feature is required to
dynamically scale voltage and frequency in a system.
+opp_free_cpufreq_table - Free up the table allocated by opp_init_cpufreq_table
+
7. Data Structures
==================
Typically an SoC contains multiple voltage domains which are variable. Each
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 56a6899..bf0c2ee 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -625,4 +625,24 @@ int opp_init_cpufreq_table(struct device *dev,
return 0;
}
+
+/**
+ * opp_free_cpufreq_table() - free the cpufreq table
+ * @dev: device for which we do this operation
+ * @table: table to free
+ *
+ * Free up the table allocated by opp_init_cpufreq_table
+ */
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table)
+{
+ if (!table)
+ return;
+
+ /* Pretend as if I am an updater */
+ mutex_lock(&dev_opp_list_lock);
+ kfree(*table);
+ *table = NULL;
+ mutex_unlock(&dev_opp_list_lock);
+}
#endif /* CONFIG_CPU_FREQ */
diff --git a/include/linux/opp.h b/include/linux/opp.h
index 5449945..7020e97 100644
--- a/include/linux/opp.h
+++ b/include/linux/opp.h
@@ -94,12 +94,20 @@ static inline int opp_disable(struct device *dev, unsigned long freq)
#if defined(CONFIG_CPU_FREQ) && defined(CONFIG_PM_OPP)
int opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table **table);
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table);
#else
static inline int opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table **table)
{
return -EINVAL;
}
+
+static inline
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table)
+{
+}
#endif /* CONFIG_CPU_FREQ */
#endif /* __LINUX_OPP_H__ */
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-23 23:12 [PATCH] PM: OPP: introduce function to free cpufreq table Nishanth Menon
@ 2011-05-24 0:05 ` Todd Poynor
2011-05-24 0:05 ` Todd Poynor
1 sibling, 0 replies; 8+ messages in thread
From: Todd Poynor @ 2011-05-24 0:05 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-pm, linux-omap
On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
> cpufreq table allocated by opp_init_cpufreq_table is better
> freed by OPP layer itself. This allows future modifications to
> the table handling to be transparent to the users.
...
> +void opp_free_cpufreq_table(struct device *dev,
> + struct cpufreq_frequency_table **table)
> +{
> + if (!table)
> + return;
> +
> + /* Pretend as if I am an updater */
> + mutex_lock(&dev_opp_list_lock);
> + kfree(*table);
> + *table = NULL;
> + mutex_unlock(&dev_opp_list_lock);
> +}
Not clear what the mutex protects here. Currently it protects only
device opp list modifications. opp_init_cpufreq_table holds the lock only
while looking up and walking the device opp list; the cpufreq table it
creates is not complete by the time the lock is dropped.
Todd
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-23 23:12 [PATCH] PM: OPP: introduce function to free cpufreq table Nishanth Menon
2011-05-24 0:05 ` Todd Poynor
@ 2011-05-24 0:05 ` Todd Poynor
2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 2:42 ` Menon, Nishanth
1 sibling, 2 replies; 8+ messages in thread
From: Todd Poynor @ 2011-05-24 0:05 UTC (permalink / raw)
To: Nishanth Menon; +Cc: linux-pm, linux-omap, Rafael J. Wysocki
On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
> cpufreq table allocated by opp_init_cpufreq_table is better
> freed by OPP layer itself. This allows future modifications to
> the table handling to be transparent to the users.
...
> +void opp_free_cpufreq_table(struct device *dev,
> + struct cpufreq_frequency_table **table)
> +{
> + if (!table)
> + return;
> +
> + /* Pretend as if I am an updater */
> + mutex_lock(&dev_opp_list_lock);
> + kfree(*table);
> + *table = NULL;
> + mutex_unlock(&dev_opp_list_lock);
> +}
Not clear what the mutex protects here. Currently it protects only
device opp list modifications. opp_init_cpufreq_table holds the lock only
while looking up and walking the device opp list; the cpufreq table it
creates is not complete by the time the lock is dropped.
Todd
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-24 0:05 ` Todd Poynor
@ 2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 2:42 ` Menon, Nishanth
1 sibling, 0 replies; 8+ messages in thread
From: Menon, Nishanth @ 2011-05-24 2:42 UTC (permalink / raw)
To: Todd Poynor; +Cc: linux-pm, linux-omap
On Mon, May 23, 2011 at 19:05, Todd Poynor <toddpoynor@google.com> wrote:
> On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
>> cpufreq table allocated by opp_init_cpufreq_table is better
>> freed by OPP layer itself. This allows future modifications to
>> the table handling to be transparent to the users.
> ...
>> +void opp_free_cpufreq_table(struct device *dev,
>> + struct cpufreq_frequency_table **table)
>> +{
>> + if (!table)
>> + return;
>> +
>> + /* Pretend as if I am an updater */
>> + mutex_lock(&dev_opp_list_lock);
>> + kfree(*table);
>> + *table = NULL;
>> + mutex_unlock(&dev_opp_list_lock);
>> +}
>
> Not clear what the mutex protects here. Currently it protects only
> device opp list modifications. opp_init_cpufreq_table holds the lock only
> while looking up and walking the device opp list; the cpufreq table it
> creates is not complete by the time the lock is dropped.
hmm.. right.. mutex protection does'nt really make sense here..
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-24 0:05 ` Todd Poynor
2011-05-24 2:42 ` Menon, Nishanth
@ 2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 18:49 ` Rafael J. Wysocki
2011-05-24 18:49 ` Rafael J. Wysocki
1 sibling, 2 replies; 8+ messages in thread
From: Menon, Nishanth @ 2011-05-24 2:42 UTC (permalink / raw)
To: Todd Poynor; +Cc: linux-pm, linux-omap, Rafael J. Wysocki
On Mon, May 23, 2011 at 19:05, Todd Poynor <toddpoynor@google.com> wrote:
> On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
>> cpufreq table allocated by opp_init_cpufreq_table is better
>> freed by OPP layer itself. This allows future modifications to
>> the table handling to be transparent to the users.
> ...
>> +void opp_free_cpufreq_table(struct device *dev,
>> + struct cpufreq_frequency_table **table)
>> +{
>> + if (!table)
>> + return;
>> +
>> + /* Pretend as if I am an updater */
>> + mutex_lock(&dev_opp_list_lock);
>> + kfree(*table);
>> + *table = NULL;
>> + mutex_unlock(&dev_opp_list_lock);
>> +}
>
> Not clear what the mutex protects here. Currently it protects only
> device opp list modifications. opp_init_cpufreq_table holds the lock only
> while looking up and walking the device opp list; the cpufreq table it
> creates is not complete by the time the lock is dropped.
hmm.. right.. mutex protection does'nt really make sense here..
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-24 2:42 ` Menon, Nishanth
@ 2011-05-24 18:49 ` Rafael J. Wysocki
2011-05-24 18:49 ` Rafael J. Wysocki
1 sibling, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2011-05-24 18:49 UTC (permalink / raw)
To: Menon, Nishanth; +Cc: linux-pm, linux-omap
On Tuesday, May 24, 2011, Menon, Nishanth wrote:
> On Mon, May 23, 2011 at 19:05, Todd Poynor <toddpoynor@google.com> wrote:
> > On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
> >> cpufreq table allocated by opp_init_cpufreq_table is better
> >> freed by OPP layer itself. This allows future modifications to
> >> the table handling to be transparent to the users.
> > ...
> >> +void opp_free_cpufreq_table(struct device *dev,
> >> + struct cpufreq_frequency_table **table)
> >> +{
> >> + if (!table)
> >> + return;
> >> +
> >> + /* Pretend as if I am an updater */
> >> + mutex_lock(&dev_opp_list_lock);
> >> + kfree(*table);
> >> + *table = NULL;
> >> + mutex_unlock(&dev_opp_list_lock);
> >> +}
> >
> > Not clear what the mutex protects here. Currently it protects only
> > device opp list modifications. opp_init_cpufreq_table holds the lock only
> > while looking up and walking the device opp list; the cpufreq table it
> > creates is not complete by the time the lock is dropped.
>
> hmm.. right.. mutex protection does'nt really make sense here..
Care to post an updated patch?
Rafael
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] PM: OPP: introduce function to free cpufreq table
2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 18:49 ` Rafael J. Wysocki
@ 2011-05-24 18:49 ` Rafael J. Wysocki
1 sibling, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2011-05-24 18:49 UTC (permalink / raw)
To: Menon, Nishanth; +Cc: Todd Poynor, linux-pm, linux-omap
On Tuesday, May 24, 2011, Menon, Nishanth wrote:
> On Mon, May 23, 2011 at 19:05, Todd Poynor <toddpoynor@google.com> wrote:
> > On Mon, May 23, 2011 at 06:12:15PM -0500, Nishanth Menon wrote:
> >> cpufreq table allocated by opp_init_cpufreq_table is better
> >> freed by OPP layer itself. This allows future modifications to
> >> the table handling to be transparent to the users.
> > ...
> >> +void opp_free_cpufreq_table(struct device *dev,
> >> + struct cpufreq_frequency_table **table)
> >> +{
> >> + if (!table)
> >> + return;
> >> +
> >> + /* Pretend as if I am an updater */
> >> + mutex_lock(&dev_opp_list_lock);
> >> + kfree(*table);
> >> + *table = NULL;
> >> + mutex_unlock(&dev_opp_list_lock);
> >> +}
> >
> > Not clear what the mutex protects here. Currently it protects only
> > device opp list modifications. opp_init_cpufreq_table holds the lock only
> > while looking up and walking the device opp list; the cpufreq table it
> > creates is not complete by the time the lock is dropped.
>
> hmm.. right.. mutex protection does'nt really make sense here..
Care to post an updated patch?
Rafael
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] PM: OPP: introduce function to free cpufreq table
@ 2011-05-23 23:12 Nishanth Menon
0 siblings, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2011-05-23 23:12 UTC (permalink / raw)
To: linux-pm; +Cc: linux-omap
cpufreq table allocated by opp_init_cpufreq_table is better
freed by OPP layer itself. This allows future modifications to
the table handling to be transparent to the users.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Example discussion: http://marc.info/?t=130570440600005&r=1&w=2
Documentation/power/opp.txt | 2 ++
drivers/base/power/opp.c | 20 ++++++++++++++++++++
include/linux/opp.h | 8 ++++++++
3 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/Documentation/power/opp.txt b/Documentation/power/opp.txt
index 5ae70a1..3035d00 100644
--- a/Documentation/power/opp.txt
+++ b/Documentation/power/opp.txt
@@ -321,6 +321,8 @@ opp_init_cpufreq_table - cpufreq framework typically is initialized with
addition to CONFIG_PM as power management feature is required to
dynamically scale voltage and frequency in a system.
+opp_free_cpufreq_table - Free up the table allocated by opp_init_cpufreq_table
+
7. Data Structures
==================
Typically an SoC contains multiple voltage domains which are variable. Each
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 56a6899..bf0c2ee 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -625,4 +625,24 @@ int opp_init_cpufreq_table(struct device *dev,
return 0;
}
+
+/**
+ * opp_free_cpufreq_table() - free the cpufreq table
+ * @dev: device for which we do this operation
+ * @table: table to free
+ *
+ * Free up the table allocated by opp_init_cpufreq_table
+ */
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table)
+{
+ if (!table)
+ return;
+
+ /* Pretend as if I am an updater */
+ mutex_lock(&dev_opp_list_lock);
+ kfree(*table);
+ *table = NULL;
+ mutex_unlock(&dev_opp_list_lock);
+}
#endif /* CONFIG_CPU_FREQ */
diff --git a/include/linux/opp.h b/include/linux/opp.h
index 5449945..7020e97 100644
--- a/include/linux/opp.h
+++ b/include/linux/opp.h
@@ -94,12 +94,20 @@ static inline int opp_disable(struct device *dev, unsigned long freq)
#if defined(CONFIG_CPU_FREQ) && defined(CONFIG_PM_OPP)
int opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table **table);
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table);
#else
static inline int opp_init_cpufreq_table(struct device *dev,
struct cpufreq_frequency_table **table)
{
return -EINVAL;
}
+
+static inline
+void opp_free_cpufreq_table(struct device *dev,
+ struct cpufreq_frequency_table **table)
+{
+}
#endif /* CONFIG_CPU_FREQ */
#endif /* __LINUX_OPP_H__ */
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-05-24 18:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-23 23:12 [PATCH] PM: OPP: introduce function to free cpufreq table Nishanth Menon
2011-05-24 0:05 ` Todd Poynor
2011-05-24 0:05 ` Todd Poynor
2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 2:42 ` Menon, Nishanth
2011-05-24 18:49 ` Rafael J. Wysocki
2011-05-24 18:49 ` Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2011-05-23 23:12 Nishanth Menon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.