From: Paul Mundt <lethal@linux-sh.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 1/3] fbdev/amifb: Correct check for video memory size
Date: Tue, 24 May 2011 07:27:29 +0000 [thread overview]
Message-ID: <20110524072729.GG11986@linux-sh.org> (raw)
In-Reply-To: <1306006976-32117-3-git-send-email-geert@linux-m68k.org> <1306006976-32117-2-git-send-email-geert@linux-m68k.org> <1306006976-32117-1-git-send-email-geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:54PM +0200, Geert Uytterhoeven wrote:
> The check should compare the available memory size with the highest allocation
> value (VIDEOMEMSIZE_*_2M), not with the lowest value (VIDEOMEMSIZE_*_1M).
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:55PM +0200, Geert Uytterhoeven wrote:
> Fail gracefully instead.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:56PM +0200, Geert Uytterhoeven wrote:
> amiga_chip_alloc() already aligns to the PAGE_SIZE
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
All applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 1/3] fbdev/amifb: Correct check for video memory size
Date: Tue, 24 May 2011 16:27:29 +0900 [thread overview]
Message-ID: <20110524072729.GG11986@linux-sh.org> (raw)
In-Reply-To: <1306006976-32117-3-git-send-email-geert@linux-m68k.org> <1306006976-32117-2-git-send-email-geert@linux-m68k.org> <1306006976-32117-1-git-send-email-geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:54PM +0200, Geert Uytterhoeven wrote:
> The check should compare the available memory size with the highest allocation
> value (VIDEOMEMSIZE_*_2M), not with the lowest value (VIDEOMEMSIZE_*_1M).
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:55PM +0200, Geert Uytterhoeven wrote:
> Fail gracefully instead.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
On Sat, May 21, 2011 at 09:42:56PM +0200, Geert Uytterhoeven wrote:
> amiga_chip_alloc() already aligns to the PAGE_SIZE
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
All applied, thanks.
next prev parent reply other threads:[~2011-05-24 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 19:42 [PATCH 1/3] fbdev/amifb: Correct check for video memory size Geert Uytterhoeven
2011-05-21 19:42 ` Geert Uytterhoeven
2011-05-21 19:42 ` [PATCH 2/3] fbdev/amifb: Do not call panic() if there's not enough Chip RAM Geert Uytterhoeven
2011-05-21 19:42 ` Geert Uytterhoeven
2011-05-21 19:42 ` [PATCH 3/3] fbdev/amifb: Remove superfluous alignment of frame buffer memory Geert Uytterhoeven
2011-05-21 19:42 ` Geert Uytterhoeven
2011-05-24 7:27 ` Paul Mundt [this message]
2011-05-24 7:27 ` [PATCH 1/3] fbdev/amifb: Correct check for video memory size Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524072729.GG11986@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.