vfs: where is get_sb_single()?

vfs: where is get_sb_single()?

[Bob Liu]

Hi, folks

I found that fs/super.c doesn't have get_sb_single() anymore.

But I can't find the git log which delete that function.
Some out of tree file systems depends on that function.

Thanks
-- 
Regards,
--Bob

Re: vfs: where is get_sb_single()?

[Jesper Juhl]

On Wed, 25 May 2011, Bob Liu wrote:

> Hi, folks
> 
> I found that fs/super.c doesn't have get_sb_single() anymore.
> 
> But I can't find the git log which delete that function.
> Some out of tree file systems depends on that function.
> 

commit 1a102ff92579edeff5e3d5d3c76ca49977898f00 by Al Viro removed that.

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: vfs: where is get_sb_single()?

[Al Viro]

On Wed, May 25, 2011 at 03:19:58PM +0800, Bob Liu wrote:
> Hi, folks
> 
> I found that fs/super.c doesn't have get_sb_single() anymore.
> 
> But I can't find the git log which delete that function.
> Some out of tree file systems depends on that function.

The same out of tree filesystems depend on ->get_sb() being there...
See Documentation/filesystems/porting:

[mandatory]
        ->get_sb() is gone.  Switch to use of ->mount().  Typically it's just
a matter of switching from calling get_sb_... to mount_... and changing the
function type.  If you were doing it manually, just switch from setting ->mnt_root
to some pointer to returning that pointer.  On errors return ERR_PTR(...).

IOW, odds are good that you'll need to do something like what had been
done in commit 152a08366671080f27b32e0c411ad620c5f88b57 - not terribly
complicated.

Re: vfs: where is get_sb_single()?

[Bob Liu]

On Wed, May 25, 2011 at 5:33 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, May 25, 2011 at 03:19:58PM +0800, Bob Liu wrote:
>> Hi, folks
>>
>> I found that fs/super.c doesn't have get_sb_single() anymore.
>>
>> But I can't find the git log which delete that function.
>> Some out of tree file systems depends on that function.
>
> The same out of tree filesystems depend on ->get_sb() being there...
> See Documentation/filesystems/porting:
>
> [mandatory]
>        ->get_sb() is gone.  Switch to use of ->mount().  Typically it's just
> a matter of switching from calling get_sb_... to mount_... and changing the
> function type.  If you were doing it manually, just switch from setting ->mnt_root
> to some pointer to returning that pointer.  On errors return ERR_PTR(...).
>
> IOW, odds are good that you'll need to do something like what had been
> done in commit 152a08366671080f27b32e0c411ad620c5f88b57 - not terribly
> complicated.
>

Got it, Thanks a lot for your help.

I made a mistake during browser linux-next.git in kernel.org.

-- 
Regards,
--Bob