All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: cbe-oss-dev@lists.ozlabs.org,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Arnd Bergmann <arnd@arndb.de>,
	Sonny Rao <sonnyrao@linux.vnet.ibm.com>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Milton Miller <miltonm@bga.com>,
	Paul Mackerras <paulus@samba.org>,
	Anton Blanchard <anton@samba.org>,
	Will Schmidt <will_schmidt@vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 5/8] powerpc: override dma_get_required_mask by platform hook and ops
Date: Wed, 25 May 2011 11:47:38 -0700	[thread overview]
Message-ID: <20110525184738.GA10283@us.ibm.com> (raw)
In-Reply-To: <20110519174625.GA3338@us.ibm.com>

Ben,

On 19.05.2011 [10:46:25 -0700], Nishanth Aravamudan wrote:
> On 19.05.2011 [17:43:56 +1000], Benjamin Herrenschmidt wrote:
> > On Wed, 2011-05-11 at 15:25 -0700, Nishanth Aravamudan wrote:
> > > From: Milton Miller <miltonm@bga.com>
> > > 
> > > The hook dma_get_required_mask is supposed to return the mask required
> > > by the platform to operate efficently.  The generic version of
> > > dma_get_required_mask in driver/base/platform.c returns a mask based
> > > only on max_pfn.  However, this is likely too big for iommu systems
> > > and could be too small for platforms that require a dma offset or have
> > > a secondary window at a high offset.
> > 
> > The result of those 3 patches doesn't build on top of my current tree,
> > the generic dma_ops lacks the dma_get_required_mask hook. I'll have a
> > look again after the merge window.
> 
> Hrm, I think it's because for whatever reason [1] I forgot to cc you on 6/8?
> 
> https://lkml.org/lkml/2011/5/11/473

Were you able to find the patch I refer to above?

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Milton Miller <miltonm@bga.com>,
	Paul Mackerras <paulus@samba.org>, Arnd Bergmann <arnd@arndb.de>,
	Grant Likely <grant.likely@secretlab.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Anton Blanchard <anton@samba.org>,
	Sonny Rao <sonnyrao@linux.vnet.ibm.com>,
	Will Schmidt <will_schmidt@vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	cbe-oss-dev@lists.ozlabs.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 5/8] powerpc: override dma_get_required_mask by platform hook and ops
Date: Wed, 25 May 2011 11:47:38 -0700	[thread overview]
Message-ID: <20110525184738.GA10283@us.ibm.com> (raw)
In-Reply-To: <20110519174625.GA3338@us.ibm.com>

Ben,

On 19.05.2011 [10:46:25 -0700], Nishanth Aravamudan wrote:
> On 19.05.2011 [17:43:56 +1000], Benjamin Herrenschmidt wrote:
> > On Wed, 2011-05-11 at 15:25 -0700, Nishanth Aravamudan wrote:
> > > From: Milton Miller <miltonm@bga.com>
> > > 
> > > The hook dma_get_required_mask is supposed to return the mask required
> > > by the platform to operate efficently.  The generic version of
> > > dma_get_required_mask in driver/base/platform.c returns a mask based
> > > only on max_pfn.  However, this is likely too big for iommu systems
> > > and could be too small for platforms that require a dma offset or have
> > > a secondary window at a high offset.
> > 
> > The result of those 3 patches doesn't build on top of my current tree,
> > the generic dma_ops lacks the dma_get_required_mask hook. I'll have a
> > look again after the merge window.
> 
> Hrm, I think it's because for whatever reason [1] I forgot to cc you on 6/8?
> 
> https://lkml.org/lkml/2011/5/11/473

Were you able to find the patch I refer to above?

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

  reply	other threads:[~2011-05-25 18:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 22:24 [PATCH 0/8] pseries/iommu: bug-fixes and cleanups for dynamic dma windows Nishanth Aravamudan
2011-05-11 22:24 ` [PATCH 1/8] pseries/iommu: add additional checks when changing iommu mask Nishanth Aravamudan
2011-05-11 22:24   ` Nishanth Aravamudan
2011-05-11 22:24 ` [PATCH 2/8] pseries/iommu: remove ddw property when destroying window Nishanth Aravamudan
2011-05-11 22:24   ` Nishanth Aravamudan
2011-05-11 22:24 ` [PATCH 3/8] pseries/iommu: find windows after kexec during boot Nishanth Aravamudan
2011-05-11 22:24   ` Nishanth Aravamudan
2011-05-11 22:25 ` [PATCH 4/8] pseries/iommu: cleanup ddw naming Nishanth Aravamudan
2011-05-11 22:25   ` Nishanth Aravamudan
2011-05-11 22:25 ` [PATCH 5/8] powerpc: override dma_get_required_mask by platform hook and ops Nishanth Aravamudan
2011-05-11 22:25   ` Nishanth Aravamudan
2011-05-19  7:43   ` Benjamin Herrenschmidt
2011-05-19  7:43     ` Benjamin Herrenschmidt
2011-05-19  7:43     ` Benjamin Herrenschmidt
2011-05-19 17:46     ` Nishanth Aravamudan
2011-05-19 17:46       ` Nishanth Aravamudan
2011-05-25 18:47       ` Nishanth Aravamudan [this message]
2011-05-25 18:47         ` Nishanth Aravamudan
2011-05-11 22:25 ` [PATCH 6/8] dma-mapping: add get_required_mask if arch overrides default Nishanth Aravamudan
2011-05-11 22:25 ` [PATCH 7/8] powerpc: use the newly added get_required_mask dma_map_ops hook Nishanth Aravamudan
2011-05-11 22:25   ` Nishanth Aravamudan
2011-05-12  5:51   ` Geert Uytterhoeven
2011-05-12  5:51     ` Geert Uytterhoeven
2011-05-12  7:32     ` Milton Miller
2011-05-12  7:32       ` Milton Miller
2011-05-11 22:25 ` [PATCH 8/8] powerpc: tidy up dma_map_ops after adding new hook Nishanth Aravamudan
2011-05-11 22:25   ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110525184738.GA10283@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton@samba.org \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=cbe-oss-dev@lists.ozlabs.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=miltonm@bga.com \
    --cc=paulus@samba.org \
    --cc=sonnyrao@linux.vnet.ibm.com \
    --cc=will_schmidt@vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.