From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>, Avi Kivity <avi@redhat.com>,
kvm <kvm@vger.kernel.org>, Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: KVM: x86: use proper port value when checking io instruction permission (v2)
Date: Thu, 26 May 2011 07:43:04 -0300 [thread overview]
Message-ID: <20110526104304.GA28699@amt.cnet> (raw)
In-Reply-To: <4DDE0601.8060008@redhat.com>
On Thu, May 26, 2011 at 09:49:21AM +0200, Paolo Bonzini wrote:
> On 05/26/2011 09:07 AM, Gleb Natapov wrote:
> >> Still, op_bytes is irrelevant for
> >> SrcDX, the 16-bit version is always used.
> >
> >If SrcDX/DstDX will be used only for decoding in/out instruction
> >then yes. Otherwise it is nice to have more general decoder.
Yes, the use of op_bytes instead of 2 had that in mind.
> Not counting instructions that read/write many registers
> (rdmsr/wrmsr, mul/imul/div/idiv, rdtsc, etc.), I think the only
> other instruction with an implicit DstDX is cwd/cdq/cqo. Since
> cwd/cdq/cqo needs c->dst.bytes = c->src.bytes (not op_bytes) I think
> DstDX is not really reusable beyond port instructions.
>
> Paolo
OK, will switch to 2 then, thanks.
next prev parent reply other threads:[~2011-05-26 10:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 17:11 KVM: x86: use proper port value when checking io instruction permission Marcelo Tosatti
2011-05-24 17:27 ` Gleb Natapov
2011-05-24 19:07 ` Avi Kivity
2011-05-24 19:18 ` Gleb Natapov
2011-05-24 19:25 ` Avi Kivity
2011-05-25 18:18 ` KVM: x86: use proper port value when checking io instruction permission (v2) Marcelo Tosatti
2011-05-26 6:31 ` Avi Kivity
2011-05-26 6:55 ` Gleb Natapov
2011-05-26 7:02 ` Avi Kivity
2011-05-26 7:04 ` Avi Kivity
2011-05-26 7:07 ` Gleb Natapov
2011-05-26 7:49 ` Paolo Bonzini
2011-05-26 8:26 ` Gleb Natapov
2011-05-26 9:00 ` Paolo Bonzini
2011-05-26 9:02 ` Gleb Natapov
2011-05-26 9:23 ` Paolo Bonzini
2011-05-26 9:29 ` Gleb Natapov
2011-05-26 10:43 ` Marcelo Tosatti [this message]
2011-05-26 11:56 ` KVM: x86: use proper port value when checking io instruction permission (v3) Marcelo Tosatti
2011-05-29 8:34 ` Avi Kivity
2011-05-30 18:23 ` KVM: x86: use proper port value when checking io instruction permission (v4) Marcelo Tosatti
2011-05-30 18:28 ` Avi Kivity
2011-05-30 18:23 ` KVM: x86: use proper port value when checking io instruction permission (v3) Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526104304.GA28699@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.