From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Angus Ainslie <angus.ainslie@linaro.org>,
linux-samsung-soc@vger.kernel.org,
Giridhar Maruthy <giridhar.maruthy@linaro.org>,
samsung@lists.linaro.org, patches@linaro.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
Date: Thu, 26 May 2011 22:24:03 +0800 [thread overview]
Message-ID: <20110526142333.GI15094@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTik5pqAgJGznPi2PLSyXucgOoLNR9w@mail.gmail.com>
On Wed, May 25, 2011 at 11:45:37PM +0530, Jassi Brar wrote:
> I2C here is a SMDK specific requirement and even if most devices need I2C,
> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
> be tied to some SMDK specific config option.
Given that it's the audio machine driver the dependency on I2C doesn't
seem unreasonable - the CODEC will generally be I2C connected so I2C is
going to be required for the driver to do anything useful. Might be
better to just add a dependency on the WM8994 MFD, though, which does
roughly the same thing.
next prev parent reply other threads:[~2011-05-26 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 4:39 [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection Angus Ainslie
2011-05-25 17:54 ` Kukjin Kim
2011-05-25 18:15 ` Jassi Brar
2011-05-25 18:48 ` Kukjin Kim
2011-05-26 14:24 ` Mark Brown [this message]
2011-05-26 15:02 ` Jassi Brar
-- strict thread matches above, loose matches on Subject: below --
2011-05-31 5:40 Giridhar Maruthy
2011-05-31 10:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526142333.GI15094@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=angus.ainslie@linaro.org \
--cc=giridhar.maruthy@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@linaro.org \
--cc=samsung@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.