From: Kukjin Kim <kgene.kim@samsung.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Angus Ainslie <angus.ainslie@linaro.org>,
linux-samsung-soc@vger.kernel.org,
Giridhar Maruthy <giridhar.maruthy@linaro.org>,
samsung@lists.linaro.org, patches@linaro.org,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection
Date: Wed, 25 May 2011 11:48:19 -0700 [thread overview]
Message-ID: <4DDD4EF3.3000008@samsung.com> (raw)
In-Reply-To: <BANLkTik5pqAgJGznPi2PLSyXucgOoLNR9w@mail.gmail.com>
On 05/25/11 11:15, Jassi Brar wrote:
>>> diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig
>>> index a3fdfb6..a80eeb1 100644
>>> --- a/sound/soc/samsung/Kconfig
>>> +++ b/sound/soc/samsung/Kconfig
>>> @@ -65,6 +65,9 @@ config SND_SOC_SAMSUNG_SMDK_WM8994
>>> tristate "SoC I2S Audio support for WM8994 on SMDK"
>>> depends on SND_SOC_SAMSUNG&& (MACH_SMDKV310 || MACH_SMDKC210)
>>> select SND_SOC_WM8994
>>> + select MFD_SUPPORT
>>> + select I2C_S3C2410
>>> + select MFD_WM8994
>>
>> I'm not sure about MFD configs, but if "select I2C_S3C2410" is required, it
>> should be moved into regarding Kconfig of arch/arm, because it is related to
>> dependency of ARCH. Maybe in this case, arch/arm/mach-exynos4/Kconfig?
>
> I2C here is a SMDK specific requirement and even if most devices need I2C,
> selecting I2C for every EXYNOS4210 based device is not ideal. IMO it'd better
> be tied to some SMDK specific config option.
>
Hi Jassi :)
How are you?
Hmm...need to think again because as you know, basically all of boards
can be compiled with one exynos4_defconfig.
Ok, so you agreed it should be moved into some Kconfig of arch/arm/ :)
I will think again which one is more reasonable then let you know.
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2011-05-25 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 4:39 [PATCH] ARM: EXYNOS4: Enable WM8994 MFD on I2S selection Angus Ainslie
2011-05-25 17:54 ` Kukjin Kim
2011-05-25 18:15 ` Jassi Brar
2011-05-25 18:48 ` Kukjin Kim [this message]
2011-05-26 14:24 ` Mark Brown
2011-05-26 15:02 ` Jassi Brar
-- strict thread matches above, loose matches on Subject: below --
2011-05-31 5:40 Giridhar Maruthy
2011-05-31 10:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD4EF3.3000008@samsung.com \
--to=kgene.kim@samsung.com \
--cc=angus.ainslie@linaro.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=giridhar.maruthy@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@linaro.org \
--cc=samsung@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.