All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: move the ttl field to the third position of unicast_* packets
Date: Sat, 28 May 2011 09:26:30 +0200	[thread overview]
Message-ID: <201105280926.32059.sven@narfation.org> (raw)
In-Reply-To: <201105280035.24310.lindner_marek@yahoo.de>

[-- Attachment #1: Type: Text/Plain, Size: 1742 bytes --]

Marek Lindner wrote:
> On Saturday 28 May 2011 00:20:21 Sven Eckelmann wrote:
> > >  struct unicast_frag_packet {
> > >  
> > >       uint8_t  packet_type;
> > >       uint8_t  version;  /* batman version field */
> > > 
> > > -     uint8_t  dest[6];
> > > 
> > >       uint8_t  ttl;
> > > 
> > > +     uint8_t  align;
> > > +     uint8_t  dest[6];
> > > 
> > >       uint8_t  flags;
> > > 
> > > +     uint8_t  align;
> > > 
> > >       uint8_t  orig[6];
> > >       uint16_t seqno;
> > >  
> > >  } __packed;
> > 
> > Wait a second - are there two "align" in a single struct. Sry, have to
> > Nack  that one :)
> 
> Yes, I suggested that because the tt patches will replace the first align
> with the ttvn field.

But it doesn't compile. I cannot forward stuff which is too broken. And 
personally I don't care who suggested it when my builtin c-parser explodes.

Ok, now I did the "work" to apply and and to compile that stuff to prove my 
point. Here are the slightly shortened results (gcc-4.6 from sid):

  CC [M]  aggregation.o
In file included from types.h:27:0,
                 from main.h:121,
                 from aggregation.c:22:
packet.h:114:11: error: duplicate member ‘align’
make[2]: *** [aggregation.o] Error 1
make[1]: *** [_module_/batman-adv] Error 2
make[1]: Leaving directory `linux-2.6.39'
make: *** [all] Error 2

My suggestion: Rename the first align in every packet structure to 'reserved'.

Then to the next part which I don't like: the patch forgot to touch 
batman_packet, icmp_packet, icmp_packet_rr, bcast_packet and vis_packet. It 
doesn't make sense to patch half of the on-wire types to reduce the number of 
COMPAT_VERSIONs.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-05-28  7:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 22:10 [B.A.T.M.A.N.] [PATCH] batman-adv: move the ttl field to the third position of unicast_* packets Antonio Quartulli
2011-05-27 22:20 ` Sven Eckelmann
2011-05-27 22:35   ` Marek Lindner
2011-05-28  7:26     ` Sven Eckelmann [this message]
2011-05-28  8:43       ` [B.A.T.M.A.N.] [PATCH-sven] batman-adv: Unify the first 4 bytes in each packet Sven Eckelmann
2011-05-28 11:45         ` [B.A.T.M.A.N.] [PATCH-marek] batman-adv: Unify the first 3 " Marek Lindner
2011-05-28 12:07           ` Sven Eckelmann
2011-05-28 12:17             ` Marek Lindner
2011-05-28 12:43               ` Sven Eckelmann
2011-05-28 12:51                 ` [B.A.T.M.A.N.] [PATCHv3-sven] " Sven Eckelmann
2011-05-28 15:08                   ` Marek Lindner
2011-05-28 11:46         ` [B.A.T.M.A.N.] [PATCH-sven] batman-adv: Unify the first 4 " Sven Eckelmann
2011-05-28 11:46         ` [B.A.T.M.A.N.] [PATCHv2-sven] batman-adv: Unify the first 3 " Sven Eckelmann
2011-05-28 11:20       ` [B.A.T.M.A.N.] [PATCH] batman-adv: move the ttl field to the third position of unicast_* packets Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105280926.32059.sven@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=lindner_marek@yahoo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.