From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-marek] batman-adv: Unify the first 3 bytes in each packet
Date: Sat, 28 May 2011 14:17:14 +0200 [thread overview]
Message-ID: <201105281417.16069.lindner_marek@yahoo.de> (raw)
In-Reply-To: <201105281407.15153.sven@narfation.org>
On Saturday 28 May 2011 14:07:10 Sven Eckelmann wrote:
> Why dont you use the reserverd part for the flags which are currently not
> in unicast? Then you could also remove that other align byte. It would
> still be possible to add flags to unicast packets when necessary.
The unicast_frag header assumes it looks like the unicast header plus some
extra fields:
struct unicast_frag_packet {
struct unicast_packet unicast_packet;
uint8_t flags;
uint8_t align;
uint8_t orig[6];
uint16_t seqno;
};
We probably should add a little comment there to make that clear.
Both reserved fields (unicast + unicast frag) are going to be converted to
ttvn with the tt patches.
> > + uint8_t reserved;
> > + uint8_t orig[6];
> >
> > uint32_t seqno;
> >
> > } __packed;
>
> Wouldn't that lead to an unaligned seqno?
Yes, I overlooked that the seqno is 32bit wide.
Regards,
Marek
next prev parent reply other threads:[~2011-05-28 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 22:10 [B.A.T.M.A.N.] [PATCH] batman-adv: move the ttl field to the third position of unicast_* packets Antonio Quartulli
2011-05-27 22:20 ` Sven Eckelmann
2011-05-27 22:35 ` Marek Lindner
2011-05-28 7:26 ` Sven Eckelmann
2011-05-28 8:43 ` [B.A.T.M.A.N.] [PATCH-sven] batman-adv: Unify the first 4 bytes in each packet Sven Eckelmann
2011-05-28 11:45 ` [B.A.T.M.A.N.] [PATCH-marek] batman-adv: Unify the first 3 " Marek Lindner
2011-05-28 12:07 ` Sven Eckelmann
2011-05-28 12:17 ` Marek Lindner [this message]
2011-05-28 12:43 ` Sven Eckelmann
2011-05-28 12:51 ` [B.A.T.M.A.N.] [PATCHv3-sven] " Sven Eckelmann
2011-05-28 15:08 ` Marek Lindner
2011-05-28 11:46 ` [B.A.T.M.A.N.] [PATCH-sven] batman-adv: Unify the first 4 " Sven Eckelmann
2011-05-28 11:46 ` [B.A.T.M.A.N.] [PATCHv2-sven] batman-adv: Unify the first 3 " Sven Eckelmann
2011-05-28 11:20 ` [B.A.T.M.A.N.] [PATCH] batman-adv: move the ttl field to the third position of unicast_* packets Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105281417.16069.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.