From: "Heiko Stübner" <heiko@sntech.de>
To: Joe Perches <joe@perches.com>
Cc: Jaya Kumar <jayalk@intworks.biz>,
Paul Mundt <lethal@linux-sh.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jiri Kosina <trivial@kernel.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc
Date: Sat, 28 May 2011 17:48:12 +0000 [thread overview]
Message-ID: <201105281948.12941.heiko@sntech.de> (raw)
In-Reply-To: <77538de911b8af99f68b7bcfbaaedce8e40db04f.1306603968.git.joe@perches.com>
Am Samstag 28 Mai 2011, 19:36:32 schrieb Joe Perches:
> diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
> index 3ec4923..86573e2 100644
> --- a/drivers/video/arcfb.c
> +++ b/drivers/video/arcfb.c
> @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct
> platform_device *dev)
>
> /* We need a flat backing store for the Arc's
> less-flat actual paged framebuffer */
> - if (!(videomemory = vmalloc(videomemorysize)))
> + videomemory = vmalloc(videomemorysize);
> + if (!videomemory)
> return retval;
shouldn't this be vzalloc too?
> - memset(videomemory, 0, videomemorysize);
> -
> info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev);
> if (!info)
> goto err;
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Joe Perches <joe@perches.com>
Cc: Jaya Kumar <jayalk@intworks.biz>,
Paul Mundt <lethal@linux-sh.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jiri Kosina <trivial@kernel.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com,
virtualization@lists.linux-foundation.org
Subject: Re: [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc
Date: Sat, 28 May 2011 19:48:12 +0200 [thread overview]
Message-ID: <201105281948.12941.heiko@sntech.de> (raw)
In-Reply-To: <77538de911b8af99f68b7bcfbaaedce8e40db04f.1306603968.git.joe@perches.com>
Am Samstag 28 Mai 2011, 19:36:32 schrieb Joe Perches:
> diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
> index 3ec4923..86573e2 100644
> --- a/drivers/video/arcfb.c
> +++ b/drivers/video/arcfb.c
> @@ -515,11 +515,10 @@ static int __devinit arcfb_probe(struct
> platform_device *dev)
>
> /* We need a flat backing store for the Arc's
> less-flat actual paged framebuffer */
> - if (!(videomemory = vmalloc(videomemorysize)))
> + videomemory = vmalloc(videomemorysize);
> + if (!videomemory)
> return retval;
shouldn't this be vzalloc too?
> - memset(videomemory, 0, videomemorysize);
> -
> info = framebuffer_alloc(sizeof(struct arcfb_par), &dev->dev);
> if (!info)
> goto err;
Heiko
next prev parent reply other threads:[~2011-05-28 17:48 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 17:36 [TRIVIAL PATCH next 00/15] treewide: Convert vmalloc/memset to vzalloc Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 01/15] s390: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 02/15] x86: " Joe Perches
2011-05-29 19:25 ` [tip:x86/cleanups] x86: Convert vmalloc()+memset() to vzalloc() tip-bot for Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 03/15] atm: Convert vmalloc/memset to vzalloc Joe Perches
2011-05-28 17:36 ` [Drbd-dev] [TRIVIAL PATCH next 04/15] drbd: " Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 05/15] char: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 06/15] isdn: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 07/15] md: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 08/15] media: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 09/15] mtd: " Joe Perches
2011-06-01 8:20 ` Artem Bityutskiy
2011-06-01 8:20 ` Artem Bityutskiy
2011-05-28 17:36 ` [TRIVIAL PATCH next 10/15] scsi: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 11/15] staging: " Joe Perches
2011-05-28 17:36 ` [TRIVIAL PATCH next 12/15] video: " Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:48 ` Heiko Stübner
2011-05-28 17:48 ` Heiko Stübner [this message]
2011-05-28 17:48 ` Heiko Stübner
2011-05-28 18:13 ` [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to Joe Perches
2011-05-28 18:13 ` [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to vzalloc Joe Perches
2011-05-31 14:28 ` [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to Konrad Rzeszutek Wilk
2011-05-31 14:28 ` [TRIVIAL PATCH V2 next 12/15] video: Convert vmalloc/memset to vzalloc Konrad Rzeszutek Wilk
2011-05-31 14:28 ` Konrad Rzeszutek Wilk
2011-06-02 8:26 ` Paul Mundt
2011-06-02 8:26 ` Paul Mundt
2011-06-02 8:26 ` Paul Mundt
2011-05-28 18:13 ` Joe Perches
2011-05-30 11:40 ` [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to Mel Gorman
2011-05-30 11:40 ` [TRIVIAL PATCH next 12/15] video: Convert vmalloc/memset to vzalloc Mel Gorman
2011-05-30 11:40 ` Mel Gorman
2011-05-28 17:36 ` [TRIVIAL PATCH next 13/15] fs: " Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-31 18:20 ` Alex Elder
2011-05-31 18:20 ` Alex Elder
2011-05-31 18:20 ` Alex Elder
[not found] ` <cover.1306603968.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-05-28 17:36 ` [TRIVIAL PATCH next 14/15] mm: " Joe Perches
2011-05-28 17:36 ` Joe Perches
2011-05-28 17:36 ` Joe Perches
[not found] ` <f3d616b526e00bd8f01a250b7ce8c5a6e2412768.1306603968.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2011-05-31 19:47 ` Paul Menage
2011-05-31 19:47 ` Paul Menage
2011-05-31 19:47 ` Paul Menage
2011-05-28 17:36 ` [TRIVIAL PATCH next 15/15] net: " Joe Perches
2011-06-02 14:49 ` Pablo Neira Ayuso
2011-06-02 21:39 ` David Miller
2011-06-03 1:35 ` Joe Perches
2011-06-03 9:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105281948.12941.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=jayalk@intworks.biz \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=joe@perches.com \
--cc=konrad.wilk@oracle.com \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.