From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
Subject: Re: [PATCH 2/2] omap: rx51: Don't power up speaker amplifier at bootup
Date: Tue, 31 May 2011 00:27:08 -0700 [thread overview]
Message-ID: <20110531072708.GK11352@atomide.com> (raw)
In-Reply-To: <1305199858-32643-2-git-send-email-jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [110512 04:26]:
> Speaker amplifier is accidentally powered up in early TWL gpio setup. This
> causes a few mA of needless battery current consumption. Without this patch
> the amplifier can be shutdown only by having one active audio playback and
> shutdown cycle to speaker output.
>
> Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 8242e99..0374562 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
> gpio_request(gpio + 6, "backlight_pwm");
> gpio_direction_output(gpio + 6, 0);
> gpio_request(gpio + 7, "speaker_en");
> - gpio_direction_output(gpio + 7, 1);
> + gpio_direction_output(gpio + 7, 0);
>
> return 0;
> }
Jarkko care to rebase this on current -rc1?
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] omap: rx51: Don't power up speaker amplifier at bootup
Date: Tue, 31 May 2011 00:27:08 -0700 [thread overview]
Message-ID: <20110531072708.GK11352@atomide.com> (raw)
In-Reply-To: <1305199858-32643-2-git-send-email-jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [110512 04:26]:
> Speaker amplifier is accidentally powered up in early TWL gpio setup. This
> causes a few mA of needless battery current consumption. Without this patch
> the amplifier can be shutdown only by having one active audio playback and
> shutdown cycle to speaker output.
>
> Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 8242e99..0374562 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -561,7 +561,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
> gpio_request(gpio + 6, "backlight_pwm");
> gpio_direction_output(gpio + 6, 0);
> gpio_request(gpio + 7, "speaker_en");
> - gpio_direction_output(gpio + 7, 1);
> + gpio_direction_output(gpio + 7, 0);
>
> return 0;
> }
Jarkko care to rebase this on current -rc1?
Tony
next prev parent reply other threads:[~2011-05-31 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 11:30 [PATCH 1/2] omap: rx51: Set regulator V28_A always on Jarkko Nikula
2011-05-12 11:30 ` Jarkko Nikula
2011-05-12 11:30 ` [PATCH 2/2] omap: rx51: Don't power up speaker amplifier at bootup Jarkko Nikula
2011-05-12 11:30 ` Jarkko Nikula
2011-05-31 7:27 ` Tony Lindgren [this message]
2011-05-31 7:27 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2011-05-12 11:28 [PATCH 1/2] omap: rx51: Set regulator V28_A always on Jarkko Nikula
2011-05-12 11:28 ` [PATCH 2/2] omap: rx51: Don't power up speaker amplifier at bootup Jarkko Nikula
2011-05-12 11:28 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531072708.GK11352@atomide.com \
--to=tony@atomide.com \
--cc=jhnikula@gmail.com \
--cc=kalle.jokiniemi@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.