* [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on
@ 2011-05-31 8:27 ` Jarkko Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2011-05-31 8:27 UTC (permalink / raw)
To: linux-omap
Cc: linux-arm-kernel, Tony Lindgren, Jarkko Nikula, Kalle Jokiniemi
The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and
TPA6130A2 should not be shutdown. This is because otherwise there will be
leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery
current that is saved from keeping V28_A off. With this patch the battery
current consumption is approximately 1.5 mA lower.
Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
---
No changes from v1. Just sent together with 2/2.
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index f6247e7..02a6587 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -488,6 +488,7 @@ static struct regulator_init_data rx51_vmmc2 = {
.name = "V28_A",
.min_uV = 2800000,
.max_uV = 3000000,
+ .always_on = true, /* due VIO leak to AIC34 VDDs */
.apply_uV = true,
.valid_modes_mask = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on
@ 2011-05-31 8:27 ` Jarkko Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2011-05-31 8:27 UTC (permalink / raw)
To: linux-arm-kernel
The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and
TPA6130A2 should not be shutdown. This is because otherwise there will be
leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery
current that is saved from keeping V28_A off. With this patch the battery
current consumption is approximately 1.5 mA lower.
Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
---
No changes from v1. Just sent together with 2/2.
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index f6247e7..02a6587 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -488,6 +488,7 @@ static struct regulator_init_data rx51_vmmc2 = {
.name = "V28_A",
.min_uV = 2800000,
.max_uV = 3000000,
+ .always_on = true, /* due VIO leak to AIC34 VDDs */
.apply_uV = true,
.valid_modes_mask = REGULATOR_MODE_NORMAL
| REGULATOR_MODE_STANDBY,
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCHv2 2/2] omap: rx51: Don't power up speaker amplifier at bootup
2011-05-31 8:27 ` Jarkko Nikula
@ 2011-05-31 8:27 ` Jarkko Nikula
-1 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2011-05-31 8:27 UTC (permalink / raw)
To: linux-omap
Cc: linux-arm-kernel, Tony Lindgren, Jarkko Nikula, Kalle Jokiniemi
Speaker amplifier is accidentally powered up in early TWL gpio setup. This
causes a few mA of needless battery current consumption. Without this patch
the amplifier can be shutdown only by having one active audio playback and
shutdown cycle to speaker output.
Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
---
v2. Updated on top of commit bc593f5 ("arm: omap2plus: GPIO cleanup").
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 02a6587..9903667 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -583,7 +583,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
{
/* FIXME this gpio setup is just a placeholder for now */
gpio_request_one(gpio + 6, GPIOF_OUT_INIT_LOW, "backlight_pwm");
- gpio_request_one(gpio + 7, GPIOF_OUT_INIT_HIGH, "speaker_en");
+ gpio_request_one(gpio + 7, GPIOF_OUT_INIT_LOW, "speaker_en");
return 0;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCHv2 2/2] omap: rx51: Don't power up speaker amplifier at bootup
@ 2011-05-31 8:27 ` Jarkko Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Nikula @ 2011-05-31 8:27 UTC (permalink / raw)
To: linux-arm-kernel
Speaker amplifier is accidentally powered up in early TWL gpio setup. This
causes a few mA of needless battery current consumption. Without this patch
the amplifier can be shutdown only by having one active audio playback and
shutdown cycle to speaker output.
Thanks to Kalle Jokiniemi <kalle.jokiniemi@nokia.com> for noticing the issue.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@nokia.com>
---
v2. Updated on top of commit bc593f5 ("arm: omap2plus: GPIO cleanup").
---
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 02a6587..9903667 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -583,7 +583,7 @@ static int rx51_twlgpio_setup(struct device *dev, unsigned gpio, unsigned n)
{
/* FIXME this gpio setup is just a placeholder for now */
gpio_request_one(gpio + 6, GPIOF_OUT_INIT_LOW, "backlight_pwm");
- gpio_request_one(gpio + 7, GPIOF_OUT_INIT_HIGH, "speaker_en");
+ gpio_request_one(gpio + 7, GPIOF_OUT_INIT_LOW, "speaker_en");
return 0;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on
2011-05-31 8:27 ` Jarkko Nikula
@ 2011-05-31 9:34 ` Tony Lindgren
-1 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2011-05-31 9:34 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-omap, linux-arm-kernel, Kalle Jokiniemi
* Jarkko Nikula <jhnikula@gmail.com> [110531 01:22]:
> The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and
> TPA6130A2 should not be shutdown. This is because otherwise there will be
> leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery
> current that is saved from keeping V28_A off. With this patch the battery
> current consumption is approximately 1.5 mA lower.
Thanks, applying into fixes.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on
@ 2011-05-31 9:34 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2011-05-31 9:34 UTC (permalink / raw)
To: linux-arm-kernel
* Jarkko Nikula <jhnikula@gmail.com> [110531 01:22]:
> The V28_A domain in Nokia N900 that supplies VDD voltages to TLV320AIC34 and
> TPA6130A2 should not be shutdown. This is because otherwise there will be
> leak from VIO to VDD in TLV320AIC34 and this leak consumes more battery
> current that is saved from keeping V28_A off. With this patch the battery
> current consumption is approximately 1.5 mA lower.
Thanks, applying into fixes.
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-05-31 9:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-31 8:27 [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on Jarkko Nikula
2011-05-31 8:27 ` Jarkko Nikula
2011-05-31 8:27 ` [PATCHv2 2/2] omap: rx51: Don't power up speaker amplifier at bootup Jarkko Nikula
2011-05-31 8:27 ` Jarkko Nikula
2011-05-31 9:34 ` [PATCHv2 1/2] omap: rx51: Set regulator V28_A always on Tony Lindgren
2011-05-31 9:34 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.