From: Tony Lindgren <tony@atomide.com>
To: Colin Cross <ccross@android.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Russell King <linux@arm.linux.org.uk>,
l-o <linux-omap@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: omap4: Pass core and wakeup mux tables to omap4_mux_init
Date: Wed, 1 Jun 2011 09:46:06 +0300 [thread overview]
Message-ID: <20110601064606.GC8696@atomide.com> (raw)
In-Reply-To: <BANLkTikfXs1oLott64+C5wy59G24Mux0TJ52et7GTEMQrfqRFQ@mail.gmail.com>
* Colin Cross <ccross@android.com> [110531 21:46]:
> On Tue, May 31, 2011 at 5:42 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Colin Cross <ccross@android.com> [110504 14:54]:
> >> OMAP4 contains two separate instances of the padconf registers,
> >> one in the core system config and one in the wakeup system config.
> >> Pass in two tables to apply the correct values to each instance.
> >
> > Hmm good catch thanks. Will queue this as a fix.
>
> This patch doesn't work without another fix to allow NULL to be passed
> to omap4_mux_init. Do you prefer allowing NULL, or adding empty
> board_wkup_mux arrays to every board file? I have a patch for the
> first option.
OK, saw that patch and adding to fixes. Passing NULL here is fine.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap4: Pass core and wakeup mux tables to omap4_mux_init
Date: Wed, 1 Jun 2011 09:46:06 +0300 [thread overview]
Message-ID: <20110601064606.GC8696@atomide.com> (raw)
In-Reply-To: <BANLkTikfXs1oLott64+C5wy59G24Mux0TJ52et7GTEMQrfqRFQ@mail.gmail.com>
* Colin Cross <ccross@android.com> [110531 21:46]:
> On Tue, May 31, 2011 at 5:42 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Colin Cross <ccross@android.com> [110504 14:54]:
> >> OMAP4 contains two separate instances of the padconf registers,
> >> one in the core system config and one in the wakeup system config.
> >> Pass in two tables to apply the correct values to each instance.
> >
> > Hmm good catch thanks. Will queue this as a fix.
>
> This patch doesn't work without another fix to allow NULL to be passed
> to omap4_mux_init. Do you prefer allowing NULL, or adding empty
> board_wkup_mux arrays to every board file? I have a patch for the
> first option.
OK, saw that patch and adding to fixes. Passing NULL here is fine.
Tony
next prev parent reply other threads:[~2011-06-01 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 21:57 [PATCH] ARM: omap4: Pass core and wakeup mux tables to omap4_mux_init Colin Cross
2011-05-04 21:57 ` Colin Cross
2011-05-31 12:42 ` Tony Lindgren
2011-05-31 12:42 ` Tony Lindgren
2011-05-31 18:50 ` Colin Cross
2011-05-31 18:50 ` Colin Cross
2011-06-01 6:46 ` Tony Lindgren [this message]
2011-06-01 6:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601064606.GC8696@atomide.com \
--to=tony@atomide.com \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.