From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia@diku.dk>
Cc: Timur Tabi <timur@freescale.com>,
Wan ZongShun <mcuos.com@gmail.com>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
alsa-devel@alsa-project.org, Axel Lin <axel.lin@gmail.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/10] sound/soc/nuc900/nuc900-ac97.c: add missing clk_put
Date: Wed, 1 Jun 2011 19:21:14 +0100 [thread overview]
Message-ID: <20110601182114.GC16396@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306948213-20767-2-git-send-email-julia@diku.dk>
On Wed, Jun 01, 2011 at 07:10:05PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> This goto is after the call to clk_get, so it should go to the label that
> includes a call to clk_put.
Applied, thanks. Please do try to use subject lines for your patches
consistent with the code you're submitting against.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia@diku.dk>
Cc: Timur Tabi <timur@freescale.com>,
Wan ZongShun <mcuos.com@gmail.com>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
alsa-devel@alsa-project.org, Axel Lin <axel.lin@gmail.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 2/10] sound/soc/nuc900/nuc900-ac97.c: add missing clk_put
Date: Wed, 01 Jun 2011 18:21:14 +0000 [thread overview]
Message-ID: <20110601182114.GC16396@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306948213-20767-2-git-send-email-julia@diku.dk>
On Wed, Jun 01, 2011 at 07:10:05PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> This goto is after the call to clk_get, so it should go to the label that
> includes a call to clk_put.
Applied, thanks. Please do try to use subject lines for your patches
consistent with the code you're submitting against.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia@diku.dk>
Cc: Liam Girdwood <lrg@ti.com>,
kernel-janitors@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>, Wan ZongShun <mcuos.com@gmail.com>,
Axel Lin <axel.lin@gmail.com>, Timur Tabi <timur@freescale.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/10] sound/soc/nuc900/nuc900-ac97.c: add missing clk_put
Date: Wed, 1 Jun 2011 19:21:14 +0100 [thread overview]
Message-ID: <20110601182114.GC16396@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306948213-20767-2-git-send-email-julia@diku.dk>
On Wed, Jun 01, 2011 at 07:10:05PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> This goto is after the call to clk_get, so it should go to the label that
> includes a call to clk_put.
Applied, thanks. Please do try to use subject lines for your patches
consistent with the code you're submitting against.
next prev parent reply other threads:[~2011-06-01 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:10 [PATCH 2/10] sound/soc/nuc900/nuc900-ac97.c: add missing clk_put Julia Lawall
2011-06-01 17:10 ` Julia Lawall
2011-06-01 17:10 ` Julia Lawall
2011-06-01 17:12 ` Liam Girdwood
2011-06-01 17:12 ` Liam Girdwood
2011-06-01 17:12 ` Liam Girdwood
2011-06-01 18:21 ` Mark Brown [this message]
2011-06-01 18:21 ` Mark Brown
2011-06-01 18:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601182114.GC16396@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mcuos.com@gmail.com \
--cc=timur@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.