* RE: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
@ 2011-06-01 19:12 ` Luck, Tony
2011-06-01 19:31 ` Mark Brown
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luck, Tony @ 2011-06-01 19:12 UTC (permalink / raw)
To: linux-ia64
+ select ARCH_WANT_OPTINAL_GPIOLIB
"OPTINAL"? ... presumably "OPTIONAL" (or "OPTIMAL" :-)
-Tony
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
2011-06-01 19:12 ` Luck, Tony
@ 2011-06-01 19:31 ` Mark Brown
2011-06-01 19:33 ` Grant Likely
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-06-01 19:31 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 01, 2011 at 12:12:37PM -0700, Luck, Tony wrote:
> + select ARCH_WANT_OPTINAL_GPIOLIB
> "OPTINAL"? ... presumably "OPTIONAL" (or "OPTIMAL" :-)
Should be OPTINAL, yes.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
2011-06-01 19:12 ` Luck, Tony
2011-06-01 19:31 ` Mark Brown
@ 2011-06-01 19:33 ` Grant Likely
2011-06-01 19:34 ` Mark Brown
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Grant Likely @ 2011-06-01 19:33 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 1, 2011 at 1:31 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jun 01, 2011 at 12:12:37PM -0700, Luck, Tony wrote:
>> + select ARCH_WANT_OPTINAL_GPIOLIB
>
>> "OPTINAL"? ... presumably "OPTIONAL" (or "OPTIMAL" :-)
>
> Should be OPTINAL, yes.
>
Same typo again? :-)
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (2 preceding siblings ...)
2011-06-01 19:33 ` Grant Likely
@ 2011-06-01 19:34 ` Mark Brown
2011-06-01 20:15 ` Grant Likely
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-06-01 19:34 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 01, 2011 at 01:33:34PM -0600, Grant Likely wrote:
> On Wed, Jun 1, 2011 at 1:31 PM, Mark Brown
> > On Wed, Jun 01, 2011 at 12:12:37PM -0700, Luck, Tony wrote:
> >> + select ARCH_WANT_OPTINAL_GPIOLIB
> >> "OPTINAL"? ... presumably "OPTIONAL" (or "OPTIMAL" :-)
> > Should be OPTINAL, yes.
> Same typo again? :-)
Bah, humbg. :P
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (3 preceding siblings ...)
2011-06-01 19:34 ` Mark Brown
@ 2011-06-01 20:15 ` Grant Likely
2011-06-01 20:25 ` Mark Brown
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Grant Likely @ 2011-06-01 20:15 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 1, 2011 at 1:34 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Jun 01, 2011 at 01:33:34PM -0600, Grant Likely wrote:
>> On Wed, Jun 1, 2011 at 1:31 PM, Mark Brown
>
>> > On Wed, Jun 01, 2011 at 12:12:37PM -0700, Luck, Tony wrote:
>> >> + select ARCH_WANT_OPTINAL_GPIOLIB
>
>> >> "OPTINAL"? ... presumably "OPTIONAL" (or "OPTIMAL" :-)
>
>> > Should be OPTINAL, yes.
>
>> Same typo again? :-)
>
> Bah, humbg. :P
^^
HAHAHAHAHA
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (4 preceding siblings ...)
2011-06-01 20:15 ` Grant Likely
@ 2011-06-01 20:25 ` Mark Brown
2011-06-01 21:07 ` Tony Luck
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-06-01 20:25 UTC (permalink / raw)
To: linux-ia64
Allow people to use gpiolib on ia64, mostly for build coverage as it
seems more useful to standardise on availablity of the API than handle
it being optional.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
arch/ia64/Kconfig | 4 +++
arch/ia64/include/asm/gpio.h | 55 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 59 insertions(+), 0 deletions(-)
create mode 100644 arch/ia64/include/asm/gpio.h
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig
index 38280ef..578701e 100644
--- a/arch/ia64/Kconfig
+++ b/arch/ia64/Kconfig
@@ -27,6 +27,7 @@ config IA64
select GENERIC_PENDING_IRQ if SMP
select IRQ_PER_CPU
select GENERIC_IRQ_SHOW
+ select ARCH_WANT_OPTIONAL_GPIOLIB
default y
help
The Itanium Processor Family is Intel's 64-bit successor to
@@ -89,6 +90,9 @@ config GENERIC_TIME_VSYSCALL
config HAVE_SETUP_PER_CPU_AREA
def_bool y
+config GENERIC_GPIO
+ def_bool y
+
config DMI
bool
default y
diff --git a/arch/ia64/include/asm/gpio.h b/arch/ia64/include/asm/gpio.h
new file mode 100644
index 0000000..590a20d
--- /dev/null
+++ b/arch/ia64/include/asm/gpio.h
@@ -0,0 +1,55 @@
+/*
+ * Generic GPIO API implementation for IA-64.
+ *
+ * A stright copy of that for PowerPC which was:
+ *
+ * Copyright (c) 2007-2008 MontaVista Software, Inc.
+ *
+ * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#ifndef _ASM_IA64_GPIO_H
+#define _ASM_IA64_GPIO_H
+
+#include <linux/errno.h>
+#include <asm-generic/gpio.h>
+
+#ifdef CONFIG_GPIOLIB
+
+/*
+ * We don't (yet) implement inlined/rapid versions for on-chip gpios.
+ * Just call gpiolib.
+ */
+static inline int gpio_get_value(unsigned int gpio)
+{
+ return __gpio_get_value(gpio);
+}
+
+static inline void gpio_set_value(unsigned int gpio, int value)
+{
+ __gpio_set_value(gpio, value);
+}
+
+static inline int gpio_cansleep(unsigned int gpio)
+{
+ return __gpio_cansleep(gpio);
+}
+
+static inline int gpio_to_irq(unsigned int gpio)
+{
+ return __gpio_to_irq(gpio);
+}
+
+static inline int irq_to_gpio(unsigned int irq)
+{
+ return -EINVAL;
+}
+
+#endif /* CONFIG_GPIOLIB */
+
+#endif /* _ASM_IA64_GPIO_H */
--
1.7.5.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (5 preceding siblings ...)
2011-06-01 20:25 ` Mark Brown
@ 2011-06-01 21:07 ` Tony Luck
2011-06-02 10:07 ` Mark Brown
2011-06-02 17:00 ` Luck, Tony
8 siblings, 0 replies; 10+ messages in thread
From: Tony Luck @ 2011-06-01 21:07 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 1, 2011 at 1:25 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> Allow people to use gpiolib on ia64, mostly for build coverage as it
> seems more useful to standardise on availablity of the API than handle
> it being optional.
Well it applies cleanly, builds too. I can even turn on CONFIG_GPIOLIB=y,
CONFIG_DEBUG_GPIO=y and CONFIG_GPIO_SYSFS=y and build even
more bits (no warnings, nice).
But is there anything that I can do with it to show that it is working
correctly?
-Tony
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (6 preceding siblings ...)
2011-06-01 21:07 ` Tony Luck
@ 2011-06-02 10:07 ` Mark Brown
2011-06-02 17:00 ` Luck, Tony
8 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2011-06-02 10:07 UTC (permalink / raw)
To: linux-ia64
On Wed, Jun 01, 2011 at 02:07:11PM -0700, Tony Luck wrote:
> But is there anything that I can do with it to show that it is working
> correctly?
Not really - you can build drivers that use gpiolib but unless you
obtain some hardware which uses it or write a virtual GPIO driver and a
consumer for it there's not really a lot doing except build tests. Like
I said in the changelog the main thought here was to make build coverage
easier in a way that is more useful than bodging around optionally
available stuff.
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH] ia64: Hook up gpiolib support
2011-06-01 9:48 [PATCH] ia64: Hook up gpiolib support Mark Brown
` (7 preceding siblings ...)
2011-06-02 10:07 ` Mark Brown
@ 2011-06-02 17:00 ` Luck, Tony
8 siblings, 0 replies; 10+ messages in thread
From: Luck, Tony @ 2011-06-02 17:00 UTC (permalink / raw)
To: linux-ia64
> Not really - you can build drivers that use gpiolib but unless you
> obtain some hardware which uses it or write a virtual GPIO driver and a
> consumer for it there's not really a lot doing except build tests. Like
> I said in the changelog the main thought here was to make build coverage
> easier in a way that is more useful than bodging around optionally
> available stuff.
Fair enough. I've dropped it into my test tree, so it should show
up in linux-next soon. I'll send to Linus in the 3.1 merge window.
-Tony
^ permalink raw reply [flat|nested] 10+ messages in thread