From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "open list:XEN HYPERVISOR IN..." <xen-devel@lists.xensource.com>,
Dan Carpenter <error27@gmail.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
kernel-janitors@vger.kernel.org,
"open list:XEN HYPERVISOR IN..."
<virtualization@lists.linux-foundation.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [Xen-devel] Re: [patch] xen: off by one errors in multicalls.c
Date: Fri, 03 Jun 2011 19:57:15 +0000 [thread overview]
Message-ID: <20110603195715.GB30940@dumpdata.com> (raw)
In-Reply-To: <4DE926D4.9010009@goop.org>
On Fri, Jun 03, 2011 at 11:24:20AM -0700, Jeremy Fitzhardinge wrote:
> On 06/02/2011 09:45 PM, Dan Carpenter wrote:
> > b->args[] has MC_ARGS elements, so the comparison here should be
> > ">=" instead of ">". Otherwise we read past the end of the array
> > one space.
>
> Yeah, looks like a correct fix. Fortunately I don't think anything
> currently hits that path in practice, though there are some pending
> patches which will exercise it more.
OK, queueing it for rc1.
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "open list:XEN HYPERVISOR IN..." <xen-devel@lists.xensource.com>,
Dan Carpenter <error27@gmail.com>,
"maintainer:X86 ARCHITECTURE..." <x86@kernel.org>,
kernel-janitors@vger.kernel.org,
"open list:XEN HYPERVISOR IN..."
<virtualization@lists.linux-foundation.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [Xen-devel] Re: [patch] xen: off by one errors in multicalls.c
Date: Fri, 3 Jun 2011 15:57:15 -0400 [thread overview]
Message-ID: <20110603195715.GB30940@dumpdata.com> (raw)
In-Reply-To: <4DE926D4.9010009@goop.org>
On Fri, Jun 03, 2011 at 11:24:20AM -0700, Jeremy Fitzhardinge wrote:
> On 06/02/2011 09:45 PM, Dan Carpenter wrote:
> > b->args[] has MC_ARGS elements, so the comparison here should be
> > ">=" instead of ">". Otherwise we read past the end of the array
> > one space.
>
> Yeah, looks like a correct fix. Fortunately I don't think anything
> currently hits that path in practice, though there are some pending
> patches which will exercise it more.
OK, queueing it for rc1.
next prev parent reply other threads:[~2011-06-03 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-03 4:45 [patch] xen: off by one errors in multicalls.c Dan Carpenter
2011-06-03 4:45 ` Dan Carpenter
2011-06-03 18:24 ` Jeremy Fitzhardinge
2011-06-03 18:24 ` Jeremy Fitzhardinge
2011-06-03 19:57 ` Konrad Rzeszutek Wilk [this message]
2011-06-03 19:57 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-06-03 18:24 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603195715.GB30940@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=error27@gmail.com \
--cc=hpa@zytor.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.