All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Unhide DEBUG_BUGVERBOSE when EXPERT=y, even if DEBUG_KERNEL=n
Date: Sun, 5 Jun 2011 11:34:45 +0200	[thread overview]
Message-ID: <20110605093445.GA19927@elte.hu> (raw)
In-Reply-To: <20110605083230.GA18260@leaf>


* Josh Triplett <josh@joshtriplett.org> wrote:

>  config DEBUG_BUGVERBOSE
> -	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EXPERT
> +	bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL || EXPERT

Well, DEBUG_KERNEL really means two things:

  - make more debugging options available
  - allow the *disabling* of existing (default-enabled) debug options

So i think the right solution would be to select DEBUG_KERNEL if 
EXPERT is enabled - this would simplify things and would allow the 
removal of a lot of EXPERT conditions from the debug options.

Ok?

Thanks,

	Ingo

  reply	other threads:[~2011-06-05  9:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05  8:32 [PATCH] Unhide DEBUG_BUGVERBOSE when EXPERT=y, even if DEBUG_KERNEL=n Josh Triplett
2011-06-05  9:34 ` Ingo Molnar [this message]
2011-06-05 17:06   ` Josh Triplett
2011-06-05 17:31     ` Ingo Molnar
2011-06-05 20:24       ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110605093445.GA19927@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=jeremy@goop.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.