From: Josh Triplett <josh@joshtriplett.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Unhide DEBUG_BUGVERBOSE when EXPERT=y, even if DEBUG_KERNEL=n
Date: Sun, 5 Jun 2011 10:06:39 -0700 [thread overview]
Message-ID: <20110605170639.GA739@leaf> (raw)
In-Reply-To: <20110605093445.GA19927@elte.hu>
On Sun, Jun 05, 2011 at 11:34:45AM +0200, Ingo Molnar wrote:
>
> * Josh Triplett <josh@joshtriplett.org> wrote:
>
> > config DEBUG_BUGVERBOSE
> > - bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL && EXPERT
> > + bool "Verbose BUG() reporting (adds 70K)" if DEBUG_KERNEL || EXPERT
>
> Well, DEBUG_KERNEL really means two things:
>
> - make more debugging options available
> - allow the *disabling* of existing (default-enabled) debug options
As well as one more: a quick "git grep DEBUG_KERNEL" turns up a few uses
in actual kernel source code, to control debugging features. Those
should likely use separately selectable debug options, but they
currently don't.
~/src/linux-2.6$ find * -not -name 'Kconfig*' -not -name '*defconfig' | xargs grep -n DEBUG_KERNEL
arch/parisc/mm/init.c:653:#ifdef CONFIG_DEBUG_KERNEL /* double-sanity-check paranoia */
arch/powerpc/kernel/sysfs.c:229:#ifdef CONFIG_DEBUG_KERNEL
arch/powerpc/kernel/sysfs.c:258:#endif /* CONFIG_DEBUG_KERNEL */
arch/powerpc/kernel/sysfs.c:299:#ifdef CONFIG_DEBUG_KERNEL
arch/powerpc/kernel/sysfs.c:328:#endif /* CONFIG_DEBUG_KERNEL */
arch/blackfin/include/asm/entry.h:53:/* As a debugging aid - we save IPEND when DEBUG_KERNEL is on,
arch/blackfin/include/asm/entry.h:56:# ifndef CONFIG_DEBUG_KERNEL
arch/blackfin/include/asm/entry.h:65:# else /* CONFIG_DEBUG_KERNEL */
arch/blackfin/include/asm/entry.h:77:# endif /* CONFIG_DEBUG_KERNEL */
arch/blackfin/include/asm/context.S:208:#ifdef CONFIG_DEBUG_KERNEL
drivers/usb/musb/musb_core.c:557: * REVISIT: do delays from lots of DEBUG_KERNEL checks
> So i think the right solution would be to select DEBUG_KERNEL if
> EXPERT is enabled - this would simplify things and would allow the
> removal of a lot of EXPERT conditions from the debug options.
>
> Ok?
I could live with that, as long as CONFIG_DEBUG_KERNEL never directly
enables any debugging code like it does above, and just acts like
CONFIG_EXPERT in hiding a pile of unnecessary options. DEBUG_KERNEL
should probably also have some text saying it doesn't actually enable
any kernel debugging on its own, once that becomes true.
- Josh Triplett
next prev parent reply other threads:[~2011-06-05 17:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 8:32 [PATCH] Unhide DEBUG_BUGVERBOSE when EXPERT=y, even if DEBUG_KERNEL=n Josh Triplett
2011-06-05 9:34 ` Ingo Molnar
2011-06-05 17:06 ` Josh Triplett [this message]
2011-06-05 17:31 ` Ingo Molnar
2011-06-05 20:24 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110605170639.GA739@leaf \
--to=josh@joshtriplett.org \
--cc=akpm@linux-foundation.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.