* [PATCH] fix ->mknod() return value on xfs_get_acl() failure
@ 2011-06-05 11:12 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2011-06-05 11:12 UTC (permalink / raw)
To: xfs; +Cc: linux-kernel
->mknod() should return negative on errors and PTR_ERR() gives
already negative value...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index dd21784..d44d92c 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -182,7 +182,7 @@ xfs_vn_mknod(
if (IS_POSIXACL(dir)) {
default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
if (IS_ERR(default_acl))
- return -PTR_ERR(default_acl);
+ return PTR_ERR(default_acl);
if (!default_acl)
mode &= ~current_umask();
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] fix ->mknod() return value on xfs_get_acl() failure
@ 2011-06-05 11:12 ` Al Viro
0 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2011-06-05 11:12 UTC (permalink / raw)
To: xfs; +Cc: linux-kernel
->mknod() should return negative on errors and PTR_ERR() gives
already negative value...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index dd21784..d44d92c 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -182,7 +182,7 @@ xfs_vn_mknod(
if (IS_POSIXACL(dir)) {
default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
if (IS_ERR(default_acl))
- return -PTR_ERR(default_acl);
+ return PTR_ERR(default_acl);
if (!default_acl)
mode &= ~current_umask();
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] fix ->mknod() return value on xfs_get_acl() failure
2011-06-05 11:12 ` Al Viro
@ 2011-06-06 15:01 ` Christoph Hellwig
-1 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2011-06-06 15:01 UTC (permalink / raw)
To: Al Viro; +Cc: linux-kernel, xfs
On Sun, Jun 05, 2011 at 12:12:31PM +0100, Al Viro wrote:
> ->mknod() should return negative on errors and PTR_ERR() gives
> already negative value...
Indeed. Thanks for the patch.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-06 15:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-05 11:12 [PATCH] fix ->mknod() return value on xfs_get_acl() failure Al Viro
2011-06-05 11:12 ` Al Viro
2011-06-06 15:01 ` Christoph Hellwig
2011-06-06 15:01 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.