From: Todd Poynor <toddpoynor@google.com>
To: Kevin Hilman <khilman@ti.com>
Cc: l-o <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>
Subject: Re: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits
Date: Mon, 6 Jun 2011 16:05:22 -0700 [thread overview]
Message-ID: <20110606230522.GA16590@google.com> (raw)
In-Reply-To: <87r576wpz6.fsf@ti.com>
On Mon, Jun 06, 2011 at 03:32:29PM -0700, Kevin Hilman wrote:
> Colin Cross <ccross@android.com> writes:
>
> > On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross <ccross@android.com> wrote:
> >> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
> >> causing only the last bit set to take effect, resulting in lost
> >> wakeups when the GPIO controller is in idle.
> >>
> >> Replace direct writes to IRQWAKEN with writes to SETWKUENA and
> >> CLEARWKUEN.
> >>
> >> Signed-off-by: Colin Cross <ccross@android.com>
>
> [...]
>
> >
> > Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and
> > CLEARWKUENA.
>
> In my GPIO cleanups, I was wondering why the set/clear registers were
> not used here. Todd, can you give the TRM version & reference for this?
> I didn't find anything after a quick scan/search.
http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?templateId=6123&navigationId=12037
OMAP4460 Multimedia Device Silicon Revision 1.0 Version E
February 2011–Revised May 2011
p. 5357 Table 25-68. GPIO_CLEARWKUPENA
"Caution: This register is kept for backward software compatibility. Use
GPIO_IRQWAKEN_0 and GPIO_IRQWAKEN_1 instead."
OMAP4430 TRM is similar.
Todd
WARNING: multiple messages have this Message-ID (diff)
From: toddpoynor@google.com (Todd Poynor)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits
Date: Mon, 6 Jun 2011 16:05:22 -0700 [thread overview]
Message-ID: <20110606230522.GA16590@google.com> (raw)
In-Reply-To: <87r576wpz6.fsf@ti.com>
On Mon, Jun 06, 2011 at 03:32:29PM -0700, Kevin Hilman wrote:
> Colin Cross <ccross@android.com> writes:
>
> > On Sat, Jun 4, 2011 at 12:03 PM, Colin Cross <ccross@android.com> wrote:
> >> Setting the IRQWAKEN bit was overwriting previous IRQWAKEN bits,
> >> causing only the last bit set to take effect, resulting in lost
> >> wakeups when the GPIO controller is in idle.
> >>
> >> Replace direct writes to IRQWAKEN with writes to SETWKUENA and
> >> CLEARWKUEN.
> >>
> >> Signed-off-by: Colin Cross <ccross@android.com>
>
> [...]
>
> >
> > Todd pointed out that the OMAP4 TRM says not to use SETWKUENA and
> > CLEARWKUENA.
>
> In my GPIO cleanups, I was wondering why the set/clear registers were
> not used here. Todd, can you give the TRM version & reference for this?
> I didn't find anything after a quick scan/search.
http://focus.ti.com/general/docs/wtbu/wtbudocumentcenter.tsp?templateId=6123&navigationId=12037
OMAP4460 Multimedia Device Silicon Revision 1.0 Version E
February 2011?Revised May 2011
p. 5357 Table 25-68. GPIO_CLEARWKUPENA
"Caution: This register is kept for backward software compatibility. Use
GPIO_IRQWAKEN_0 and GPIO_IRQWAKEN_1 instead."
OMAP4430 TRM is similar.
Todd
next prev parent reply other threads:[~2011-06-06 23:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-04 19:03 [PATCH] ARM: omap4: gpio: fix setting IRQWAKEN bits Colin Cross
2011-06-04 19:03 ` Colin Cross
2011-06-05 2:37 ` Colin Cross
2011-06-05 2:37 ` Colin Cross
2011-06-05 2:37 ` Colin Cross
2011-06-06 22:32 ` Kevin Hilman
2011-06-06 22:32 ` Kevin Hilman
2011-06-06 23:05 ` Todd Poynor [this message]
2011-06-06 23:05 ` Todd Poynor
2011-06-06 23:25 ` Kevin Hilman
2011-06-06 23:25 ` Kevin Hilman
2011-06-06 23:25 ` Kevin Hilman
2011-06-06 7:02 ` Santosh Shilimkar
2011-06-06 7:02 ` Santosh Shilimkar
2011-06-06 7:23 ` DebBarma, Tarun Kanti
2011-06-06 7:23 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606230522.GA16590@google.com \
--to=toddpoynor@google.com \
--cc=ccross@android.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.