From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: RCU-protect __set_task_cpu() in set_task_cpu()
Date: Tue, 7 Jun 2011 16:03:59 +0200 [thread overview]
Message-ID: <20110607140359.GA5497@redhat.com> (raw)
In-Reply-To: <1307439107.2322.229.camel@twins>
On 06/07, Peter Zijlstra wrote:
>
> Cure this by passing the migration state in wake_flags. Also move the
> whole test under CONFIG_SMP, its hard to migrate tasks on UP :-)
Agreed, WF_MIGRATE looks better. and "move under CONFIG_SMP" is probably
correct ;)
I still think it makes sense to move task_cpu(p) from try_to_wake_up() to
ttwu_stat(), just because it looks confusing. But this is very minor,
please forget.
Oleg.
next prev parent reply other threads:[~2011-06-07 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 17:26 [PATCH] sched: RCU-protect __set_task_cpu() in set_task_cpu() Sergey Senozhatsky
2011-05-31 19:45 ` Peter Zijlstra
2011-06-03 15:37 ` Peter Zijlstra
2011-06-03 18:16 ` Sergey Senozhatsky
2011-06-03 22:49 ` Sergey Senozhatsky
2011-06-05 19:12 ` Oleg Nesterov
2011-06-06 9:06 ` Peter Zijlstra
2011-06-06 16:46 ` Oleg Nesterov
2011-06-07 9:31 ` Peter Zijlstra
2011-06-07 14:03 ` Oleg Nesterov [this message]
2011-06-06 13:43 ` Peter Zijlstra
2011-06-07 12:03 ` [tip:sched/urgent] sched: Fix/clarify set_task_cpu() locking rules tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607140359.GA5497@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.