Re: [PATCH] linphone: added recipe for v3.4.3

[Guillaume BERAUDO <guillaume.beraudo@belledonne-communications.com>]

Sorry, I missed your other comments.
See below for my answers.

> > --git a/recipes/linphone/linphone-common_3.4.3.inc
> > b/recipes/linphone/linphone-common_3.4.3.inc new file mode 100644
> > index 0000000..5865ab0 --- /dev/null
> > +++ b/recipes/linphone/linphone-common_3.4.3.inc
> > @@ -0,0 +1,11 @@
> > +
> > +SRC_URI =
> > "${SAVANNAH_MIRROR}/releases/linphone/3.4.x/sources/linphone-3.4.3.tar.gz
> > \
> > +	file://cif10fps.patch"
> where is this file?

It is a mistake, this patch should not be added.



> > +require linphone-common.inc
> > diff --git a/recipes/linphone/linphone_3.4.3+nogtk.bb
> > b/recipes/linphone/linphone_3.4.3+nogtk.bb new file mode 100644
> > index 0000000..9bec7b1
> > --- /dev/null
> > +++ b/recipes/linphone/linphone_3.4.3+nogtk.bb
>
> what does +nogtk mean in version?

It is possible to compile linphone with or without gtk GUI.

I wrote another recipe for linphone 3.4.3 with gtk GUI.
It will be sent for review later.


> > @@ -0,0 +1,9 @@
> > +DESCRIPTION = "Audio/video SIP-based IP phone (console edition)"
> > +HOMEPAGE = "http://www.linphone.org/?lang=us"
> > +LICENSE = "GPLv2"
> > +PR="r6"
> > +
> > +DEFAULT_PREFERENCE = "2"
> 
> why D_P = "2" when all other recipes have default D_P = "1" and this
> has highest PV?

Ok, I will correct it.


> 
> > +OVERRIDES_append = ":video:console"
> 
> This looks like someone trying to implement USE flags in OE :). But
> I'm not sure it's right way and I haven't noticed this used in any
> other recipe. So it would be better to discuss first.

I am new to openembedded and thus may have missed something in the
documentations. Can you point me to some elegant way to implement
recipe flavours?


Thanks,

Guillaume