Re: [PATCH] linphone: added recipe for v3.4.3

[Guillaume BERAUDO <guillaume.beraudo@belledonne-communications.com>]

Hi,

> > > > > > +OVERRIDES_append = ":video:console"
> > > > > 
> > > > > This looks like someone trying to implement USE flags in
> > > > > OE :). But I'm not sure it's right way and I haven't noticed
> > > > > this used in any other recipe. So it would be better to
> > > > > discuss first.
> > > > 
> > > > I am new to openembedded and thus may have missed something in
> > > > the documentations. Can you point me to some elegant way to
> > > > implement recipe flavours?
> > > 
> > > I don't think TSC agreed on some sort of USE-flag solution or
> > > policy yet, but keeping shared EXTRA_OECONF in linphone-3.4.3.inc
> > > and then EXTRA_OECONF_append with nogtk specific options in
> > > separate files like linphone-nogtk_3.4.3.bb would be easier to
> > > understand (at least to me), even when not so "elegant" as your
> > > OVERRIDES solution.

With your advice, a typical linphone recipe would contain a block like
this:

# With video
DEPENDS_append = " libxv ffmpeg libv4l"
EXTRA_OECONF_append = "
--with-ffmpeg=${STAGING_DIR_HOST}${layout_exec_prefix} --enable-video"

# Without video
#EXTRA_OECONF_append = " --disable-video"


# GTK GUI
DEPENDS_append = " gtk+"
PROVIDES_append = " linphone"
PACKAGES_prepend = "${PN}-dbg ${PN} ${PN}-doc ${PN}-dev ${PN}-locale "
EXTRA_OECONF_append = " --enable-gtk_ui=yes"

# Without GTK GUI
#EXTRA_OECONF_append = " --enable-gtk_ui=no"


Though it is easier at first glance I feel it error prone.
When creating a new recipe, it is easy to forget uncommenting
directives.

Is it blocking to use my initial solution with OVERRIDES?
If yes, what about using a "@base_conditional"?
Eg:
LINPHONE_FLAVOUR_WITH_GTK = '1'
@base_conditional('LINPHONE_FLAVOUR_WITH_GTK', '1', 'something when
active', 'something when inactive')

This would keep the recipes simple and avoid using any OVERRIDES or
_append.



> > There is also some conditionnals with the DEPENDS.
> > What is the use of all the "DEPENDS_some-package-name" directives?
> > Isn't it identical to only use the global "DEPENDS"?
> 
> Yes it looks weird and broken on quick glance.
> but "shared" DEPENDS = "foo" in linphone-3.4.3.inc and DEPENDS_append
> = "gtk+" in linphone-gtk_1.2.4.bb makes sense
>  
> > I removed all the RDEPENDS stuff. Can you confirm it was
> > unnecessary?
> 
> all linked .so providers should be picked to rdepends automatically by
> package.bbclass so only extra stuff like linphone-gtk-config would be
> needed in extra RDEPENDS_${PN} in linphone-gtk_1.2.4.bb.

Isn't the "inherit pkgconfig" managing it already?

Also, do you thing this line is of any use?
"export PKG_CONFIG=${STAGING_BINDIR_NATIVE}/pkg-config"

Regards
Guillaume