From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Thomas Sattler <tsattler@gmx.de>,
Ury Stankevich <urykhy@gmail.com>,
Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous
Date: Tue, 7 Jun 2011 17:26:54 +0100 [thread overview]
Message-ID: <20110607162654.GN5247@suse.de> (raw)
In-Reply-To: <20110607155029.GL1686@barrios-laptop>
On Wed, Jun 08, 2011 at 12:50:29AM +0900, Minchan Kim wrote:
> > <SNIP>
> > @@ -533,8 +544,14 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
> > unsigned long nr_migrate, nr_remaining;
> > int err;
> >
> > - if (!isolate_migratepages(zone, cc))
> > + switch (isolate_migratepages(zone, cc)) {
> > + case ISOLATE_ABORT:
>
> In this case, you change old behavior slightly.
> In old case, we return COMPACT_PARTIAL to cancel migration.
> But this patch makes to return COMPACT_SUCCESS.
> At present, return value of compact_zone is only used by __alloc_pages_direct_compact
> and it only consider COMPACT_SKIPPED so it would be not a problem.
> But I think it would be better to return COMPACT_PARTIAL instead of COMPACT_CONTINUE
> for consistency with compact_finished and right semantic for the future user of compact_zone.
>
Agreed. Thanks.
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Thomas Sattler <tsattler@gmx.de>,
Ury Stankevich <urykhy@gmail.com>,
Andi Kleen <andi@firstfloor.org>, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous
Date: Tue, 7 Jun 2011 17:26:54 +0100 [thread overview]
Message-ID: <20110607162654.GN5247@suse.de> (raw)
In-Reply-To: <20110607155029.GL1686@barrios-laptop>
On Wed, Jun 08, 2011 at 12:50:29AM +0900, Minchan Kim wrote:
> > <SNIP>
> > @@ -533,8 +544,14 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
> > unsigned long nr_migrate, nr_remaining;
> > int err;
> >
> > - if (!isolate_migratepages(zone, cc))
> > + switch (isolate_migratepages(zone, cc)) {
> > + case ISOLATE_ABORT:
>
> In this case, you change old behavior slightly.
> In old case, we return COMPACT_PARTIAL to cancel migration.
> But this patch makes to return COMPACT_SUCCESS.
> At present, return value of compact_zone is only used by __alloc_pages_direct_compact
> and it only consider COMPACT_SKIPPED so it would be not a problem.
> But I think it would be better to return COMPACT_PARTIAL instead of COMPACT_CONTINUE
> for consistency with compact_finished and right semantic for the future user of compact_zone.
>
Agreed. Thanks.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-07 16:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 15:07 [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting Mel Gorman
2011-06-07 15:07 ` Mel Gorman
2011-06-07 15:07 ` [PATCH 1/4] mm: compaction: Ensure that the compaction free scanner does not move to the next zone Mel Gorman
2011-06-07 15:07 ` Mel Gorman
2011-06-08 9:33 ` Michal Hocko
2011-06-08 9:33 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 2/4] mm: vmscan: Do not use page_count without a page pin Mel Gorman
2011-06-07 15:07 ` Mel Gorman
2011-06-07 15:12 ` Minchan Kim
2011-06-07 15:12 ` Minchan Kim
2011-06-08 9:38 ` Michal Hocko
2011-06-08 9:38 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 3/4] mm: memory-failure: Fix isolated page count during memory failure Mel Gorman
2011-06-07 15:07 ` Mel Gorman
2011-06-07 15:14 ` Minchan Kim
2011-06-07 15:14 ` Minchan Kim
2011-06-08 10:07 ` Michal Hocko
2011-06-08 10:07 ` Michal Hocko
2011-06-08 10:11 ` Michal Hocko
2011-06-08 10:11 ` Michal Hocko
2011-06-07 15:07 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous Mel Gorman
2011-06-07 15:07 ` Mel Gorman
2011-06-07 15:50 ` Minchan Kim
2011-06-07 15:50 ` Minchan Kim
2011-06-07 16:26 ` Mel Gorman [this message]
2011-06-07 16:26 ` Mel Gorman
2011-06-07 16:27 ` [PATCH 4/4] mm: compaction: Abort compaction if too many pages are isolated and caller is asynchronous V2 Mel Gorman
2011-06-07 16:27 ` Mel Gorman
2011-06-07 16:36 ` Minchan Kim
2011-06-07 16:36 ` Minchan Kim
2011-06-08 9:55 ` Michal Hocko
2011-06-08 9:55 ` Michal Hocko
2011-07-17 8:52 ` [PATCH 0/4] Fix compaction stalls due to accounting errors in isolated page accounting Thomas Sattler
2011-07-17 8:52 ` Thomas Sattler
2011-07-19 9:16 ` Mel Gorman
2011-07-19 9:16 ` Mel Gorman
2011-07-19 11:24 ` Thomas Sattler
2011-07-19 11:24 ` Thomas Sattler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607162654.GN5247@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=tsattler@gmx.de \
--cc=urykhy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.