From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3 2/2] dt: add custom device creation to platform bus scan
Date: Wed, 8 Jun 2011 08:16:00 +0200 [thread overview]
Message-ID: <201106080816.00565.arnd@arndb.de> (raw)
In-Reply-To: <4DEEE8AF.50603@gmail.com>
On Wednesday 08 June 2011 05:12:47 Rob Herring wrote:
> The simplest solutions are usually the best. With that, the 2nd patch
> becomes:
>
> static int of_dev_node_match(struct device *dev, void *data)
> {
> @@ -234,6 +235,11 @@ static int of_platform_bus_create(struct
> device_node *bus,
> return 0;
> }
>
> + if (of_device_is_compatible(bus, "arm,amba-device")) {
> + of_amba_device_create(bus, parent);
> + return 0;
> + }
> +
Sounds good to me, just remind me what of_amba_device_create does when
amba is disabled. I guess it should do nothing in that case, there
can be no amba drivers loaded, so the device is clearly not needed.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Jeremy Kerr <jeremy.kerr-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH v3 2/2] dt: add custom device creation to platform bus scan
Date: Wed, 8 Jun 2011 08:16:00 +0200 [thread overview]
Message-ID: <201106080816.00565.arnd@arndb.de> (raw)
In-Reply-To: <4DEEE8AF.50603-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wednesday 08 June 2011 05:12:47 Rob Herring wrote:
> The simplest solutions are usually the best. With that, the 2nd patch
> becomes:
>
> static int of_dev_node_match(struct device *dev, void *data)
> {
> @@ -234,6 +235,11 @@ static int of_platform_bus_create(struct
> device_node *bus,
> return 0;
> }
>
> + if (of_device_is_compatible(bus, "arm,amba-device")) {
> + of_amba_device_create(bus, parent);
> + return 0;
> + }
> +
Sounds good to me, just remind me what of_amba_device_create does when
amba is disabled. I guess it should do nothing in that case, there
can be no amba drivers loaded, so the device is clearly not needed.
Arnd
next prev parent reply other threads:[~2011-06-08 6:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 21:31 [RFC PATCH v3 0/2] amba bus device tree probing Rob Herring
2011-05-25 21:31 ` Rob Herring
2011-05-25 21:31 ` [RFC PATCH v3 1/2] drivers/amba: create devices from device tree Rob Herring
2011-05-25 21:31 ` Rob Herring
2011-05-26 7:41 ` Linus Walleij
2011-05-26 7:41 ` Linus Walleij
2011-05-25 21:31 ` [RFC PATCH v3 2/2] dt: add custom device creation to platform bus scan Rob Herring
2011-05-25 21:31 ` Rob Herring
2011-05-26 13:11 ` Arnd Bergmann
2011-05-26 13:11 ` Arnd Bergmann
2011-05-26 18:43 ` Rob Herring
2011-05-26 18:43 ` Rob Herring
2011-05-27 12:06 ` Arnd Bergmann
2011-05-27 12:06 ` Arnd Bergmann
2011-06-01 16:52 ` Rob Herring
2011-06-01 16:52 ` Rob Herring
2011-06-01 16:58 ` Grant Likely
2011-06-01 16:58 ` Grant Likely
2011-06-01 21:29 ` Arnd Bergmann
2011-06-01 21:29 ` Arnd Bergmann
2011-06-08 3:12 ` Rob Herring
2011-06-08 3:12 ` Rob Herring
2011-06-08 6:16 ` Arnd Bergmann [this message]
2011-06-08 6:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106080816.00565.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.