From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mathias Krause <minipli@googlemail.com>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] init: use KERNEL_DS when trying to start init process
Date: Wed, 8 Jun 2011 11:47:27 +0100 [thread overview]
Message-ID: <20110608104727.GT11521@ZenIV.linux.org.uk> (raw)
In-Reply-To: <BANLkTinwMyVsR-pvimeVkcqQrCuNDK4zKw@mail.gmail.com>
On Tue, Jun 07, 2011 at 07:00:24PM -0700, Linus Torvalds wrote:
> That said, that commit (it's commit ID 4095b99c09e3d in tglx's tree)
> predates the "real" BK history too: it's part of the (limited) 2.4.x
> history that was imported from the release patches into BK at the
> beginning of the use of BK. So at that point we didn't do indivual
> commits, it's just the import of the v2.4.3.7 -> v2.4.3.8 patch.
>
> But yeah, it's old and crufty. And I agree that usually the correct
> fix is to remove the set_fs() calls entirely.
I think these days its job is done by start_thread(), which is where we
switch to USER_DS; it's called by ->load_binary() when it decides it's past
the point of no return. However, it would be a good idea to verify that
all architectures do it there properly and we are not exposing a hole by
removal of this set_fs()...
next prev parent reply other threads:[~2011-06-08 10:47 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 16:17 [PATCH] init: use KERNEL_DS when trying to start init process Mathias Krause
2011-06-06 23:12 ` Andrew Morton
2011-06-07 6:49 ` Mathias Krause
2011-06-08 2:00 ` Linus Torvalds
2011-06-08 8:23 ` Mathias Krause
2011-06-08 10:47 ` Al Viro [this message]
2011-06-08 12:14 ` Mathias Krause
2011-06-08 14:03 ` Al Viro
2011-06-08 20:20 ` Chris Metcalf
2011-06-09 8:14 ` Mathias Krause
2011-06-09 10:40 ` Al Viro
2011-06-09 12:06 ` Mathias Krause
2011-06-09 15:56 ` Linus Torvalds
2011-06-09 16:40 ` Mathias Krause
2011-06-09 17:03 ` Linus Torvalds
2011-06-09 18:05 ` Mathias Krause
2011-06-09 22:56 ` [PATCH] init: use KERNEL_DS when trying to start init process Andrew Morton
2011-06-10 8:11 ` Mathias Krause
2011-06-10 13:08 ` [PATCH] alpha, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:08 ` [PATCH] arm, " Mathias Krause
2011-06-10 13:08 ` Mathias Krause
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:53 ` Mathias Krause
2011-06-10 13:53 ` Mathias Krause
2011-06-27 4:29 ` Mathias Krause
2011-06-27 4:29 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] avr32, " Mathias Krause
2011-06-14 11:28 ` Hans-Christian Egtvedt
2011-06-10 13:09 ` [PATCH] blackfin, " Mathias Krause
2011-06-10 14:17 ` Mike Frysinger
2011-06-10 13:09 ` [PATCH] cris, " Mathias Krause
2011-06-10 13:09 ` [PATCH] frv, " Mathias Krause
2011-06-10 13:09 ` [PATCH] h8300, " Mathias Krause
2011-06-10 13:09 ` [PATCH] ia64, " Mathias Krause
2011-06-10 13:09 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] m32r, " Mathias Krause
2011-06-10 13:09 ` [PATCH] m68k, " Mathias Krause
2011-06-15 14:40 ` Geert Uytterhoeven
2011-06-15 14:40 ` Geert Uytterhoeven
2011-06-15 15:49 ` Mathias Krause
2011-06-15 15:49 ` Mathias Krause
2011-06-10 13:09 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] microblaze, " Mathias Krause
2011-07-05 11:45 ` Michal Simek
2011-06-10 13:10 ` [PATCH] mips, exec: remove redundant addr_limit assignment Mathias Krause
2011-06-10 13:10 ` [PATCH] mn10300, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:10 ` [PATCH] parisc, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] ppc, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] s390, " Mathias Krause
2011-06-10 13:10 ` [PATCH] sh, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-14 6:33 ` Paul Mundt
2011-06-14 6:33 ` Paul Mundt
2011-06-10 13:10 ` [PATCH] sparc, exec: remove redundant addr_limit assignment Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-11 23:08 ` David Miller
2011-06-11 23:08 ` David Miller
2011-06-11 23:44 ` Al Viro
2011-06-11 23:44 ` Al Viro
2011-06-12 0:58 ` David Miller
2011-06-12 0:58 ` David Miller
2011-06-12 1:01 ` Linus Torvalds
2011-06-12 1:01 ` Linus Torvalds
2011-06-12 1:04 ` David Miller
2011-06-12 1:04 ` David Miller
2011-06-13 20:28 ` Mathias Krause
2011-06-13 20:28 ` Mathias Krause
2011-06-17 18:45 ` Mathias Krause
2011-06-17 18:45 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] um, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 20:00 ` [uml-devel] " Richard Weinberger
2011-06-10 20:00 ` Richard Weinberger
2011-06-10 13:11 ` [PATCH] unicore32, " Mathias Krause
2011-06-13 9:19 ` Guan Xuetao
2011-06-13 16:02 ` Mathias Krause
2011-06-14 7:03 ` Guan Xuetao
2011-06-10 15:52 ` [PATCH] init: use KERNEL_DS when trying to start init process Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608104727.GT11521@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minipli@googlemail.com \
--cc=rusty@rustcorp.com.au \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.