From: Michal Simek <monstr@monstr.eu>
To: Mathias Krause <minipli@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] microblaze, exec: remove redundant set_fs(USER_DS)
Date: Tue, 05 Jul 2011 13:45:06 +0200 [thread overview]
Message-ID: <4E12F942.90504@monstr.eu> (raw)
In-Reply-To: <1307711399-7929-1-git-send-email-minipli@googlemail.com>
Mathias Krause wrote:
> The address limit is already set in flush_old_exec() so this
> set_fs(USER_DS) is redundant.
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
> arch/microblaze/kernel/process.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/microblaze/kernel/process.c b/arch/microblaze/kernel/process.c
> index 968648a..dbb8124 100644
> --- a/arch/microblaze/kernel/process.c
> +++ b/arch/microblaze/kernel/process.c
> @@ -237,7 +237,6 @@ unsigned long get_wchan(struct task_struct *p)
> /* Set up a thread for executing a new program */
> void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long usp)
> {
> - set_fs(USER_DS);
> regs->pc = pc;
> regs->r1 = usp;
> regs->pt_mode = 0;
Andrew has added it to his queue. I have tested and applied too.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next prev parent reply other threads:[~2011-07-05 11:45 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 16:17 [PATCH] init: use KERNEL_DS when trying to start init process Mathias Krause
2011-06-06 23:12 ` Andrew Morton
2011-06-07 6:49 ` Mathias Krause
2011-06-08 2:00 ` Linus Torvalds
2011-06-08 8:23 ` Mathias Krause
2011-06-08 10:47 ` Al Viro
2011-06-08 12:14 ` Mathias Krause
2011-06-08 14:03 ` Al Viro
2011-06-08 20:20 ` Chris Metcalf
2011-06-09 8:14 ` Mathias Krause
2011-06-09 10:40 ` Al Viro
2011-06-09 12:06 ` Mathias Krause
2011-06-09 15:56 ` Linus Torvalds
2011-06-09 16:40 ` Mathias Krause
2011-06-09 17:03 ` Linus Torvalds
2011-06-09 18:05 ` Mathias Krause
2011-06-09 22:56 ` [PATCH] init: use KERNEL_DS when trying to start init process Andrew Morton
2011-06-10 8:11 ` Mathias Krause
2011-06-10 13:08 ` [PATCH] alpha, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:08 ` [PATCH] arm, " Mathias Krause
2011-06-10 13:08 ` Mathias Krause
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:48 ` Russell King - ARM Linux
2011-06-10 13:53 ` Mathias Krause
2011-06-10 13:53 ` Mathias Krause
2011-06-27 4:29 ` Mathias Krause
2011-06-27 4:29 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] avr32, " Mathias Krause
2011-06-14 11:28 ` Hans-Christian Egtvedt
2011-06-10 13:09 ` [PATCH] blackfin, " Mathias Krause
2011-06-10 14:17 ` Mike Frysinger
2011-06-10 13:09 ` [PATCH] cris, " Mathias Krause
2011-06-10 13:09 ` [PATCH] frv, " Mathias Krause
2011-06-10 13:09 ` [PATCH] h8300, " Mathias Krause
2011-06-10 13:09 ` [PATCH] ia64, " Mathias Krause
2011-06-10 13:09 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] m32r, " Mathias Krause
2011-06-10 13:09 ` [PATCH] m68k, " Mathias Krause
2011-06-10 13:09 ` Mathias Krause
2011-06-15 14:40 ` Geert Uytterhoeven
2011-06-15 14:40 ` Geert Uytterhoeven
2011-06-15 15:49 ` Mathias Krause
2011-06-15 15:49 ` Mathias Krause
2011-06-10 13:09 ` [PATCH] microblaze, " Mathias Krause
2011-07-05 11:45 ` Michal Simek [this message]
2011-06-10 13:10 ` [PATCH] mips, exec: remove redundant addr_limit assignment Mathias Krause
2011-06-10 13:10 ` [PATCH] mn10300, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 13:10 ` [PATCH] parisc, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] ppc, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] s390, " Mathias Krause
2011-06-10 13:10 ` [PATCH] sh, " Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-14 6:33 ` Paul Mundt
2011-06-14 6:33 ` Paul Mundt
2011-06-10 13:10 ` [PATCH] sparc, exec: remove redundant addr_limit assignment Mathias Krause
2011-06-10 13:10 ` Mathias Krause
2011-06-11 23:08 ` David Miller
2011-06-11 23:08 ` David Miller
2011-06-11 23:44 ` Al Viro
2011-06-11 23:44 ` Al Viro
2011-06-12 0:58 ` David Miller
2011-06-12 0:58 ` David Miller
2011-06-12 1:01 ` Linus Torvalds
2011-06-12 1:01 ` Linus Torvalds
2011-06-12 1:04 ` David Miller
2011-06-12 1:04 ` David Miller
2011-06-13 20:28 ` Mathias Krause
2011-06-13 20:28 ` Mathias Krause
2011-06-17 18:45 ` Mathias Krause
2011-06-17 18:45 ` Mathias Krause
2011-06-10 13:10 ` [PATCH] um, exec: remove redundant set_fs(USER_DS) Mathias Krause
2011-06-10 20:00 ` [uml-devel] " Richard Weinberger
2011-06-10 20:00 ` Richard Weinberger
2011-06-10 13:11 ` [PATCH] unicore32, " Mathias Krause
2011-06-13 9:19 ` Guan Xuetao
2011-06-13 16:02 ` Mathias Krause
2011-06-14 7:03 ` Guan Xuetao
2011-06-10 15:52 ` [PATCH] init: use KERNEL_DS when trying to start init process Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E12F942.90504@monstr.eu \
--to=monstr@monstr.eu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=minipli@googlemail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.