From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v3 05/10] vmscan: make isolate_lru_page with filter aware
Date: Thu, 9 Jun 2011 15:04:53 +0100 [thread overview]
Message-ID: <20110609140453.GX5247@suse.de> (raw)
In-Reply-To: <f101a50f11ffac79eff441c58eafbb5eceac0b47.1307455422.git.minchan.kim@gmail.com>
On Tue, Jun 07, 2011 at 11:38:18PM +0900, Minchan Kim wrote:
> In __zone_reclaim case, we don't want to shrink mapped page.
> Nonetheless, we have isolated mapped page and re-add it into
> LRU's head. It's unnecessary CPU overhead and makes LRU churning.
>
Gack, I should have keep reading. I didn't cop from the subject that
__zone_reclaim would be updated. Still, it would have been easier to
review if one patch introduced ISOLATE_CLEAN and updated the callers and
this patch introduced ISOLATE_UNMAPPED and updated the relevant callers.
> <SNIP>
--
Mel Gorman
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v3 05/10] vmscan: make isolate_lru_page with filter aware
Date: Thu, 9 Jun 2011 15:04:53 +0100 [thread overview]
Message-ID: <20110609140453.GX5247@suse.de> (raw)
In-Reply-To: <f101a50f11ffac79eff441c58eafbb5eceac0b47.1307455422.git.minchan.kim@gmail.com>
On Tue, Jun 07, 2011 at 11:38:18PM +0900, Minchan Kim wrote:
> In __zone_reclaim case, we don't want to shrink mapped page.
> Nonetheless, we have isolated mapped page and re-add it into
> LRU's head. It's unnecessary CPU overhead and makes LRU churning.
>
Gack, I should have keep reading. I didn't cop from the subject that
__zone_reclaim would be updated. Still, it would have been easier to
review if one patch introduced ISOLATE_CLEAN and updated the callers and
this patch introduced ISOLATE_UNMAPPED and updated the relevant callers.
> <SNIP>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-09 14:04 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 14:38 [PATCH v3 00/10] Prevent LRU churning Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 01/10] compaction: trivial clean up acct_isolated Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 13:33 ` Mel Gorman
2011-06-09 13:33 ` Mel Gorman
2011-06-09 14:41 ` Minchan Kim
2011-06-09 14:41 ` Minchan Kim
2011-06-09 14:47 ` Mel Gorman
2011-06-09 14:47 ` Mel Gorman
2011-06-10 8:19 ` KOSAKI Motohiro
2011-06-10 8:19 ` KOSAKI Motohiro
2011-06-12 14:24 ` Michal Hocko
2011-06-12 14:24 ` Michal Hocko
2011-06-13 14:48 ` Minchan Kim
2011-06-13 14:48 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 02/10] Change isolate mode from int type to enum type Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 13:51 ` Mel Gorman
2011-06-09 13:51 ` Mel Gorman
2011-06-09 14:56 ` Minchan Kim
2011-06-09 14:56 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 03/10] Add additional isolation mode Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 13:59 ` Mel Gorman
2011-06-09 13:59 ` Mel Gorman
2011-06-09 15:00 ` Minchan Kim
2011-06-09 15:00 ` Minchan Kim
2011-06-12 14:45 ` Michal Hocko
2011-06-12 14:45 ` Michal Hocko
2011-06-13 14:54 ` Minchan Kim
2011-06-13 14:54 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 04/10] compaction: make isolate_lru_page with filter aware Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 14:03 ` Mel Gorman
2011-06-09 14:03 ` Mel Gorman
2011-06-12 14:49 ` Michal Hocko
2011-06-12 14:49 ` Michal Hocko
2011-06-07 14:38 ` [PATCH v3 05/10] vmscan: " Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 14:04 ` Mel Gorman [this message]
2011-06-09 14:04 ` Mel Gorman
2011-06-09 15:02 ` Minchan Kim
2011-06-09 15:02 ` Minchan Kim
2011-06-12 14:55 ` Michal Hocko
2011-06-12 14:55 ` Michal Hocko
2011-06-13 1:04 ` KOSAKI Motohiro
2011-06-13 1:04 ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 06/10] In order putback lru core Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-09 14:27 ` Mel Gorman
2011-06-09 14:27 ` Mel Gorman
2011-06-09 15:15 ` Minchan Kim
2011-06-09 15:15 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 07/10] migration: clean up unmap_and_move Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-13 1:34 ` KOSAKI Motohiro
2011-06-13 1:34 ` KOSAKI Motohiro
2011-06-07 14:38 ` [PATCH v3 08/10] migration: make in-order-putback aware Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 09/10] compaction: make compaction use in-order putback Minchan Kim
2011-06-07 14:38 ` Minchan Kim
2011-06-07 14:38 ` [PATCH v3 10/10] add inorder-lru tracepoints for just measurement Minchan Kim
2011-06-07 14:38 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609140453.GX5247@suse.de \
--to=mgorman@suse.de \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.