* [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register
@ 2011-06-10 1:36 Sangbeom Kim
2011-06-10 5:41 ` Jassi Brar
2011-06-10 9:54 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Sangbeom Kim @ 2011-06-10 1:36 UTC (permalink / raw)
To: alsa-devel; +Cc: Sangbeom Kim, jassisinghbrar, broonie, lrg
If DMA active status should be checked, I2SCON register should be referenced.
In this patch, Fix the incorrect referencing of I2SCON register.
Reported-by : Lakkyung Jung <lakkyung.jung@samsung.com>
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
sound/soc/samsung/i2s.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index ffa09b3..992a732 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -191,7 +191,7 @@ static inline bool tx_active(struct i2s_dai *i2s)
if (!i2s)
return false;
- active = readl(i2s->addr + I2SMOD);
+ active = readl(i2s->addr + I2SCON);
if (is_secondary(i2s))
active &= CON_TXSDMA_ACTIVE;
@@ -223,7 +223,7 @@ static inline bool rx_active(struct i2s_dai *i2s)
if (!i2s)
return false;
- active = readl(i2s->addr + I2SMOD) & CON_RXDMA_ACTIVE;
+ active = readl(i2s->addr + I2SCON) & CON_RXDMA_ACTIVE;
return active ? true : false;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register
2011-06-10 1:36 [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register Sangbeom Kim
@ 2011-06-10 5:41 ` Jassi Brar
2011-06-10 8:26 ` Liam Girdwood
2011-06-10 9:54 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Jassi Brar @ 2011-06-10 5:41 UTC (permalink / raw)
To: Sangbeom Kim; +Cc: alsa-devel, broonie, lrg
On Fri, Jun 10, 2011 at 7:06 AM, Sangbeom Kim <sbkim73@samsung.com> wrote:
> If DMA active status should be checked, I2SCON register should be referenced.
> In this patch, Fix the incorrect referencing of I2SCON register.
>
> Reported-by : Lakkyung Jung <lakkyung.jung@samsung.com>
> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register
2011-06-10 5:41 ` Jassi Brar
@ 2011-06-10 8:26 ` Liam Girdwood
0 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-06-10 8:26 UTC (permalink / raw)
To: Jassi Brar
Cc: Sangbeom Kim, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk
On 10/06/11 06:41, Jassi Brar wrote:
> On Fri, Jun 10, 2011 at 7:06 AM, Sangbeom Kim <sbkim73@samsung.com> wrote:
>> If DMA active status should be checked, I2SCON register should be referenced.
>> In this patch, Fix the incorrect referencing of I2SCON register.
>>
>> Reported-by : Lakkyung Jung <lakkyung.jung@samsung.com>
>> Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
>
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
> ____________________________________
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register
2011-06-10 1:36 [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register Sangbeom Kim
2011-06-10 5:41 ` Jassi Brar
@ 2011-06-10 9:54 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-06-10 9:54 UTC (permalink / raw)
To: Sangbeom Kim; +Cc: alsa-devel, jassisinghbrar, lrg
On Fri, Jun 10, 2011 at 10:36:54AM +0900, Sangbeom Kim wrote:
> If DMA active status should be checked, I2SCON register should be referenced.
> In this patch, Fix the incorrect referencing of I2SCON register.
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-10 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-10 1:36 [PATCH] ASoC: SAMSUNG: Fix the incorrect referencing of I2SCON register Sangbeom Kim
2011-06-10 5:41 ` Jassi Brar
2011-06-10 8:26 ` Liam Girdwood
2011-06-10 9:54 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.