All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [Device-drivers-devel] [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver
Date: Fri, 10 Jun 2011 19:15:38 +0100	[thread overview]
Message-ID: <20110610181538.GS26436@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTi=S2GayUj8-ctjbDOE_bcEb-6GtJQ@mail.gmail.com>

On Fri, Jun 10, 2011 at 02:13:05PM -0400, Mike Frysinger wrote:

> often times, people do have just basic needs, but i see what you mean.
>  i want the base driver to be flexible enough to handle all the base
> changes (diff SPORT num and perhaps addresses), but anything beyond
> that i'd expect someone to write a custom driver.  perhaps renaming
> the Kconfig description to be like "Basic Blackfin connection to XXX
> Codec" would be sufficient ?  and then add a few more details to the
> help text ?

Yes, that's exactly the sort of thing I'd like to see.  It shouldn't be
that big a change to the code, it's more about making it clear that it's
a 90% case driver rather than the only way to connect things up.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [Device-drivers-devel] [alsa-devel] [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver
Date: Fri, 10 Jun 2011 19:15:38 +0100	[thread overview]
Message-ID: <20110610181538.GS26436@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTi=S2GayUj8-ctjbDOE_bcEb-6GtJQ@mail.gmail.com>

On Fri, Jun 10, 2011 at 02:13:05PM -0400, Mike Frysinger wrote:

> often times, people do have just basic needs, but i see what you mean.
>  i want the base driver to be flexible enough to handle all the base
> changes (diff SPORT num and perhaps addresses), but anything beyond
> that i'd expect someone to write a custom driver.  perhaps renaming
> the Kconfig description to be like "Basic Blackfin connection to XXX
> Codec" would be sufficient ?  and then add a few more details to the
> help text ?

Yes, that's exactly the sort of thing I'd like to see.  It shouldn't be
that big a change to the code, it's more about making it clear that it's
a 90% case driver rather than the only way to connect things up.

  reply	other threads:[~2011-06-10 18:15 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 17:18 [PATCH 1/3] ASoC: Add ADAU1701 codec driver Lars-Peter Clausen
2011-06-10 17:18 ` [PATCH 2/3] ASoC: Blackfin: Add bf5xx-adau1701 machine driver Lars-Peter Clausen
2011-06-10 17:18   ` Lars-Peter Clausen
2011-06-10 17:30   ` Mark Brown
2011-06-10 17:30     ` [alsa-devel] " Mark Brown
2011-06-10 17:47     ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:47       ` [Device-drivers-devel] [alsa-devel] " Mike Frysinger
2011-06-10 18:01       ` [Device-drivers-devel] " Mark Brown
2011-06-10 18:01         ` [Device-drivers-devel] [alsa-devel] " Mark Brown
2011-06-10 18:13         ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 18:13           ` [Device-drivers-devel] [alsa-devel] " Mike Frysinger
2011-06-10 18:15           ` Mark Brown [this message]
2011-06-10 18:15             ` Mark Brown
2011-06-10 17:50     ` Lars-Peter Clausen
2011-06-10 17:50       ` [alsa-devel] " Lars-Peter Clausen
2011-06-10 18:02       ` Mark Brown
2011-06-10 18:02         ` [alsa-devel] " Mark Brown
2011-06-10 18:13         ` Lars-Peter Clausen
2011-06-10 18:13           ` [alsa-devel] " Lars-Peter Clausen
2011-06-10 18:20           ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 18:20             ` [Device-drivers-devel] [alsa-devel] " Mike Frysinger
2011-06-10 17:18 ` [PATCH 3/3] Blackfin: bf537: Stamp: Register adau1701 codec and ASoC " Lars-Peter Clausen
2011-06-10 17:18   ` Lars-Peter Clausen
2011-06-10 17:50   ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:50     ` Mike Frysinger
2011-06-10 17:27 ` [PATCH 1/3] ASoC: Add ADAU1701 codec driver Mark Brown
2011-06-10 17:27   ` [alsa-devel] " Mark Brown
2011-06-10 17:44   ` Mike Frysinger
2011-06-10 17:44     ` [alsa-devel] " Mike Frysinger
2011-06-10 18:07     ` Mark Brown
2011-06-10 18:07       ` [alsa-devel] " Mark Brown
2011-06-10 18:08       ` Mike Frysinger
2011-06-10 18:08         ` [alsa-devel] " Mike Frysinger
2011-06-10 17:43 ` [Device-drivers-devel] " Mike Frysinger
2011-06-10 17:43   ` Mike Frysinger
2011-06-10 17:57   ` Lars-Peter Clausen
2011-06-10 17:57     ` Lars-Peter Clausen
2011-06-10 18:08     ` Mike Frysinger
2011-06-10 18:08       ` Mike Frysinger
2011-06-10 18:15       ` Mike Frysinger
2011-06-10 18:15         ` Mike Frysinger
2011-06-10 18:22         ` Lars-Peter Clausen
2011-06-10 18:22           ` Lars-Peter Clausen
2011-06-10 18:28           ` Mike Frysinger
2011-06-10 18:28             ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610181538.GS26436@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.