From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] dt: check root nodes for match on of_platform_populate
Date: Fri, 10 Jun 2011 23:06:48 +0200 [thread overview]
Message-ID: <201106102306.48426.arnd@arndb.de> (raw)
In-Reply-To: <1307738923-7564-2-git-send-email-robherring2@gmail.com>
On Friday 10 June 2011 22:48:40 Rob Herring wrote:
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 9b785be..dc56a77 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -318,6 +318,8 @@ int of_platform_populate(struct device_node *root,
> return -EINVAL;
>
> for_each_child_of_node(root, child) {
> + if (!of_match_node(matches, child))
> + continue;
> rc = of_platform_bus_create(child, matches, parent, true);
> if (rc)
> break;
Why doesn't of_platform_populate just call of_platform_bus_create on the
root node? That should normally take care of matching all children.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 1/4] dt: check root nodes for match on of_platform_populate
Date: Fri, 10 Jun 2011 23:06:48 +0200 [thread overview]
Message-ID: <201106102306.48426.arnd@arndb.de> (raw)
In-Reply-To: <1307738923-7564-2-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Friday 10 June 2011 22:48:40 Rob Herring wrote:
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 9b785be..dc56a77 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -318,6 +318,8 @@ int of_platform_populate(struct device_node *root,
> return -EINVAL;
>
> for_each_child_of_node(root, child) {
> + if (!of_match_node(matches, child))
> + continue;
> rc = of_platform_bus_create(child, matches, parent, true);
> if (rc)
> break;
Why doesn't of_platform_populate just call of_platform_bus_create on the
root node? That should normally take care of matching all children.
Arnd
next prev parent reply other threads:[~2011-06-10 21:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 20:48 [PATCH v4 0/4] amba bus devicetree probing Rob Herring
2011-06-10 20:48 ` Rob Herring
2011-06-10 20:48 ` [PATCH v4 1/4] dt: check root nodes for match on of_platform_populate Rob Herring
2011-06-10 20:48 ` Rob Herring
2011-06-10 21:06 ` Arnd Bergmann [this message]
2011-06-10 21:06 ` Arnd Bergmann
2011-06-10 21:11 ` Grant Likely
2011-06-10 21:11 ` Grant Likely
2011-06-10 21:17 ` Arnd Bergmann
2011-06-10 21:17 ` Arnd Bergmann
2011-06-10 21:13 ` Grant Likely
2011-06-10 21:13 ` Grant Likely
2011-06-10 20:48 ` [PATCH v4 2/4] dt: add EXPORT_SYMBOL to of_platform_populate Rob Herring
2011-06-10 20:48 ` Rob Herring
2011-06-10 21:37 ` Grant Likely
2011-06-10 21:37 ` Grant Likely
2011-06-10 22:44 ` Rob Herring
2011-06-10 22:44 ` Rob Herring
2011-06-10 23:12 ` Grant Likely
2011-06-10 23:12 ` Grant Likely
2011-06-10 20:48 ` [PATCH v4 3/4] drivers/amba: create devices from device tree Rob Herring
2011-06-10 20:48 ` Rob Herring
2011-06-10 21:04 ` Arnd Bergmann
2011-06-10 21:04 ` Arnd Bergmann
2011-06-10 22:30 ` Grant Likely
2011-06-10 22:30 ` Grant Likely
2011-06-10 22:22 ` Grant Likely
2011-06-10 22:22 ` Grant Likely
2011-06-10 22:37 ` Rob Herring
2011-06-10 22:37 ` Rob Herring
2011-06-10 23:11 ` Grant Likely
2011-06-10 23:11 ` Grant Likely
2011-06-10 20:48 ` [PATCH v4 4/4] dt: add amba device creation to platform bus scan Rob Herring
2011-06-10 20:48 ` Rob Herring
2011-06-10 21:02 ` Arnd Bergmann
2011-06-10 21:02 ` Arnd Bergmann
2011-06-10 22:39 ` Grant Likely
2011-06-10 22:39 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106102306.48426.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.