From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss
Date: Mon, 13 Jun 2011 03:47:57 -0700 [thread overview]
Message-ID: <20110613104757.GE10951@atomide.com> (raw)
In-Reply-To: <1307858800-16712-4-git-send-email-nicolas.pitre@linaro.org>
* Nicolas Pitre <nicolas.pitre@linaro.org> [110611 23:03]:
> The appended DTB gets relocated with the decompressor code to get out
> of the way of the decompressed kernel. However the .bss section may
> be larger than the relocated code and data, therefore overwriting the
> DTB. Let's make sure the relocation takes care of moving zImage so
> no conflict with .bss occurs.
>
> Thanks to Tony Lindgren <tony@atomide.com> for figuring out this issue.
>
> While at it, let's clean up the code a bit so that the wont_overwrite
> symbol is used while determining if a conflict exists, making the above
> change more precise as well as eliminating some ARM/THUMB alternates.
>
> Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Great, this simplifies things:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: John Bonesio <bones@secretlab.ca>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss
Date: Mon, 13 Jun 2011 03:47:57 -0700 [thread overview]
Message-ID: <20110613104757.GE10951@atomide.com> (raw)
In-Reply-To: <1307858800-16712-4-git-send-email-nicolas.pitre@linaro.org>
* Nicolas Pitre <nicolas.pitre@linaro.org> [110611 23:03]:
> The appended DTB gets relocated with the decompressor code to get out
> of the way of the decompressed kernel. However the .bss section may
> be larger than the relocated code and data, therefore overwriting the
> DTB. Let's make sure the relocation takes care of moving zImage so
> no conflict with .bss occurs.
>
> Thanks to Tony Lindgren <tony@atomide.com> for figuring out this issue.
>
> While at it, let's clean up the code a bit so that the wont_overwrite
> symbol is used while determining if a conflict exists, making the above
> change more precise as well as eliminating some ARM/THUMB alternates.
>
> Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Great, this simplifies things:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2011-06-13 10:47 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 6:06 [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage Nicolas Pitre
2011-06-12 6:06 ` Nicolas Pitre
2011-06-12 6:06 ` [PATCH 1/3] ARM: zImage: ensure it is always a multiple of 64 bits in size Nicolas Pitre
2011-06-12 6:06 ` Nicolas Pitre
2011-06-13 10:43 ` Tony Lindgren
2011-06-13 10:43 ` Tony Lindgren
2011-06-13 11:24 ` Russell King - ARM Linux
2011-06-13 11:24 ` Russell King - ARM Linux
2011-06-13 14:06 ` Nicolas Pitre
2011-06-13 14:06 ` Nicolas Pitre
2011-06-12 6:06 ` [PATCH 2/3] ARM: zImage: Allow the appending of a device tree binary Nicolas Pitre
2011-06-12 6:06 ` Nicolas Pitre
2011-06-12 15:01 ` Grant Likely
2011-06-12 15:01 ` Grant Likely
2011-06-13 10:46 ` Tony Lindgren
2011-06-13 10:46 ` Tony Lindgren
2011-06-13 11:26 ` Russell King - ARM Linux
2011-06-13 11:26 ` Russell King - ARM Linux
2011-06-13 14:08 ` Nicolas Pitre
2011-06-13 14:08 ` Nicolas Pitre
2011-06-12 6:06 ` [PATCH 3/3] ARM: zImage: make sure appended DTB doesn't get overwritten by kernel .bss Nicolas Pitre
2011-06-12 6:06 ` Nicolas Pitre
2011-06-13 10:47 ` Tony Lindgren [this message]
2011-06-13 10:47 ` Tony Lindgren
2011-06-12 8:15 ` [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage Russell King - ARM Linux
2011-06-12 8:15 ` Russell King - ARM Linux
2011-06-12 8:34 ` Shawn Guo
2011-06-12 8:34 ` Shawn Guo
2011-06-12 9:21 ` Russell King - ARM Linux
2011-06-12 9:21 ` Russell King - ARM Linux
2011-06-12 9:38 ` Shawn Guo
2011-06-12 9:38 ` Shawn Guo
2011-06-12 9:52 ` Russell King - ARM Linux
2011-06-12 9:52 ` Russell King - ARM Linux
2011-06-12 10:42 ` Shawn Guo
2011-06-12 10:42 ` Shawn Guo
2011-06-12 10:40 ` Russell King - ARM Linux
2011-06-12 10:40 ` Russell King - ARM Linux
2011-06-13 20:19 ` Dmitry Eremin-Solenikov
2011-06-13 23:04 ` David Brown
2011-06-13 23:04 ` David Brown
2011-06-13 23:13 ` Nicolas Pitre
2011-06-13 23:13 ` Nicolas Pitre
2011-06-14 7:09 ` Nicolas Pitre
2011-06-14 7:09 ` Nicolas Pitre
2011-06-14 11:25 ` Shawn Guo
2011-06-14 11:25 ` Shawn Guo
2011-06-14 14:53 ` Tony Lindgren
2011-06-14 14:53 ` Tony Lindgren
2011-06-14 17:28 ` Nicolas Pitre
2011-06-14 17:28 ` Nicolas Pitre
2011-06-14 20:32 ` Arnd Bergmann
2011-06-14 20:32 ` Arnd Bergmann
2011-06-14 21:21 ` Nicolas Pitre
2011-06-14 21:21 ` Nicolas Pitre
2011-06-14 21:42 ` Arnd Bergmann
2011-06-14 21:42 ` Arnd Bergmann
2011-06-14 22:06 ` Grant Likely
2011-06-14 22:06 ` Grant Likely
2011-06-15 8:08 ` Tony Lindgren
2011-06-15 8:08 ` Tony Lindgren
2011-06-14 22:32 ` Rob Herring
2011-06-14 22:32 ` Rob Herring
2011-06-14 23:50 ` Nicolas Pitre
2011-06-14 23:50 ` Nicolas Pitre
2011-06-15 2:09 ` Rob Herring
2011-06-15 2:09 ` Rob Herring
2011-06-15 2:21 ` Nicolas Pitre
2011-06-15 2:21 ` Nicolas Pitre
2011-06-14 21:38 ` David Brown
2011-06-14 21:38 ` David Brown
2011-06-14 23:27 ` [PATCH] Support multiple MEM tags with atags->fdt conversion David Brown
2011-06-14 23:27 ` David Brown
2011-06-15 19:50 ` Nicolas Pitre
2011-06-15 19:50 ` Nicolas Pitre
2011-06-15 20:15 ` David Brown
2011-06-15 20:15 ` David Brown
2011-06-15 20:20 ` Nicolas Pitre
2011-06-15 20:20 ` Nicolas Pitre
2011-06-16 1:43 ` David Gibson
2011-06-16 1:43 ` David Gibson
2011-06-20 4:03 ` Nicolas Pitre
2011-06-20 4:03 ` Nicolas Pitre
2011-06-20 4:53 ` David Gibson
2011-06-20 4:53 ` David Gibson
2011-06-17 20:23 ` David Brown
2011-06-17 20:23 ` David Brown
2011-06-12 11:22 ` [PATCH 0/3] patches to allow DTB to be appended to the ARM zImage Petr Štetiar
2011-06-12 11:22 ` Petr Štetiar
2011-06-12 11:58 ` Russell King - ARM Linux
2011-06-12 11:58 ` Russell King - ARM Linux
2011-06-12 14:15 ` Arnd Bergmann
2011-06-12 14:15 ` Arnd Bergmann
2011-06-12 14:34 ` Russell King - ARM Linux
2011-06-12 14:34 ` Russell King - ARM Linux
2011-06-12 15:01 ` Arnd Bergmann
2011-06-12 15:01 ` Arnd Bergmann
2011-06-12 15:35 ` Russell King - ARM Linux
2011-06-12 15:35 ` Russell King - ARM Linux
2011-06-12 15:45 ` Nicolas Pitre
2011-06-12 15:45 ` Nicolas Pitre
2011-06-13 20:24 ` Dmitry Eremin-Solenikov
2011-06-13 22:05 ` Russell King - ARM Linux
2011-06-13 23:33 ` Grant Likely
2011-06-12 14:57 ` Grant Likely
2011-06-12 14:57 ` Grant Likely
2011-06-12 15:19 ` Russell King - ARM Linux
2011-06-12 15:19 ` Russell King - ARM Linux
2011-06-12 15:47 ` Nicolas Pitre
2011-06-12 15:47 ` Nicolas Pitre
2011-06-12 15:59 ` Russell King - ARM Linux
2011-06-12 15:59 ` Russell King - ARM Linux
2011-06-12 18:59 ` Nicolas Pitre
2011-06-12 18:59 ` Nicolas Pitre
2011-06-13 9:51 ` Tony Lindgren
2011-06-13 9:51 ` Tony Lindgren
2011-06-13 14:14 ` Nicolas Pitre
2011-06-13 14:14 ` Nicolas Pitre
2011-06-13 14:20 ` Russell King - ARM Linux
2011-06-13 14:20 ` Russell King - ARM Linux
2011-06-13 15:02 ` Tony Lindgren
2011-06-13 15:02 ` Tony Lindgren
2011-06-13 15:14 ` Nicolas Pitre
2011-06-13 15:14 ` Nicolas Pitre
2011-06-13 15:17 ` Grant Likely
2011-06-13 15:17 ` Grant Likely
2011-06-12 19:26 ` Warner Losh
2011-06-12 19:26 ` Warner Losh
2011-06-13 9:59 ` Tony Lindgren
2011-06-13 9:59 ` Tony Lindgren
2011-06-12 15:41 ` Nicolas Pitre
2011-06-12 15:41 ` Nicolas Pitre
2011-06-14 0:13 ` David Brown
2011-06-14 0:13 ` David Brown
2011-09-06 11:23 ` Linus Walleij
2011-09-06 11:23 ` Linus Walleij
2011-06-21 1:40 ` David Gibson
2011-06-21 1:40 ` David Gibson
2011-06-13 4:31 ` Grant Likely
2011-06-13 4:31 ` Grant Likely
2011-06-13 20:44 ` Nicolas Pitre
2011-06-13 20:44 ` Nicolas Pitre
2011-09-05 15:43 ` Tony Lindgren
2011-09-05 15:43 ` Tony Lindgren
2011-09-05 19:32 ` Nicolas Pitre
2011-09-05 19:32 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613104757.GE10951@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.