All of lore.kernel.org
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS
Date: Mon, 13 Jun 2011 03:49:41 -0700	[thread overview]
Message-ID: <20110613104940.GF10951@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1106120209450.2142@xanadu.home>

* Nicolas Pitre <nico@fluxnic.net> [110611 23:09]:
> On Fri, 13 May 2011, Tony Lindgren wrote:
> 
> > From: Tony Lindgren <tony@atomide.com>
> > Date: Thu, 12 May 2011 05:29:49 -0700
> > Subject: [PATCH] ARM: zImage: Make sure appended device tree data won't overlap kernel BSS
> > 
> > Do this before relocating the compressed kernel + device tree data.
> > Otherwise we would have to split the copying into two parts, or copy
> > the device tree data twice.
> > 
> > As we only have one register available, pass the size of kernel BSS
> > via linker and do the calculation using r1, then save it to the stack.
> > 
> > Note that this patch now makes the stack also usable earlier for
> > CONFIG_ARM_APPENDED_DTB.
> > 
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> [...]
> 
> Please tell me what you think of this alternative: 
> http://article.gmane.org/gmane.linux.ports.arm.kernel/120182
> I think it is a cleaner solution.

Yeah that's nice, I acked that one in the thread.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Nicolas Pitre <nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org>
Cc: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
	devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
	Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS
Date: Mon, 13 Jun 2011 03:49:41 -0700	[thread overview]
Message-ID: <20110613104940.GF10951@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1106120209450.2142-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>

* Nicolas Pitre <nico-vtqb6HGKxmzR7s880joybQ@public.gmane.org> [110611 23:09]:
> On Fri, 13 May 2011, Tony Lindgren wrote:
> 
> > From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> > Date: Thu, 12 May 2011 05:29:49 -0700
> > Subject: [PATCH] ARM: zImage: Make sure appended device tree data won't overlap kernel BSS
> > 
> > Do this before relocating the compressed kernel + device tree data.
> > Otherwise we would have to split the copying into two parts, or copy
> > the device tree data twice.
> > 
> > As we only have one register available, pass the size of kernel BSS
> > via linker and do the calculation using r1, then save it to the stack.
> > 
> > Note that this patch now makes the stack also usable earlier for
> > CONFIG_ARM_APPENDED_DTB.
> > 
> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> [...]
> 
> Please tell me what you think of this alternative: 
> http://article.gmane.org/gmane.linux.ports.arm.kernel/120182
> I think it is a cleaner solution.

Yeah that's nice, I acked that one in the thread.

Regards,

Tony

  reply	other threads:[~2011-06-13 10:49 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 23:18 [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage John Bonesio
2011-03-24 23:18 ` John Bonesio
2011-03-24 23:37 ` Nicolas Pitre
2011-03-24 23:37   ` Nicolas Pitre
2011-03-28  9:13 ` Shawn Guo
2011-03-28  9:13   ` Shawn Guo
2011-04-13 14:00   ` Tony Lindgren
2011-04-13 14:00     ` Tony Lindgren
2011-04-20  5:47     ` Shawn Guo
2011-04-20  5:47       ` Shawn Guo
2011-04-20  7:34       ` Shawn Guo
2011-04-20  7:34         ` Shawn Guo
2011-04-21  8:02         ` Tony Lindgren
2011-04-21  8:02           ` Tony Lindgren
2011-04-21 12:46           ` Tony Lindgren
2011-04-21 12:46             ` Tony Lindgren
2011-04-27 14:23             ` Tony Lindgren
2011-04-27 14:23               ` Tony Lindgren
2011-04-27 14:38               ` Tony Lindgren
2011-04-27 14:38                 ` Tony Lindgren
2011-04-27 14:40               ` Nicolas Pitre
2011-04-27 14:40                 ` Nicolas Pitre
2011-04-27 14:43                 ` Tony Lindgren
2011-04-27 14:43                   ` Tony Lindgren
2011-04-29 10:26                   ` Tony Lindgren
2011-04-29 10:26                     ` Tony Lindgren
2011-04-29 13:02                     ` Grant Likely
2011-04-29 13:02                       ` Grant Likely
2011-04-29 13:08                       ` Grant Likely
2011-04-29 13:08                         ` Grant Likely
2011-04-29 13:09                       ` Tony Lindgren
2011-04-29 13:09                         ` Tony Lindgren
2011-04-29 13:21                         ` Nicolas Pitre
2011-04-29 13:21                           ` Nicolas Pitre
2011-04-29 13:16                     ` Nicolas Pitre
2011-04-29 13:16                       ` Nicolas Pitre
2011-04-29 13:53                       ` Russell King - ARM Linux
2011-04-29 13:53                         ` Russell King - ARM Linux
2011-04-29 19:14                         ` Nicolas Pitre
2011-04-29 19:14                           ` Nicolas Pitre
2011-05-04  7:23                           ` Tony Lindgren
2011-05-04  7:23                             ` Tony Lindgren
2011-05-04 13:12                             ` Tony Lindgren
2011-05-04 13:12                               ` Tony Lindgren
2011-05-04 13:38                             ` Nicolas Pitre
2011-05-04 13:38                               ` Nicolas Pitre
2011-05-09 11:19                               ` [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS Tony Lindgren
2011-05-09 11:19                                 ` Tony Lindgren
2011-05-09 14:49                                 ` Tony Lindgren
2011-05-09 14:49                                   ` Tony Lindgren
2011-05-12 12:59                                   ` Tony Lindgren
2011-05-12 12:59                                     ` Tony Lindgren
2011-05-13  7:39                                     ` Nicolas Pitre
2011-05-13  7:39                                       ` Nicolas Pitre
2011-05-13 11:21                                       ` Tony Lindgren
2011-05-13 11:21                                         ` Tony Lindgren
2011-05-13 13:09                                         ` Nicolas Pitre
2011-05-13 13:09                                           ` Nicolas Pitre
2011-05-13 13:28                                           ` Tony Lindgren
2011-05-13 13:28                                             ` Tony Lindgren
2011-06-07 12:43                                             ` Tony Lindgren
2011-06-07 12:43                                               ` Tony Lindgren
2011-06-07 13:14                                               ` Nicolas Pitre
2011-06-07 13:14                                                 ` Nicolas Pitre
2011-06-07 13:22                                                 ` Tony Lindgren
2011-06-07 13:22                                                   ` Tony Lindgren
2011-06-12  6:14                                         ` Nicolas Pitre
2011-06-12  6:14                                           ` Nicolas Pitre
2011-06-13 10:49                                           ` Tony Lindgren [this message]
2011-06-13 10:49                                             ` Tony Lindgren
2011-05-09 11:23 ` [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage Tony Lindgren
2011-05-09 11:23   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110613104940.GF10951@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.