* [PATCH] efifb: fix device unregister on error path
@ 2011-06-13 11:51 Konstantin Khlebnikov
2011-06-13 13:33 ` Maxin B John
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Khlebnikov @ 2011-06-13 11:51 UTC (permalink / raw)
To: Peter Jones, linux-kernel
Argument of platform_device_unregister() should be efifb_device, not efifb_driver.
bug in v3.0-rc1-57-gbb8b266
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
---
drivers/video/efifb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c
@@ -541,7 +541,7 @@ static int __init efifb_init(void)
*/
ret = platform_driver_probe(&efifb_driver, efifb_probe);
if (ret) {
- platform_device_unregister(&efifb_driver);
+ platform_device_unregister(&efifb_device);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] efifb: fix device unregister on error path
2011-06-13 11:51 [PATCH] efifb: fix device unregister on error path Konstantin Khlebnikov
@ 2011-06-13 13:33 ` Maxin B John
0 siblings, 0 replies; 2+ messages in thread
From: Maxin B John @ 2011-06-13 13:33 UTC (permalink / raw)
To: Konstantin Khlebnikov; +Cc: Peter Jones, linux-kernel
Hi,
On Mon, Jun 13, 2011 at 12:51 PM, Konstantin Khlebnikov
<khlebnikov@openvz.org> wrote:
> Argument of platform_device_unregister() should be efifb_device, not efifb_driver.
> bug in v3.0-rc1-57-gbb8b266
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
> ---
> drivers/video/efifb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
> */
> ret = platform_driver_probe(&efifb_driver, efifb_probe);
> if (ret) {
> - platform_device_unregister(&efifb_driver);
> + platform_device_unregister(&efifb_device);
> return ret;
> }
The same issue is present in this thread:
https://lkml.org/lkml/2011/6/12/34
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-13 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-13 11:51 [PATCH] efifb: fix device unregister on error path Konstantin Khlebnikov
2011-06-13 13:33 ` Maxin B John
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.