Re: [BUGFIX][PATCH 4/5] memcg: fix wrong check of noswap with softlimit

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Johannes Weiner <jweiner@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"bsingharora@gmail.com" <bsingharora@gmail.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Ying Han <yinghan@google.com>
Subject: Re: [BUGFIX][PATCH 4/5] memcg:  fix wrong check of noswap with softlimit
Date: Tue, 14 Jun 2011 11:48:11 +0200	[thread overview]
Message-ID: <20110614094811.GD6371@redhat.com> (raw)
In-Reply-To: <20110613121105.b8f251e2.kamezawa.hiroyu@jp.fujitsu.com>

On Mon, Jun 13, 2011 at 12:11:05PM +0900, KAMEZAWA Hiroyuki wrote:
> >From 0a0358d300330a4ba86e39ea56ed63f1e4519dfd Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Date: Mon, 13 Jun 2011 10:31:16 +0900
> Subject: [PATCH 4/5]  fix wrong check of noswap with softlimit
> 
> Hierarchical reclaim doesn't swap out if memsw and resource limits are
> same (memsw_is_minimum == true) because we would hit mem+swap limit
> anyway (during hard limit reclaim).
> If it comes to the solft limit we shouldn't consider memsw_is_minimum at
> all because it doesn't make much sense. Either the soft limit is bellow
> the hard limit and then we cannot hit mem+swap limit or the direct
> reclaim takes a precedence.
> 
> Reviewed-by: Michal Hocko <mhocko@suse.cz>
> Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Acked-by: Johannes Weiner <jweiner@redhat.com>

WARNING: multiple messages have this Message-ID (diff)

From: Johannes Weiner <jweiner@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"bsingharora@gmail.com" <bsingharora@gmail.com>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Ying Han <yinghan@google.com>
Subject: Re: [BUGFIX][PATCH 4/5] memcg:  fix wrong check of noswap with softlimit
Date: Tue, 14 Jun 2011 11:48:11 +0200	[thread overview]
Message-ID: <20110614094811.GD6371@redhat.com> (raw)
In-Reply-To: <20110613121105.b8f251e2.kamezawa.hiroyu@jp.fujitsu.com>

On Mon, Jun 13, 2011 at 12:11:05PM +0900, KAMEZAWA Hiroyuki wrote:
> >From 0a0358d300330a4ba86e39ea56ed63f1e4519dfd Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Date: Mon, 13 Jun 2011 10:31:16 +0900
> Subject: [PATCH 4/5]  fix wrong check of noswap with softlimit
> 
> Hierarchical reclaim doesn't swap out if memsw and resource limits are
> same (memsw_is_minimum == true) because we would hit mem+swap limit
> anyway (during hard limit reclaim).
> If it comes to the solft limit we shouldn't consider memsw_is_minimum at
> all because it doesn't make much sense. Either the soft limit is bellow
> the hard limit and then we cannot hit mem+swap limit or the direct
> reclaim takes a precedence.
> 
> Reviewed-by: Michal Hocko <mhocko@suse.cz>
> Acked-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Acked-by: Johannes Weiner <jweiner@redhat.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next prev parent reply	other threads:[~2011-06-14  9:49 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13  3:00 [BUGFIX][PATCH 0/5] memcg bugfixes in the last week KAMEZAWA Hiroyuki
2011-06-13  3:00 ` KAMEZAWA Hiroyuki
2011-06-13  3:03 ` [BUGFIX][PATCH 1/5] memcg fix numa_stat permission KAMEZAWA Hiroyuki
2011-06-13  3:03   ` KAMEZAWA Hiroyuki
2011-06-14  9:42   ` Johannes Weiner
2011-06-14  9:42     ` Johannes Weiner
2011-06-13  3:06 ` [BUGFIX][PATCH 2/5] memcg: fix init_page_cgroup nid with sparsemem KAMEZAWA Hiroyuki
2011-06-13  3:06   ` KAMEZAWA Hiroyuki
2011-06-14  9:44   ` Johannes Weiner
2011-06-14  9:44     ` Johannes Weiner
2011-06-16 10:09   ` [-git build bug, PATCH] " Ingo Molnar
2011-06-16 10:09     ` Ingo Molnar
2011-06-16 13:01     ` Hiroyuki Kamezawa
2011-06-16 13:01       ` Hiroyuki Kamezawa
2011-06-13  3:09 ` [BUGFIX][PATCH 3/5] memcg: clear mm->owner when last possible owner leaves KAMEZAWA Hiroyuki
2011-06-13  3:09   ` KAMEZAWA Hiroyuki
2011-06-14  9:45   ` Johannes Weiner
2011-06-14  9:45     ` Johannes Weiner
2011-06-13  3:11 ` [BUGFIX][PATCH 4/5] memcg: fix wrong check of noswap with softlimit KAMEZAWA Hiroyuki
2011-06-13  3:11   ` KAMEZAWA Hiroyuki
2011-06-14  9:48   ` Johannes Weiner [this message]
2011-06-14  9:48     ` Johannes Weiner
2011-06-13  3:16 ` [BUGFIX][PATCH 5/5] memcg: fix percpu cached charge draining frequency KAMEZAWA Hiroyuki
2011-06-13  3:16   ` KAMEZAWA Hiroyuki
2011-06-13 21:25   ` Andrew Morton
2011-06-13 21:25     ` Andrew Morton
2011-06-15  0:09     ` KAMEZAWA Hiroyuki
2011-06-15  0:09       ` KAMEZAWA Hiroyuki
2011-06-15  1:19       ` Andrew Morton
2011-06-15  1:19         ` Andrew Morton
2011-06-14  7:36   ` Michal Hocko
2011-06-14  7:36     ` Michal Hocko
2011-06-15  0:12     ` KAMEZAWA Hiroyuki
2011-06-15  0:12       ` KAMEZAWA Hiroyuki
2011-06-15  1:12       ` KAMEZAWA Hiroyuki
2011-06-15  1:12         ` KAMEZAWA Hiroyuki
2011-06-15  7:15         ` Michal Hocko
2011-06-15  7:15           ` Michal Hocko
2011-06-14 10:04   ` Johannes Weiner
2011-06-14 10:04     ` Johannes Weiner
2011-06-15  0:16     ` KAMEZAWA Hiroyuki
2011-06-15  0:16       ` KAMEZAWA Hiroyuki
2011-06-15  1:49   ` [BUGFIX][PATCH v6] " KAMEZAWA Hiroyuki
2011-06-15  1:49     ` KAMEZAWA Hiroyuki
2011-06-15  1:52     ` [BUGFIX][PATCH v2] memcg: avoid percpu cached charge draining at softlimit KAMEZAWA Hiroyuki
2011-06-15  1:52       ` KAMEZAWA Hiroyuki
2011-06-15  5:30     ` [BUGFIX][PATCH v6] memcg: fix percpu cached charge draining frequency Ying Han
2011-06-15  5:30       ` Ying Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110614094811.GD6371@redhat.com \
    --to=jweiner@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.