From: Arnd Bergmann <arnd@arndb.de>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-sh@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment
Date: Thu, 16 Jun 2011 15:07:32 +0000 [thread overview]
Message-ID: <201106161707.32356.arnd@arndb.de> (raw)
In-Reply-To: <20110418082900.GB32457@linux-sh.org>
On Monday 18 April 2011, Paul Mundt wrote:
> On Thu, Apr 14, 2011 at 02:01:35AM -0400, Mike Frysinger wrote:
> > The Blackfin arch, like the x86 arch, needs to adjust the PC manually
> > after a breakpoint is hit as normally this is handled by the remote gdb.
> > However, rather than starting another arch ifdef mess, create a common
> > GDB_ADJUSTS_BREAK_OFFSET define for any arch to opt-in via their kgdb.h.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
This patch is causing build problems now, because the instruction_pointer_set()
that is used now is only defined in asm-generic/ptrace.h, which is only
used on x86, blackfin and sparc. Every other architecture now fails to
build.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Mike Frysinger <vapier@gentoo.org>,
Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>,
linux-kernel@vger.kernel.org,
kgdb-bugreport@lists.sourceforge.net,
Jason Wessel <jason.wessel@windriver.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-sh@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment
Date: Thu, 16 Jun 2011 17:07:32 +0200 [thread overview]
Message-ID: <201106161707.32356.arnd@arndb.de> (raw)
In-Reply-To: <20110418082900.GB32457@linux-sh.org>
On Monday 18 April 2011, Paul Mundt wrote:
> On Thu, Apr 14, 2011 at 02:01:35AM -0400, Mike Frysinger wrote:
> > The Blackfin arch, like the x86 arch, needs to adjust the PC manually
> > after a breakpoint is hit as normally this is handled by the remote gdb.
> > However, rather than starting another arch ifdef mess, create a common
> > GDB_ADJUSTS_BREAK_OFFSET define for any arch to opt-in via their kgdb.h.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Acked-by: Paul Mundt <lethal@linux-sh.org>
This patch is causing build problems now, because the instruction_pointer_set()
that is used now is only defined in asm-generic/ptrace.h, which is only
used on x86, blackfin and sparc. Every other architecture now fails to
build.
Arnd
next prev parent reply other threads:[~2011-06-16 15:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 6:01 [PATCH 0/5] ptrace low level unification Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-14 6:01 ` [PATCH 1/5] asm-generic/ptrace.h: start a common low level ptrace helper Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-14 18:09 ` [PATCH 1/5] asm-generic/ptrace.h: start a common low level Oleg Nesterov
2011-04-14 18:09 ` [PATCH 1/5] asm-generic/ptrace.h: start a common low level ptrace helper Oleg Nesterov
2011-04-14 18:16 ` Mike Frysinger
2011-04-14 18:16 ` Mike Frysinger
2011-04-14 6:01 ` [PATCH 2/5] Blackfin: convert to asm-generic ptrace.h Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-14 6:01 ` [PATCH 3/5] x86: " Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-14 14:16 ` [Kgdb-bugreport] " Sergei Shtylyov
2011-04-14 14:16 ` Sergei Shtylyov
2011-04-14 17:05 ` H. Peter Anvin
2011-04-14 17:05 ` H. Peter Anvin
2011-04-14 17:38 ` Sergei Shtylyov
2011-04-14 17:38 ` Sergei Shtylyov
2011-04-14 6:01 ` [PATCH 4/5] sh: " Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-14 14:22 ` [Kgdb-bugreport] " Sergei Shtylyov
2011-04-14 14:22 ` Sergei Shtylyov
2011-04-16 19:17 ` Paul Mundt
2011-04-16 19:17 ` Paul Mundt
2011-04-14 6:01 ` [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment Mike Frysinger
2011-04-14 6:01 ` Mike Frysinger
2011-04-18 8:29 ` Paul Mundt
2011-04-18 8:29 ` Paul Mundt
2011-06-16 15:07 ` Arnd Bergmann [this message]
2011-06-16 15:07 ` Arnd Bergmann
2011-06-16 20:06 ` Mike Frysinger
2011-06-16 20:06 ` Mike Frysinger
2011-06-16 20:07 ` Mike Frysinger
2011-06-16 20:07 ` Mike Frysinger
2011-06-16 20:21 ` Arnd Bergmann
2011-06-16 20:21 ` Arnd Bergmann
2011-06-16 20:29 ` Mike Frysinger
2011-06-16 20:29 ` Mike Frysinger
2011-04-19 5:36 ` [Kgdb-bugreport] [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint DDD
2011-04-19 5:36 ` [Kgdb-bugreport] [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment DDD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106161707.32356.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.