From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/12] mm: let swap use exceptional entries
Date: Sat, 18 Jun 2011 14:52:54 -0700 [thread overview]
Message-ID: <20110618145254.1b333344.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1106140342330.29206@sister.anvils>
On Tue, 14 Jun 2011 03:43:47 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> --- linux.orig/mm/filemap.c 2011-06-13 13:26:44.430284135 -0700
> +++ linux/mm/filemap.c 2011-06-13 13:27:34.526532556 -0700
> @@ -717,9 +717,12 @@ repeat:
> page = radix_tree_deref_slot(pagep);
> if (unlikely(!page))
> goto out;
> - if (radix_tree_deref_retry(page))
> + if (radix_tree_exception(page)) {
> + if (radix_tree_exceptional_entry(page))
> + goto out;
> + /* radix_tree_deref_retry(page) */
> goto repeat;
> -
> + }
> if (!page_cache_get_speculative(page))
> goto repeat;
All the crap^Wnice changes made to filemap.c really need some comments,
please. Particularly when they're keyed off the bland-sounding
"radix_tree_exception()". Apparently they have something to do with
swap, but how is the poor reader to know this?
Also, commenting out a function call might be meaningful information for
Hugh-right-now, but for other people later on, they're just a big WTF.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hughd@google.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/12] mm: let swap use exceptional entries
Date: Sat, 18 Jun 2011 14:52:54 -0700 [thread overview]
Message-ID: <20110618145254.1b333344.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1106140342330.29206@sister.anvils>
On Tue, 14 Jun 2011 03:43:47 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> --- linux.orig/mm/filemap.c 2011-06-13 13:26:44.430284135 -0700
> +++ linux/mm/filemap.c 2011-06-13 13:27:34.526532556 -0700
> @@ -717,9 +717,12 @@ repeat:
> page = radix_tree_deref_slot(pagep);
> if (unlikely(!page))
> goto out;
> - if (radix_tree_deref_retry(page))
> + if (radix_tree_exception(page)) {
> + if (radix_tree_exceptional_entry(page))
> + goto out;
> + /* radix_tree_deref_retry(page) */
> goto repeat;
> -
> + }
> if (!page_cache_get_speculative(page))
> goto repeat;
All the crap^Wnice changes made to filemap.c really need some comments,
please. Particularly when they're keyed off the bland-sounding
"radix_tree_exception()". Apparently they have something to do with
swap, but how is the poor reader to know this?
Also, commenting out a function call might be meaningful information for
Hugh-right-now, but for other people later on, they're just a big WTF.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-18 21:52 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 10:40 [PATCH 0/12] tmpfs: convert from old swap vector to radix tree Hugh Dickins
2011-06-14 10:40 ` Hugh Dickins
2011-06-14 10:42 ` [PATCH 1/12] radix_tree: exceptional entries and indices Hugh Dickins
2011-06-14 10:42 ` Hugh Dickins
2011-06-14 11:22 ` Pekka Enberg
2011-06-14 11:22 ` Pekka Enberg
2011-06-15 0:24 ` Hugh Dickins
2011-06-17 23:38 ` Andrew Morton
2011-06-17 23:38 ` Andrew Morton
2011-06-18 0:07 ` Randy Dunlap
2011-06-18 0:07 ` Randy Dunlap
2011-06-18 0:12 ` Randy Dunlap
2011-06-18 0:12 ` Randy Dunlap
2011-06-18 1:52 ` Hugh Dickins
2011-06-18 1:52 ` Hugh Dickins
2011-07-19 22:36 ` Hugh Dickins
2011-07-19 22:36 ` Hugh Dickins
2011-07-19 23:28 ` Randy Dunlap
2011-07-19 23:28 ` Randy Dunlap
2011-06-18 0:13 ` Hugh Dickins
2011-06-18 0:13 ` Hugh Dickins
2011-06-18 21:48 ` Andrew Morton
2011-06-18 21:48 ` Andrew Morton
2011-07-12 22:56 ` Hugh Dickins
2011-07-12 22:56 ` Hugh Dickins
2011-07-12 23:24 ` Andrew Morton
2011-07-12 23:24 ` Andrew Morton
2011-07-13 22:27 ` Hugh Dickins
2011-07-13 22:27 ` Hugh Dickins
2011-06-14 10:43 ` [PATCH 2/12] mm: let swap use exceptional entries Hugh Dickins
2011-06-14 10:43 ` Hugh Dickins
2011-06-18 21:52 ` Andrew Morton [this message]
2011-06-18 21:52 ` Andrew Morton
2011-07-12 22:08 ` Hugh Dickins
2011-07-12 22:08 ` Hugh Dickins
2011-07-13 23:11 ` Andrew Morton
2011-07-13 23:11 ` Andrew Morton
2011-07-19 22:46 ` Hugh Dickins
2011-07-19 22:46 ` Hugh Dickins
2011-06-18 21:55 ` Andrew Morton
2011-06-18 21:55 ` Andrew Morton
2011-07-12 22:35 ` Hugh Dickins
2011-07-12 22:35 ` Hugh Dickins
2011-06-14 10:45 ` [PATCH 3/12] tmpfs: demolish old swap vector support Hugh Dickins
2011-06-14 10:45 ` Hugh Dickins
2011-06-14 10:48 ` [PATCH 4/12] tmpfs: miscellaneous trivial cleanups Hugh Dickins
2011-06-14 10:48 ` Hugh Dickins
2011-06-14 10:49 ` [PATCH 5/12] tmpfs: copy truncate_inode_pages_range Hugh Dickins
2011-06-14 10:49 ` Hugh Dickins
2011-06-14 10:51 ` [PATCH 6/12] tmpfs: convert shmem_truncate_range to radix-swap Hugh Dickins
2011-06-14 10:51 ` Hugh Dickins
2011-06-14 10:52 ` [PATCH 7/12] tmpfs: convert shmem_unuse_inode " Hugh Dickins
2011-06-14 10:52 ` Hugh Dickins
2011-06-14 10:53 ` [PATCH 8/12] tmpfs: convert shmem_getpage_gfp " Hugh Dickins
2011-06-14 10:53 ` Hugh Dickins
2011-06-14 10:54 ` [PATCH 9/12] tmpfs: convert mem_cgroup shmem " Hugh Dickins
2011-06-14 10:54 ` Hugh Dickins
2011-06-14 10:56 ` [PATCH 10/12] tmpfs: convert shmem_writepage and enable swap Hugh Dickins
2011-06-14 10:56 ` Hugh Dickins
2011-06-14 10:57 ` [PATCH 11/12] tmpfs: use kmemdup for short symlinks Hugh Dickins
2011-06-14 10:57 ` Hugh Dickins
2011-06-14 11:16 ` Pekka Enberg
2011-06-14 11:16 ` Pekka Enberg
2011-06-14 10:59 ` [PATCH 12/12] mm: a few small updates for radix-swap Hugh Dickins
2011-06-14 10:59 ` Hugh Dickins
2011-06-15 0:49 ` [PATCH v2 " Hugh Dickins
2011-06-15 0:49 ` Hugh Dickins
2011-06-14 17:29 ` [PATCH 0/12] tmpfs: convert from old swap vector to radix tree Linus Torvalds
2011-06-14 17:29 ` Linus Torvalds
2011-06-14 18:20 ` Rik van Riel
2011-06-14 18:20 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110618145254.1b333344.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.