From: Andrea Arcangeli <aarcange@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Randy Dunlap <rdunlap@xenotime.net>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <jweiner@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0
Date: Tue, 21 Jun 2011 15:30:53 +0200 [thread overview]
Message-ID: <20110621133053.GO20843@redhat.com> (raw)
In-Reply-To: <1308643849-3325-1-git-send-email-amwang@redhat.com>
On Tue, Jun 21, 2011 at 04:10:42PM +0800, Amerigo Wang wrote:
> Introduce "transparent_hugepage=0" to totally disable THP.
> "transparent_hugepage=never" means setting THP to be partially
> disabled, we need a new way to totally disable it.
>
I think I already clarified this is not worth it. Removing sysfs
registration is just pointless. If you really want to save ~8k of RAM,
at most you can try to move the init of the khugepaged slots hash and
the kmem_cache_init to the khugepaged deamon start but even that isn't
so useful. Not registering into sysfs is just pointless and it's a
gratuitous loss of a feature.
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Randy Dunlap <rdunlap@xenotime.net>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <jweiner@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0
Date: Tue, 21 Jun 2011 15:30:53 +0200 [thread overview]
Message-ID: <20110621133053.GO20843@redhat.com> (raw)
In-Reply-To: <1308643849-3325-1-git-send-email-amwang@redhat.com>
On Tue, Jun 21, 2011 at 04:10:42PM +0800, Amerigo Wang wrote:
> Introduce "transparent_hugepage=0" to totally disable THP.
> "transparent_hugepage=never" means setting THP to be partially
> disabled, we need a new way to totally disable it.
>
I think I already clarified this is not worth it. Removing sysfs
registration is just pointless. If you really want to save ~8k of RAM,
at most you can try to move the init of the khugepaged slots hash and
the kmem_cache_init to the khugepaged deamon start but even that isn't
so useful. Not registering into sysfs is just pointless and it's a
gratuitous loss of a feature.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-21 13:56 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 8:10 [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Amerigo Wang
2011-06-21 8:10 ` Amerigo Wang
2011-06-21 8:10 ` [PATCH v2 2/4] mm: make the threshold of enabling THP configurable Amerigo Wang
2011-06-21 8:10 ` Amerigo Wang
2011-06-21 14:44 ` Dave Hansen
2011-06-21 14:44 ` Dave Hansen
2011-06-21 20:17 ` Dave Hansen
2011-06-21 20:17 ` Dave Hansen
2011-06-22 1:23 ` David Rientjes
2011-06-22 1:23 ` David Rientjes
2011-06-22 3:06 ` Cong Wang
2011-06-22 3:06 ` Cong Wang
2011-06-22 3:29 ` David Rientjes
2011-06-22 3:29 ` David Rientjes
2011-06-22 5:40 ` Cong Wang
2011-06-22 5:40 ` Cong Wang
2011-06-22 6:32 ` David Rientjes
2011-06-22 6:32 ` David Rientjes
2011-06-22 11:07 ` Cong Wang
2011-06-22 11:07 ` Cong Wang
2011-06-22 14:40 ` Andrea Arcangeli
2011-06-22 14:40 ` Andrea Arcangeli
2011-06-23 6:51 ` Cong Wang
2011-06-23 6:51 ` Cong Wang
2011-06-21 8:10 ` [PATCH 3/4] mm: improve THP printk messages Amerigo Wang
2011-06-21 8:10 ` Amerigo Wang
2011-06-22 1:23 ` David Rientjes
2011-06-22 1:23 ` David Rientjes
2011-06-22 3:04 ` Cong Wang
2011-06-22 3:04 ` Cong Wang
2011-06-21 8:10 ` [PATCH 4/4] mm: introduce no_ksm to disable totally KSM Amerigo Wang
2011-06-21 8:10 ` Amerigo Wang
2011-06-21 13:32 ` Andrea Arcangeli
2011-06-21 13:32 ` Andrea Arcangeli
2011-06-22 3:13 ` Cong Wang
2011-06-22 3:13 ` Cong Wang
2011-06-21 11:52 ` [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Michal Hocko
2011-06-21 11:52 ` Michal Hocko
2011-06-21 11:58 ` Michal Hocko
2011-06-21 11:58 ` Michal Hocko
2011-06-21 13:30 ` Andrea Arcangeli [this message]
2011-06-21 13:30 ` Andrea Arcangeli
2011-06-22 3:11 ` Cong Wang
2011-06-22 3:11 ` Cong Wang
2011-06-22 1:16 ` David Rientjes
2011-06-22 1:16 ` David Rientjes
2011-06-22 3:08 ` Cong Wang
2011-06-22 3:08 ` Cong Wang
2011-06-22 3:24 ` David Rientjes
2011-06-22 3:24 ` David Rientjes
2011-06-22 5:45 ` Cong Wang
2011-06-22 5:45 ` Cong Wang
2011-06-22 6:23 ` David Rientjes
2011-06-22 6:23 ` David Rientjes
2011-06-22 11:08 ` Cong Wang
2011-06-22 11:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621133053.GO20843@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rdunlap@xenotime.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.