* [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
@ 2011-06-15 17:15 Florian Fainelli
2011-06-22 8:24 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2011-06-15 17:15 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-mips, linux-watchdog, Manuel Lauss, Jamie Iles
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
No changes in v1, v2 and v3
diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
index 1479dc4..63df28c 100644
--- a/drivers/watchdog/mtx-1_wdt.c
+++ b/drivers/watchdog/mtx-1_wdt.c
@@ -224,11 +224,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev)
ret = misc_register(&mtx1_wdt_misc);
if (ret < 0) {
- printk(KERN_ERR " mtx-1_wdt : failed to register\n");
+ dev_err(&pdev->dev, "failed to register\n");
return ret;
}
mtx1_wdt_start();
- printk(KERN_INFO "MTX-1 Watchdog driver\n");
+ dev_info(&pdev->dev, "MTX-1 Watchdog driver\n");
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
2011-06-15 17:15 [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk() Florian Fainelli
@ 2011-06-22 8:24 ` Florian Fainelli
2011-06-22 8:58 ` Wim Van Sebroeck
0 siblings, 1 reply; 4+ messages in thread
From: Florian Fainelli @ 2011-06-22 8:24 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-mips, linux-watchdog, Manuel Lauss, Jamie Iles
On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> No changes in v1, v2 and v3
Wim, these are mostly fixes for the driver, do you prefer they get merged with the MIPS tree?
>
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 1479dc4..63df28c 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -224,11 +224,11 @@ static int __devinit mtx1_wdt_probe(struct
> platform_device *pdev)
>
> ret = misc_register(&mtx1_wdt_misc);
> if (ret < 0) {
> - printk(KERN_ERR " mtx-1_wdt : failed to register\n");
> + dev_err(&pdev->dev, "failed to register\n");
> return ret;
> }
> mtx1_wdt_start();
> - printk(KERN_INFO "MTX-1 Watchdog driver\n");
> + dev_info(&pdev->dev, "MTX-1 Watchdog driver\n");
> return 0;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
2011-06-22 8:24 ` Florian Fainelli
@ 2011-06-22 8:58 ` Wim Van Sebroeck
2011-06-22 9:05 ` Florian Fainelli
0 siblings, 1 reply; 4+ messages in thread
From: Wim Van Sebroeck @ 2011-06-22 8:58 UTC (permalink / raw)
To: Florian Fainelli
Cc: Wim Van Sebroeck, linux-mips, linux-watchdog, Manuel Lauss,
Jamie Iles
Hi Florian,
> On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
> > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > ---
> > No changes in v1, v2 and v3
>
> Wim, these are mostly fixes for the driver, do you prefer they get merged with the MIPS tree?
No, I had them in linux-2.6-watchdog-next since this weekend allready and was planning to sent the fixes upstream.
But I think I fotgot to e-mail about it. :-(
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
2011-06-22 8:58 ` Wim Van Sebroeck
@ 2011-06-22 9:05 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2011-06-22 9:05 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-mips, linux-watchdog, Manuel Lauss, Jamie Iles
Hello Wim,
On Wednesday 22 June 2011 10:58:09 Wim Van Sebroeck wrote:
> Hi Florian,
>
> > On Wednesday 15 June 2011 19:15:09 Florian Fainelli wrote:
> > > Signed-off-by: Florian Fainelli <florian@openwrt.org>
> > > ---
> > > No changes in v1, v2 and v3
> >
> > Wim, these are mostly fixes for the driver, do you prefer they get merged
> > with the MIPS tree?
>
> No, I had them in linux-2.6-watchdog-next since this weekend allready and
> was planning to sent the fixes upstream. But I think I fotgot to e-mail
> about it. :-(
No problem, thanks for the heads up.
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-22 9:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 17:15 [PATCH 1/5 v3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk() Florian Fainelli
2011-06-22 8:24 ` Florian Fainelli
2011-06-22 8:58 ` Wim Van Sebroeck
2011-06-22 9:05 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.