Re: Re: Konrad devel/next-3.0, pci-passthrough not working: Error: pci: PCI Backend and pci-stub don't own device

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]

> >> >> module name: xen_pciback
> >> >> driver:      pciback
> >> >> 
> >> >> Quite a mix of names, and different use of minus and underscore.
> >> 
> >> > Hmm, you are a right. I somehow I thought I backed up the patch that
> >> > used the wrong name (well, not wrong but just incorrect).
> >> 
> >> So if I understand you correct you will revert the driver name from xen-pciback to pciback, so no xen change is needed ?
> 
> > So this patch:
> > f3fc28d52f42220bcce8c2fed12aef2a88c9fadc
> 
> >     xen/pciback: revert the name of the PCI driver to 'pciback'.
> 
> > should have done the trick but I am not seeing it in the
> > devel/xen-pciback-0.6.. Aha! I forgot to push the branch up to git.kernel.org.
> 
> > Before I do that, can you cherry-pick that one please and tell
> > me if it works? If it does I will stick 'Reported-by' and 'Tested-by'
> > on the patch if you are OK with that.
> 
> And were exactly do i cherry pick that from ? :-) since you say you haven't pushed it :p

<smacks his head>
> If you can attach the patch i will test it right away, sticking the reported and tested-by is fine !

See attached or inline:

commit f3fc28d52f42220bcce8c2fed12aef2a88c9fadc
Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date:   Wed Apr 20 16:06:47 2011 -0400

    xen/pciback: revert the name of the PCI driver to 'pciback'.
    
    At least until the toolstack catches up and it will be able
    to handle 'xen_pciback'.
    
    This means we have these directories in sysfs:
    
    ./bus/pci/drivers/pciback
    ./bus/xen-backend/drivers/xen-pciback
    ./module/xen_pciback
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

diff --git a/drivers/pci/xen-pciback/pci_stub.c b/drivers/pci/xen-pciback/pci_stub.c
index d802261..aec214a 100644
--- a/drivers/pci/xen-pciback/pci_stub.c
+++ b/drivers/pci/xen-pciback/pci_stub.c
@@ -848,7 +848,9 @@ static struct pci_error_handlers xen_pcibk_error_handler = {
  */
 
 static struct pci_driver xen_pcibk_pci_driver = {
-	.name = DRV_NAME,
+	/* The name should be xen_pciback, but until the tools are updated
+	 * we will keep it as pciback. */
+	.name = "pciback",
 	.id_table = pcistub_ids,
 	.probe = pcistub_probe,
 	.remove = pcistub_remove,

[-- Attachment #2: pciback.patch --]
[-- Type: text/x-diff, Size: 1099 bytes --]

commit f3fc28d52f42220bcce8c2fed12aef2a88c9fadc
Author: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date:   Wed Apr 20 16:06:47 2011 -0400

    xen/pciback: revert the name of the PCI driver to 'pciback'.
    
    At least until the toolstack catches up and it will be able
    to handle 'xen_pciback'.
    
    This means we have these directories in sysfs:
    
    ./bus/pci/drivers/pciback
    ./bus/xen-backend/drivers/xen-pciback
    ./module/xen_pciback
    
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

diff --git a/drivers/pci/xen-pciback/pci_stub.c b/drivers/pci/xen-pciback/pci_stub.c
index d802261..aec214a 100644
--- a/drivers/pci/xen-pciback/pci_stub.c
+++ b/drivers/pci/xen-pciback/pci_stub.c
@@ -848,7 +848,9 @@ static struct pci_error_handlers xen_pcibk_error_handler = {
  */
 
 static struct pci_driver xen_pcibk_pci_driver = {
-	.name = DRV_NAME,
+	/* The name should be xen_pciback, but until the tools are updated
+	 * we will keep it as pciback. */
+	.name = "pciback",
 	.id_table = pcistub_ids,
 	.probe = pcistub_probe,
 	.remove = pcistub_remove,

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel