All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH] hwmon: LM95245 driver
Date: Thu, 23 Jun 2011 14:26:41 +0000	[thread overview]
Message-ID: <20110623142641.GD28311@ericsson.com> (raw)
In-Reply-To: <201106231250.38266.alexander.stein@systec-electronic.com>

On Thu, Jun 23, 2011 at 06:50:37AM -0400, Alexander Stein wrote:
> On Thursday 23 June 2011 11:33:16 Jean Delvare wrote:
> > On Thu, 23 Jun 2011 11:14:52 +0200, Alexander Stein wrote:
> > > Well, I noticed that. But I went the way lm95241 does. I'm also unsure
> > > which interval to choose, if user specify a unsupported interval. Choose
> > > the next small or the next greater one? Maybe you can give me a hint
> > > here.
> > 
> > BTW, is the LM95245 so incompatible that support couldn't be added to
> > the lm95241 driver? If both devices are compatible to a reasonable
> > degree, a single driver would be preferred.
> 
> Well, the register mapping is completly different. Also some configuration 
> bits are merged and moved into other registers than in lm95241. I doubt there 
> is much more compatibility than i2c transfers and temperature format (despite 
> unsigned/unsigned).
> 
Same conclusion here. Odd but true.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: LM95245 driver
Date: Thu, 23 Jun 2011 07:26:41 -0700	[thread overview]
Message-ID: <20110623142641.GD28311@ericsson.com> (raw)
In-Reply-To: <201106231250.38266.alexander.stein@systec-electronic.com>

On Thu, Jun 23, 2011 at 06:50:37AM -0400, Alexander Stein wrote:
> On Thursday 23 June 2011 11:33:16 Jean Delvare wrote:
> > On Thu, 23 Jun 2011 11:14:52 +0200, Alexander Stein wrote:
> > > Well, I noticed that. But I went the way lm95241 does. I'm also unsure
> > > which interval to choose, if user specify a unsupported interval. Choose
> > > the next small or the next greater one? Maybe you can give me a hint
> > > here.
> > 
> > BTW, is the LM95245 so incompatible that support couldn't be added to
> > the lm95241 driver? If both devices are compatible to a reasonable
> > degree, a single driver would be preferred.
> 
> Well, the register mapping is completly different. Also some configuration 
> bits are merged and moved into other registers than in lm95241. I doubt there 
> is much more compatibility than i2c transfers and temperature format (despite 
> unsigned/unsigned).
> 
Same conclusion here. Odd but true.

Guenter

  reply	other threads:[~2011-06-23 14:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21  9:52 [lm-sensors] [PATCH] hwmon: LM95245 driver Alexander Stein
2011-06-21  9:52 ` Alexander Stein
2011-06-22 19:15 ` [lm-sensors] " Guenter Roeck
2011-06-22 19:15   ` Guenter Roeck
2011-06-23  9:14   ` [lm-sensors] " Alexander Stein
2011-06-23  9:14     ` Alexander Stein
2011-06-23  9:33     ` [lm-sensors] " Jean Delvare
2011-06-23  9:33       ` Jean Delvare
2011-06-23 10:50       ` [lm-sensors] " Alexander Stein
2011-06-23 10:50         ` Alexander Stein
2011-06-23 14:26         ` Guenter Roeck [this message]
2011-06-23 14:26           ` Guenter Roeck
2011-06-23 14:47     ` [lm-sensors] " Guenter Roeck
2011-06-23 14:47       ` Guenter Roeck
2011-06-23 15:14       ` [lm-sensors] " Alexander Stein
2011-06-23 15:14         ` Alexander Stein
2011-06-23 15:35         ` [lm-sensors] " Guenter Roeck
2011-06-23 15:35           ` Guenter Roeck
2011-06-27 15:49           ` [lm-sensors] [PATCH v2] " Alexander Stein
2011-06-27 15:49             ` Alexander Stein
2011-06-27 20:21             ` [lm-sensors] " Guenter Roeck
2011-06-27 20:21               ` Guenter Roeck
2011-06-28  7:07               ` [lm-sensors] [PATCH v3] " Alexander Stein
2011-06-28  7:07                 ` Alexander Stein
2011-06-28 14:43                 ` [lm-sensors] " Guenter Roeck
2011-06-28 14:43                   ` Guenter Roeck
2011-06-28 15:11                   ` [lm-sensors] [PATCH v4] " Alexander Stein
2011-06-28 15:11                     ` Alexander Stein
2011-06-30  9:06                     ` [lm-sensors] " Guenter Roeck
2011-06-30  9:06                       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110623142641.GD28311@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.