From: Ralf Baechle <ralf@linux-mips.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: devel@driverdev.osuosl.org, David Howells <dhowells@redhat.com>,
linux-m32r@ml.linux-m32r.org, linux-ia64@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>,
Martyn Welch <martyn.welch@ge.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"linuxppc-dev@lists.ozlabs.org Tony Luck" <tony.luck@intel.com>,
linux-am33-list@redhat.com, Paul Mackerras <paulus@samba.org>,
linux-m32r-ja@ml.linux-m32r.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE
Date: Thu, 23 Jun 2011 16:05:57 +0100 [thread overview]
Message-ID: <20110623150557.GA9258@linux-mips.org> (raw)
In-Reply-To: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote:
> > (Adding the PPC folks to cc.)
> >
> > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so
> > I don't think the driver will build there. I don't have a PPC toolchain
> > to verify that.
>
> I can verify it fails on PPC as well:
>
> drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
> drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in
>
> However, we do have a #define for PAGE_KERNEL_NC.
Do you think this driver in it's current stage is so valuable that some
ifdefery to get it to work on PPC is the way to go?
IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too.
But preferably the driver should be sorted out properly and until the v1
of my patch which disables it on all architectures that don't provide a
PAGE_KERNEL_NOCACHE definition will do just fine.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Martyn Welch <martyn.welch@ge.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org,
linux-am33-list@redhat.com, Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-arch@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org Tony Luck" <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE
Date: Thu, 23 Jun 2011 16:05:57 +0100 [thread overview]
Message-ID: <20110623150557.GA9258@linux-mips.org> (raw)
Message-ID: <20110623150557.VX-WmOIH0GmXlIO2Fbgm3PjQky9_xH0mb_eR9uR2PLo@z> (raw)
In-Reply-To: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote:
> > (Adding the PPC folks to cc.)
> >
> > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so
> > I don't think the driver will build there. I don't have a PPC toolchain
> > to verify that.
>
> I can verify it fails on PPC as well:
>
> drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
> drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in
>
> However, we do have a #define for PAGE_KERNEL_NC.
Do you think this driver in it's current stage is so valuable that some
ifdefery to get it to work on PPC is the way to go?
IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too.
But preferably the driver should be sorted out properly and until the v1
of my patch which disables it on all architectures that don't provide a
PAGE_KERNEL_NOCACHE definition will do just fine.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: devel@driverdev.osuosl.org, David Howells <dhowells@redhat.com>,
linux-m32r@ml.linux-m32r.org, linux-ia64@vger.kernel.org,
Paul Mundt <lethal@linux-sh.org>,
linux-sh@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Chris Metcalf <cmetcalf@tilera.com>,
Martyn Welch <martyn.welch@ge.com>,
Fenghua Yu <fenghua.yu@intel.com>,
"linuxppc-dev@lists.ozlabs.org Tony Luck" <tony.luck@intel.com>,
linux-am33-list@redhat.com, Paul Mackerras <paulus@samba.org>,
linux-m32r-ja@ml.linux-m32r.org, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing
Date: Thu, 23 Jun 2011 15:05:57 +0000 [thread overview]
Message-ID: <20110623150557.GA9258@linux-mips.org> (raw)
In-Reply-To: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org>
On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote:
> > (Adding the PPC folks to cc.)
> >
> > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so
> > I don't think the driver will build there. I don't have a PPC toolchain
> > to verify that.
>
> I can verify it fails on PPC as well:
>
> drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc':
> drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function)
> drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in
>
> However, we do have a #define for PAGE_KERNEL_NC.
Do you think this driver in it's current stage is so valuable that some
ifdefery to get it to work on PPC is the way to go?
IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too.
But preferably the driver should be sorted out properly and until the v1
of my patch which disables it on all architectures that don't provide a
PAGE_KERNEL_NOCACHE definition will do just fine.
Ralf
next prev parent reply other threads:[~2011-06-23 15:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 11:45 [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Ralf Baechle
2011-06-23 11:45 ` [PATCH] STAGING: Comedi: Build only on arches providing Ralf Baechle
2011-06-23 11:45 ` [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Ralf Baechle
2011-06-23 11:53 ` Martyn Welch
2011-06-23 11:53 ` Martyn Welch
2011-06-23 11:53 ` Martyn Welch
2011-06-23 12:02 ` Ralf Baechle
2011-06-23 12:02 ` Ralf Baechle
2011-06-23 12:02 ` [PATCH] STAGING: Comedi: Build only on arches providing Ralf Baechle
2011-06-23 12:02 ` [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Ralf Baechle
2011-06-23 12:10 ` Kumar Gala
2011-06-23 12:10 ` Kumar Gala
2011-06-23 12:10 ` Kumar Gala
2011-06-23 12:10 ` Kumar Gala
2011-06-23 15:05 ` Ralf Baechle [this message]
2011-06-23 15:05 ` [PATCH] STAGING: Comedi: Build only on arches providing Ralf Baechle
2011-06-23 15:05 ` [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Ralf Baechle
2011-06-23 12:13 ` Martyn Welch
2011-06-23 12:13 ` Martyn Welch
2011-06-23 12:13 ` Martyn Welch
2011-06-23 22:01 ` Benjamin Herrenschmidt
2011-06-23 22:01 ` Benjamin Herrenschmidt
2011-06-23 22:01 ` [PATCH] STAGING: Comedi: Build only on arches providing Benjamin Herrenschmidt
2011-06-23 16:01 ` [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Geert Uytterhoeven
2011-06-23 16:01 ` Geert Uytterhoeven
2011-06-23 16:31 ` Ralf Baechle
2011-06-23 16:31 ` [PATCH] STAGING: Comedi: Build only on arches providing Ralf Baechle
2011-06-23 16:31 ` [PATCH] STAGING: Comedi: Build only on arches providing PAGE_KERNEL_NOCACHE Ralf Baechle
2011-06-23 19:18 ` Arnaud Lacombe
2011-06-23 19:18 ` Arnaud Lacombe
2011-06-23 23:55 ` Stephen Rothwell
2011-06-23 23:55 ` [PATCH] STAGING: Comedi: Build only on arches providing Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110623150557.GA9258@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linux-sh@vger.kernel.org \
--cc=martyn.welch@ge.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.