All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wu DaoGuang <wdgvip@gmail.com>
Cc: ben-linux@fluff.org, kgene.kim@samsung.com,
	dmitry.torokhov@gmail.com, wdgvip@gamil.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] INPUT:Add ABS_PRESSURE input event support for touchscreen driver
Date: Fri, 24 Jun 2011 13:41:55 +0100	[thread overview]
Message-ID: <20110624124154.GC19804@sirena.org.uk> (raw)
In-Reply-To: <1308881738-6392-1-git-send-email-wdgvip@gmail.com>

On Fri, Jun 24, 2011 at 10:15:38AM +0800, Wu DaoGuang wrote:
> The touchscreen driver s3c2410_ts.c doesn't work well when using
> the tslib, an abstraction layer for touchscreen panel events.
> Tslib needs ABS_X ABS_Y and ABS_PRESSURE events to report, but only
> the former two the driver can provide.

It seems much more sane to fix this in tslib, the kernel is not actually
reporting pressure meaningfully here and there's already BTN_TOUCH to
report if the pen is down.

WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] INPUT:Add ABS_PRESSURE input event support for touchscreen driver
Date: Fri, 24 Jun 2011 13:41:55 +0100	[thread overview]
Message-ID: <20110624124154.GC19804@sirena.org.uk> (raw)
In-Reply-To: <1308881738-6392-1-git-send-email-wdgvip@gmail.com>

On Fri, Jun 24, 2011 at 10:15:38AM +0800, Wu DaoGuang wrote:
> The touchscreen driver s3c2410_ts.c doesn't work well when using
> the tslib, an abstraction layer for touchscreen panel events.
> Tslib needs ABS_X ABS_Y and ABS_PRESSURE events to report, but only
> the former two the driver can provide.

It seems much more sane to fix this in tslib, the kernel is not actually
reporting pressure meaningfully here and there's already BTN_TOUCH to
report if the pen is down.

  parent reply	other threads:[~2011-06-24 12:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-24  2:15 [PATCH] INPUT:Add ABS_PRESSURE input event support for touchscreen driver Wu DaoGuang
2011-06-24  2:15 ` Wu DaoGuang
2011-06-24  2:26 ` Joonyoung Shim
2011-06-24  2:26   ` Joonyoung Shim
2011-06-24 12:41 ` Mark Brown [this message]
2011-06-24 12:41   ` Mark Brown
2011-06-27  2:15   ` daoguang wu
2011-06-27  2:15     ` daoguang wu
2011-06-27  2:15     ` daoguang wu
2011-06-27  3:05     ` Baohua Song
2011-06-27  3:05       ` Baohua Song
2011-06-27  3:05       ` Baohua Song
     [not found]       ` <a8885a55-bf77-43d7-8491-045137aa38ee@email.android.com>
2011-06-27  8:57         ` daoguang wu
2011-06-27  8:57           ` daoguang wu
2011-06-27  8:57           ` daoguang wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110624124154.GC19804@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=ben-linux@fluff.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wdgvip@gamil.com \
    --cc=wdgvip@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.