From: Ralf Baechle <ralf@linux-mips.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure
Date: Fri, 24 Jun 2011 14:08:18 +0100 [thread overview]
Message-ID: <20110624130818.GC6327@linux-mips.org> (raw)
In-Reply-To: <s5hzkl72zce.wl%tiwai@suse.de>
On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote:
> > o The drivers/media/radio/Kconfig part should be applied for 3.0 and
> > maybe -stable.
>
> Yes, this will be good.
I just tested that segment only and it works as expected. Will repost in
a minute.
> > o The sound/isa/Kconfig part is basically only fixing the dependency for
> > the Adlib driver allowing it to be built on non-ISA_DMA_API system and
> > is material for the next release after 3.0.
>
> Any serious reason that snd-adlib must be built even with ISA=n?
Definately not.
> As the device is really present only for ISA, it doesn't make much
> sense to build this even though the driver itself doesn't need
> ISA_DMA_API.
I'm not aware of any systems that could use the Adlib in a ISA=n
environment. That's why my patch left the dependency on ISA untouched.
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Jaroslav Kysela <perex@perex.cz>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure
Date: Fri, 24 Jun 2011 14:08:18 +0100 [thread overview]
Message-ID: <20110624130818.GC6327@linux-mips.org> (raw)
In-Reply-To: <s5hzkl72zce.wl%tiwai@suse.de>
On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote:
> > o The drivers/media/radio/Kconfig part should be applied for 3.0 and
> > maybe -stable.
>
> Yes, this will be good.
I just tested that segment only and it works as expected. Will repost in
a minute.
> > o The sound/isa/Kconfig part is basically only fixing the dependency for
> > the Adlib driver allowing it to be built on non-ISA_DMA_API system and
> > is material for the next release after 3.0.
>
> Any serious reason that snd-adlib must be built even with ISA=n?
Definately not.
> As the device is really present only for ISA, it doesn't make much
> sense to build this even though the driver itself doesn't need
> ISA_DMA_API.
I'm not aware of any systems that could use the Adlib in a ISA=n
environment. That's why my patch left the dependency on ISA untouched.
Ralf
next prev parent reply other threads:[~2011-06-24 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 14:47 [PATCH] SOUND: Fix non-ISA_DMA_API build failure Ralf Baechle
2011-06-23 14:47 ` Ralf Baechle
2011-06-24 8:26 ` Takashi Iwai
2011-06-24 11:16 ` Ralf Baechle
2011-06-24 11:16 ` Ralf Baechle
2011-06-24 11:35 ` Mauro Carvalho Chehab
2011-06-24 11:35 ` Mauro Carvalho Chehab
2011-06-24 12:09 ` Ralf Baechle
2011-06-24 12:09 ` Ralf Baechle
2011-06-24 12:22 ` Takashi Iwai
2011-06-24 12:22 ` Takashi Iwai
2011-06-24 13:08 ` Ralf Baechle [this message]
2011-06-24 13:08 ` Ralf Baechle
2011-06-24 13:14 ` Takashi Iwai
2011-06-24 13:14 ` Takashi Iwai
2011-06-24 13:19 ` Arnd Bergmann
2011-06-24 13:36 ` Ralf Baechle
2011-06-24 13:36 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110624130818.GC6327@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mchehab@infradead.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.